This bug was filed from the crash reporting server and is br-74b65776-8b0b-4094-8cc4-eeffea082f65. ========================================= http://crashreport.libreoffice.org/stats/crash_details/74b65776-8b0b-4094-8cc4-eeffea082f65 http://crashreport.libreoffice.org/stats/signature/%60anonymous%20namespace%27::ScCaptionCreator::UpdateCaptionPos%28%29 1. Open attachment 68921 [details] from Bug 56279 and Bug 56294 2. Select cells B5:C5 using Mouse (in Bug 56294 you select A5:B5) 3. Menu 'Format -> Merge Cells -> Merge and Center Cells 4. Undo -> you get crash Regression.
Confirming crash with Version: 5.4.0.0.alpha0+ Build ID: 2670ca3fc597decae78499d1397539668eb84e5e CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; TinderBox: Win-x86@42, Branch:master, Time: 2017-01-31_05:32:46 and with Versie: 5.2.2.1 Build ID: 3c2231d4aa4c68281f28ad35a100c092cff84f5d CPU Threads: 4; Versie besturingssysteem:Windows 6.2; UI Render: standaard; Locale: nl-NL (nl_NL); Calc: CL but not with Version: 5.1.0.3 Build ID: 5e3e00a007d9b3b6efb6797a8b8e57b51ab1f737 CPU Threads: 4; OS Version: Windows 6.2; UI Render: default; Locale: en-US (nl_NL)
Regression introduced in range https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=a420a4346ec21ea561f1321767d6a5eed98df02b..45701913f642b17aabd67b52de9002cc79cf07ae @Aron, would you mind bisecting this one?
Bibisected with repo bibisect-win32-5.2. 122228e8fa47941375b9fcb3b5c41ee4945880cb is the first bad commit commit 122228e8fa47941375b9fcb3b5c41ee4945880cb Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Wed Mar 9 16:33:39 2016 -0800 source 7c0f6b9d0fb8d7d9e54865ccf1047bb8f8148101 # bad: [ce3bdd3a861e140979c75eeb56e5e2c7d0dd00cd] source 45701913f642b17aabd67b52de9002cc79cf07ae # good: [dfc2a983418964c4608f8f7b23d9947cdea7a1d6] source a420a4346ec21ea561f1321767d6a5eed98df02b git bisect start 'ce3bdd3a861e140979c75eeb56e5e2c7d0dd00cd' 'dfc2a983418964c4608f8f7b23d9947cdea7a1d6' # good: [f1fed57552870f0cbe204edd91ecac6bbc163522] source 07d4c443e21cd22545d4516515c50b1c8dd39a9b git bisect good f1fed57552870f0cbe204edd91ecac6bbc163522 # good: [3ef7113c324c5814e0e89ed63cdf9febdb4f033a] source b38f58a3f959b5e36813f8c2d88bdb2baf03a1b9 git bisect good 3ef7113c324c5814e0e89ed63cdf9febdb4f033a # good: [641eb3eed84cbab5636f2aa07e556ce178d03c3f] source 10f048bafa52bc443249bf7abe23ad5c96f98f80 git bisect good 641eb3eed84cbab5636f2aa07e556ce178d03c3f # bad: [82c187880a973bcdc43b42d5d6f9e2f852fe6f1f] source 6651aca57bae1bef3343f26d1a0fd59d3802c1cd git bisect bad 82c187880a973bcdc43b42d5d6f9e2f852fe6f1f # bad: [b9838bb99a273341f38ced4b4c5e3f423ea86324] source 6f6c21ad91d10f160ab904985cfcaefd98102636 git bisect bad b9838bb99a273341f38ced4b4c5e3f423ea86324 # bad: [122228e8fa47941375b9fcb3b5c41ee4945880cb] source 7c0f6b9d0fb8d7d9e54865ccf1047bb8f8148101 git bisect bad 122228e8fa47941375b9fcb3b5c41ee4945880cb # first bad commit: [122228e8fa47941375b9fcb3b5c41ee4945880cb] source 7c0f6b9d0fb8d7d9e54865ccf1047bb8f8148101
The first time the crash happens on undo started with the commit referenced below. Adding Cc: to Dennis Francis (author), also adding Cc: to Eike Rathke (committer). Please take a look. https://cgit.freedesktop.org/libreoffice/core/commit/?id=7c0f6b9d0fb8d7d9e54865ccf1047bb8f8148101 author Dennis Francis <dennisfrancis.in@gmail.com> 2016-02-12 20:59:12 (GMT) committer Eike Rathke <erack@redhat.com> 2016-03-08 18:06:09 (GMT) "tdf#94561 : Create notes drawing objects only once on sheet copy" Note that before that commit there's already a crash on exit. If it is still there after this is fixed, that bug has to be bibisected separately.
Created attachment 130914 [details] Valgrind trace On pc Debian x86-64 with master sources updated today, I could reproduce this. I attached a Valgrind trace.
Investigating.
Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a627c44026fcf883918f84bddd1c3b745e1f898c Resolves: tdf#105667 forget target area's caption pointer in Merge Undo It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Pending review https://gerrit.libreoffice.org/34384 for 5-3 https://gerrit.libreoffice.org/34385 for 5-2 https://gerrit.libreoffice.org/34386 for 5-2-6
Great.
Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=45fd903d5ed6007271485ce3fa7c2e78bdc286f8 unit test for cell merge with note caption undo, tdf#105667 It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4ecdb497d540e69590476919f4cb1d02a8025c2e&h=libreoffice-5-3 Resolves: tdf#105667 forget target area's caption pointer in Merge Undo It will be available in 5.3.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-5-2-6": http://cgit.freedesktop.org/libreoffice/core/commit/?id=06a3f692dc853f1762927370dcc34bc50273273d&h=libreoffice-5-2-6 Resolves: tdf#105667 forget target area's caption pointer in Merge Undo It will be available in 5.2.6. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-5-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0eda0807f9b0ba81035cf4bd630e50a27ba2678b&h=libreoffice-5-2 Resolves: tdf#105667 forget target area's caption pointer in Merge Undo It will be available in 5.2.7. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-5-3-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=19bbc07e67d1a6b5c25a858a18994ee36770e79a&h=libreoffice-5-3-1 Resolves: tdf#105667 forget target area's caption pointer in Merge Undo It will be available in 5.3.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.