Created attachment 131703 [details] Sample test case Steps to reproduce: 1. Create new document and insert a new (1x2) table. 2. Enter content so that the cell in the second row goes across the border. 3. Uncheck "Allow row breaks across pages and columns" and "Allow table split across pages and columns". The sample is attached. Expected result: The contents inside the table and the table border will be cut before footer. Actual result: The border go across the border, even the area of the page. It looks somewhat broken. 版本:5.3.0.3 組建 ID:7074905676c47b82bbcfbea1aeefc84afe1c50e1 CPU 執行緒:8; OS 版本:Windows 6.2; UI 算繪:預設; 介面配置引擎:新式; 語言地區:zh-TW (zh_TW); Calc: single
it seems like a duplicate of bug 106384, and I recall the same problem reported previously but I can't find it... *** This bug has been marked as a duplicate of bug 106384 ***
Created attachment 131736 [details] Illustration about the issue. Unlike tdf#106384, neither "Allow table split across pages and columns" and "Allow row break across pages and columns" are checked, so data hidden is expected. But border extrusion isn't.
# bad: [74b89c3193673ba9897dc4a4541500ef6e8d9bf7] source-hash-8f97326bdd3f42fc82aa5e1989fd03b0af1daf64 # good: [9c392cfdfe6e9a9bce98555ea989283a957aa3ad] source-hash-fc8f44e82de4ebdd50ac5fbb9207cd1a59a927e3 git bisect start 'latest' 'oldest' # good: [e289d9d328719fd70e9a2680fd0e4f586a97b3be] source-hash-3c0a7cf4f67720f2cca2c4eb543f838d5b644e7f git bisect good e289d9d328719fd70e9a2680fd0e4f586a97b3be # bad: [3e807472869ed7d72b026c12cd1e7c3cb990591f] source-hash-6390dd9777ff63ca75a088e56dd444a355439343 git bisect bad 3e807472869ed7d72b026c12cd1e7c3cb990591f # good: [c57068b5699ab30f5721cd6a43f146c3d08d98e6] source-hash-549c3b81190d64ec23254f448ebf69520dd76da9 git bisect good c57068b5699ab30f5721cd6a43f146c3d08d98e6 # skip: [87b5a5db1a6dc620385931ebf50ad071179a94c8] source-hash-c62d31f791d7e09fdca5dd185603c78b47f19597 git bisect skip 87b5a5db1a6dc620385931ebf50ad071179a94c8 # skip: [2b5ab07da9e9748459866fd88eef213013279793] source-hash-8e4560e709fb565c69f1950387a812e543d98e22 git bisect skip 2b5ab07da9e9748459866fd88eef213013279793 # bad: [3aaa8302f5cc49a157ca86c10fbe396ab0904cfb] source-hash-92ad689bcb3ad16bd35302e6ff4ee45b872c05a0 git bisect bad 3aaa8302f5cc49a157ca86c10fbe396ab0904cfb # bad: [102ec5b368aef8bb799d535be1abb0f53ca9d70f] source-hash-359a7d4b7fe3ea2c8f18d1f2b4a17c60ac42ae1d git bisect bad 102ec5b368aef8bb799d535be1abb0f53ca9d70f # skip: [7396dcc118996bbc202432afe6298ff4141bdd8a] source-hash-5caeb976d56f9df2cffbf98fa0bc0c552c60e1f6 git bisect skip 7396dcc118996bbc202432afe6298ff4141bdd8a # skip: [be2fb3aa75f10e2bcf114c7a38f27abc29e5686a] source-hash-5b3c93141253e224a8beaae415c88b6378c9919e git bisect skip be2fb3aa75f10e2bcf114c7a38f27abc29e5686a # bad: [7b4694551ed162aa81fd02d1e8b53cecdf0e3ad5] source-hash-db5407b6ac9afa18b61fd8ba55a7096e5b1311f0 git bisect bad 7b4694551ed162aa81fd02d1e8b53cecdf0e3ad5 # bad: [2e2e4130ddc1ce4c58d8f7a69e67354ca3e87f36] source-hash-75122338eba5515786198b734d43577d727e3c67 git bisect bad 2e2e4130ddc1ce4c58d8f7a69e67354ca3e87f36 # bad: [988f74f4cba715460b3cefa912c42ca5186a3fb2] source-hash-28b880d4074fc105ed4bc01e4bbe3866cad047cb git bisect bad 988f74f4cba715460b3cefa912c42ca5186a3fb2 # skip: [a8e408f4067459b3c37e4ba2780e6b02a09c4fa2] source-hash-15bb864ea81b64ecfdd69e8831fb729ca44a542e git bisect skip a8e408f4067459b3c37e4ba2780e6b02a09c4fa2 # skip: [af355ced27ed6b2f2221a8a3595ad0654aced965] source-hash-17c17017458519e2c13c43fb362320a127c65135 git bisect skip af355ced27ed6b2f2221a8a3595ad0654aced965 # skip: [328fea70c54504e4f4c2a5724599b17ef9e106c6] source-hash-83408619a7f8ba6ba61e05e495d0520d8e8e1947 git bisect skip 328fea70c54504e4f4c2a5724599b17ef9e106c6 # bad: [8fe95bfcc016777d6425f78f4f8da9c73a9cf535] source-hash-c2fb42afb304c5ce1e5b1686df0000f87d5ae80c git bisect bad 8fe95bfcc016777d6425f78f4f8da9c73a9cf535 # bad: [2d5c562571e749d54a4f5bb4c30484d535b89437] source-hash-65b718dad248a595f63910386127f70eaa8b8b6c git bisect bad 2d5c562571e749d54a4f5bb4c30484d535b89437 # skip: [9d2a02c139a230dfc9cd3b349fa486cd28822db7] source-hash-a98d7543ad599092081970c48c0c650c142cf762 git bisect skip 9d2a02c139a230dfc9cd3b349fa486cd28822db7 # good: [32407c23028a9f40a5707d6d2efac11636b11043] source-hash-4eb0625d010a65146f727f1ff05c31994d4e12cb git bisect good 32407c23028a9f40a5707d6d2efac11636b11043 # good: [f8921666e3787adb280bc160a4136e6458a34914] source-hash-ca25cdcb398f200ce5d53286eea02d49d8d1c5f4 git bisect good f8921666e3787adb280bc160a4136e6458a34914 # bad: [3cb352046238fe6ef37e59b1d37f303e938d4dea] source-hash-bb17844099ba98a77c8e5d7a25c0c416a4b0641e git bisect bad 3cb352046238fe6ef37e59b1d37f303e938d4dea # bad: [8b0a2e8a9e10ad2e4968618b4c449934000c54fa] source-hash-d2eb2c5a02718b83475bc718e117eb6255cbac98 git bisect bad 8b0a2e8a9e10ad2e4968618b4c449934000c54fa # good: [846d785bf4dda740db6a3ca22c2ef36530286370] source-hash-374efa7253703b054e4603c66aeba862e4e98574 git bisect good 846d785bf4dda740db6a3ca22c2ef36530286370 # bad: [bde03e88148690ca7d28f65877cd0830d4991629] source-hash-1c6fb266567c8e397e3c65663b21f0fa50696aa5 git bisect bad bde03e88148690ca7d28f65877cd0830d4991629 # first bad commit: [bde03e88148690ca7d28f65877cd0830d4991629] source-hash-1c6fb266567c8e397e3c65663b21f0fa50696aa5
Bisect points to the commit referenced below. https://cgit.freedesktop.org/libreoffice/core/commit/?id=1c6fb266567c8e397e3c65663b21f0fa50696aa50 is the first bad commit commit bde03e88148690ca7d28f65877cd0830d4991629 Author: Matthew Francis <mjay.francis@gmail.com> Date: Thu May 28 20:09:10 2015 +0800 source-hash-1c6fb266567c8e397e3c65663b21f0fa50696aa5 commit 1c6fb266567c8e397e3c65663b21f0fa50696aa5 Author: Kohei Yoshida <kohei.yoshida@collabora.com> AuthorDate: Mon Mar 17 19:11:35 2014 -0400 Commit: Kohei Yoshida <kohei.yoshida@collabora.com> CommitDate: Mon Mar 17 19:43:05 2014 -0400 fdo#75260: These old hacks no longer make sense. The clip region in fact cuts off the lower part of the bottom border, both on screen and when printing / exporting to PDF. Change-Id: Id350531f09b3ded66fd05ea7ebeefe8771260b62
Mark Hung committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=b13a0a27444ffbf9ef45cb16ad69fdff0dc64306 tdf#106390 improve table in table and table in frame clipping. It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Mark, https://cgit.freedesktop.org/libreoffice/core/commit/?id=b13a0a27444ffbf9ef45cb16ad69fdff0dc64306 breaks tables that have split and merged cells. For example, the merged cell in attachment 114436 [details] is not rendered correctly after your patch. Should I file a new report or do you want to track that here?
Hi Luke, There is still another part of the patch on the way under review. I suggest to create another issue ( in case the test case is different. ).
Mark Hung committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e87cc12eaf53efa9b221eae7167ea15bc7896752 tdf#106390 Intersect the table borders with upper frames. It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
https://cgit.freedesktop.org/libreoffice/core/commit/?id=e87cc12e is causing a regression with how tables are rendered. Reported as Bug 117884
A polite ping to Mark Hung: Is this bug fixed? if so, could you please close it as RESOLVED FIXED ? Otherwise, Could you please explain what's missing? Thanks
(In reply to Xisco Faulí from comment #10) > A polite ping to Mark Hung: > Is this bug fixed? if so, could you please close it as RESOLVED FIXED ? > Otherwise, Could you please explain what's missing? > Thanks Ping ?
I forgot when does this fixed, but it works for me in 6.2.0.