Description: The nice new buttons in the Paste Special dialog in Calc are great, but they have not keyboard binding of any kind. I note that LibreOffice is boasting 'full keyboard navigation and control' (which I completely support), but this is apparently a gap. https://www.libreoffice.org/get-help/accessibility/ (Note that there are numerous menu shortcuts in Calc that also don't have keyboard accelerators, ie like Alt+F+O in Ubuntu 16.04 with Unity. I won't list those here now though) Steps to Reproduce: Type Alt-E-S to paste special. Click '$0' button with the mouse. Ouch! I wanted to use the keyboard, but I can't see how to do that except with the keybaord. Actual Results: Reach for the mouse Expected Results: Some way should exist to allow me to stay on the keyboard if I wish to. Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0
This works correctly for me on Windows 10 Pro 64-bit en-US. Either the <Ctrl>+<Shift>+v shortcut, or the <Alt>, <E>dit, <S>pecial accelerator sequence (or as localized) launches the Paste Special dialog. Keyboard selection in the dialog for format. Enter to complete the paste. Something missing? Linux only? Ubuntu/Unity only? =-=-= Version: 5.4.0.0.alpha0+ Build ID: 522e9c65faef684a22151ddf009a5a192838b522 CPU threads: 8; OS: Windows 6.19; UI render: GL; TinderBox: Win-x86@42, Branch:master, Time: 2017-03-24_00:32:45 Locale: en-US (en_US); Calc: CL
Created attachment 132290 [details] Paste special with GTK3 (and Breeze icon set) For clarification, as I understand it is about the paste special dialog you get if you paste cell values. I can navigate using Tab/Shift-Tab in the dialog just fine. However, with GTK3 backend it is impossible/very hard to see where I'm at: -for the buttons there's a very thin orange outline if they're selected, -for the checkboxes/radio buttons there's no indication at all. I guess that confirms there is an issue, but not exactly what is reported. John, can you confirm/clarify? Version: 5.4.0.0.alpha0+ Build ID: e604ddfd1196c877ddce603dca15f9a5228497e0 CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); Calc: group
OK, so with copy/cut of cell value the Paste Special dialog in Calc changes. It behaves the same on Windows and offers the additional options including the row of buttons with "Values Only", "Values & Formulas" and "Transpose" And all the buttons on the dialog can be reached via keyboard--<Tab> and <Shift>+<Tab> in Windows OS. The keyboard button focus in this OS includes the thin outline--but more obvious blue highlight on mouse-over. Lack of accelerators/short-cut for the buttons is annoying (and inconsistent with the other check box widgets) but does not prevent keyboard navigation as suggested. "Implementation Error" OR "Enhancement"?
My 2c - I'd say this is an implentation issue. Consistency in things like buttons is pretty important, I'm not sure I'd consider this an enhancement given it's something we should just do!
There now seems to be two things mangled in here together. The initial bug which is that the buttons at the top of the Paste Special dialog don't have any visible keyboard shortcuts. Then there's an additional complaint that its difficult to see which widget has keyboard focus under a theme, presumably Ubuntu's default theme, under GTK3 and has make this a blocker on the GTK3 metabug. I'm going to remove this from the GTK3 metabug, because that's more of an aside than the main initially reported problem. If the GTK3 connection is because the GTK3 theme's focus rectangle is not sufficiently indicative of what element has focus then either the theme is at fault or our use of the theme is bad, a comparison against a native button with an image only on that theme would identify the blame there, and a new bug about that if necessary with the details of the gtk3 version and theme.
Having to tab through options in a dialog box does not count as keyboard accessibility IMHO (especially when the GTK theme makes it difficult to clearly see which button in highlighted). These buttons need a shortcut character which should appear on the button when the user presses the 'ALT' key, as is normal for all (normal) dialogs.
My suggestion: * modify the dialog so that the 'values only' and 'values and formats' buttons are accompanied by text labels with the 'V' and 'O' shortcuts. * remove the 'Transpose' button; there is already a 'transpose' checkbox, and this is an occasional-use operation, I suspect. This makes space for the larger required buttons with text labels Example of button with image + label: https://developer.gnome.org/gtk3/stable/GtkLockButton.html I believe this problem, would also help usability, as the meaning of those icons in the new dialog is not very intuitive -- most users would need to mouse over them to see the label anyway, in order to be sure they understood the meaning of them.
PS the shortcut for the 'divide' operation in the dialog would also need to be removed/changed.
*** Bug 120032 has been marked as a duplicate of this bug. ***
This issue is still present, although there are now additional options in the Edit->Paste Special sub-menu, making it easier to quickly paste values (Alt-E-S-V), but making it harder to get the more complete set of options (Alt-E-S no longer presents the dialog). There are still no key-bindings on the graphical buttons at the top of the Paste Special dialog. Version: 6.2.6.2 Build ID: 1:6.2.6-0ubuntu0.18.04.1~lo1 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: en-AU (en_AU.UTF-8); UI-Language: en-US Calc: threaded
(In reply to john from comment #10) > (Alt-E-S no longer presents the dialog). There are still no key-bindings on > the graphical buttons at the top of the Paste Special dialog. > At 6.3.1.2 on Windows builds, the Paste Special reuses the 'S': So keyboard accelerators of <Alt>+E+S+S open the 'Paste Special' dialog with focus control on the list box. => WFM
Comment 11 is not correct. To see the problematic behaviour, you have to first select a range of cells in Calc. Then you will see the problematic dialog box, for which there is NO selection list, and no keybinding to paste values. This new Paste Special dialog/menu is a complete hodgepodge. Compare with the simplicity of this dialog: https://is.gd/cFnOKG Ctrl-V -- default paste behaviour Alt-E-S -- paste special behaviour Just one more Alt-XXX keystroke to select which special paste you want, all of them are visually discoverable, only one path to each option, no multiple paths. The current solution needlessly breaks the Alt-E-S keystroke, and unnecessarily provides multiple paths to achieving the same results. PS "paste numbers" is not the same as "paste values".
Created attachment 154712 [details] PasteSpecial dialog on Windows builds at 6.3.2, accelerators assigned (In reply to john from comment #12) > Comment 11 is not correct. To see the problematic behaviour, you have to > first select a range of cells in Calc. Then you will see the problematic > dialog box, for which there is NO selection list, and no keybinding to paste > values. > > This new Paste Special dialog/menu is a complete hodgepodge. Compare with > the simplicity of this dialog: > https://is.gd/cFnOKG > Current 6.3.2 release PasteSpecial dialog. Not seeing your issue. Launch'd by shortcut with <Ctr><Shift>+V Or alternatively via Main menu Accelerators <Alt>+E,S,S Dialog is fully populated with accelerators. Just the 3 action buttons "Values only", "Values & Formulas", "Transpose" have no accelerators in the GUI. But they are eye candy for pointer or touch use. => WFM
@V Stuart Foote I see no reason why the "values only" and "values and formats" options, which deserve a (needlessly graphical) button for some reason don't get a keyboard accelerator. Those options are common, typical things that we need. Why can't they also be easy to use with the keyboard? Still a bug!
I don't have it installed right now, but I think Ctrl+Alt+Shift+V was added months ago as a shortcut for paste values.
This was fixed with the new design added in bug #134802 *** This bug has been marked as a duplicate of bug 134802 ***
Gabor Kelemen committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b07fa5671de64fda47c2ad1a40814f56e07ddcaf tdf#106852 (related) Remove stray manual button label It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.