Description: On pc Debian x86-64 with master sources updated yesterday, here are some Tango icons missing: cmd/lc_setoutline.png cmd/sc_orientation.png (noticed with console message like: warn:legacy.osl:5250:1:framework/source/uiconfiguration/ImageArrayData.cxx:85: ImageAryData::Load: failed to load image 'cmd/lc_setoutline.png' from icon theme 'tango') Steps to Reproduce: I don't remember how to reproduce this, sorry. Actual Results: Console logs indicating missing icons Expected Results: None of these logs Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
Just noticed these too: warn:fwk.uiconfiguration:5533:1:framework/source/uiconfiguration/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_wordcountdialog.png' from icon theme 'tango' warn:fwk.uiconfiguration:5533:1:framework/source/uiconfiguration/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_bibliographycomponent.png' from icon theme 'tango'
Provided {l,s}c_bibliographycomponent.png and sc_orientation.png with patch e2e03ffc2637c9faea8a78f04232644e66ad60c4. Others still pending…
I noticed a new missing icon today: warn:fwk.uiconfiguration:18961:1:framework/source/uiconfiguration/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_editstyle.png' from icon theme 'tango'
warn:fwk.uiconfiguration:1774:1:framework/source/uiconfiguration/ImageArrayData.cxx:74: Failed to load image 'cmd/lc_rotate180.png' from icon theme 'tango' warn:fwk.uiconfiguration:1774:1:framework/source/uiconfiguration/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_mergedocuments.png' from icon theme 'tango'
I noticed lots of missing icons when trying to customize toolbar: cmd/sc_insertframemenu.png cmd/sc_formatimagemenu.png cmd/sc_formatframemenu.png cmd/sc_toolsmacroedit.png cmd/sc_shapeslinemenu.png cmd/sc_splithorizontal.png cmd/sc_splitvertical.png cmd/sc_changepicture.png cmd/sc_compressgraphic.png cmd/sc_filedocument.png cmd/sc_editframeset.png cmd/sc_splitparenthorizontal.png cmd/sc_mergedocuments.png cmd/sc_insertfootnotesmenu.png cmd/sc_newwindow.png cmd/sc_movingaveragedialog.png cmd/sc_formattextmenu.png cmd/sc_formatformmenu.png cmd/sc_covariancedialog.png cmd/sc_acceptchanges.png cmd/sc_regressiondialog.png cmd/sc_tracechangemode.png cmd/sc_commentchange.png cmd/sc_focustofindbar.png cmd/sc_analysisofvariancedialog.png cmd/sc_ztestdialog.png cmd/sc_freezecellsmenu.png cmd/sc_freezepanesfirstrow.png cmd/sc_correlationdialog.png cmd/sc_splitparentvertical.png cmd/sc_numberformatmenu.png cmd/sc_exponentialsmoothingdialog.png cmd/sc_sheetinsertname.png cmd/sc_shapesmenu.png cmd/sc_freezepanesfirstcolumn.png cmd/sc_descriptivestatisticsdialog.png cmd/sc_helpmenu.png cmd/sc_chisquaretestdialog.png cmd/sc_showchanges.png cmd/sc_ftestdialog.png cmd/sc_samplingdialog.png cmd/sc_ttestdialog.png cmd/sc_convertformulatovalue.png cmd/sc_insertpivottable.png cmd/sc_formatspacingmenu.png cmd/sc_formatbulletsmenu.png cmd/sc_formatstylesmenu.png cmd/sc_signature.png cmd/sc_editstyle.png
(In reply to Julien Nabet from comment #0) > (noticed with console message like: > warn:legacy.osl:5250:1:framework/source/uiconfiguration/ImageArrayData.cxx: > 85: ImageAryData::Load: failed to load image 'cmd/lc_setoutline.png' from > icon theme 'tango') this is currently done, but sc_setoutline.png isnt. (In reply to Julien Nabet from comment #5) > I noticed lots of missing icons when trying to customize toolbar: where did you get this list? > cmd/sc_insertframemenu.png > cmd/sc_formatimagemenu.png > cmd/sc_formatframemenu.png menu submenus like these dont have icons in any theme so not sure about this > cmd/sc_helpmenu.png icons cant appear in the menu bar so not sure why this is in the list. > cmd/sc_editstyle.png i'll upload this, as i uploaded the lc_ version recently for the styles toolbar. https://gerrit.libreoffice.org/43087
(In reply to Yousuf Philips (jay) from comment #6) > ... > > I noticed lots of missing icons when trying to customize toolbar: > > where did you get this list? > > > cmd/sc_insertframemenu.png > > cmd/sc_formatimagemenu.png > > cmd/sc_formatframemenu.png >... I'm not sure but I think it's when playing with customize menus. I just tested again and had only this: warn:fwk.uiconfiguration:1828:1828:framework/source/uiconfiguration/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_mergedocuments.png' from icon theme 'tango' warn:fwk.uiconfiguration:1828:1828:framework/source/uiconfiguration/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_mergedocuments.png' from icon theme 'tango' but lots of this one: warn:legacy.osl:1828:1828:sfx2/source/control/msgpool.cxx:208: GroupId-Name not defined in SFX!
(In reply to Yousuf Philips (jay) from comment #6) > > cmd/sc_insertframemenu.png > > cmd/sc_formatimagemenu.png > > cmd/sc_formatframemenu.png > > menu submenus like these dont have icons in any theme so not sure about this This "Failed to load image" warning is caused by the "Properties" section of these commands in GenericCommands.xcu. They all have there the value "1", which indicates that they should have an icon, see [1]. If these commands aren't supposed to have any icons, then just removing this "Properties" section should silence the warning IIRC. > > cmd/sc_helpmenu.png > > icons cant appear in the menu bar so not sure why this is in the list. This caused by the presence of .uno:HelpMenu in the available commands list of the customization dialog, although it's useless, as it isn't a command that can do anything other than show the "Help" label. This is caused by the backing SID_HELPMENU definition in [2], which have MenuConfig = TRUE. So what we need here is: 1) Same as above wrt. the "Properties" section in GenericCommands.xcu. 2) Find any occurrence of SID_HELPMENU in the codebase and simply remove it. [1] https://opengrok.libreoffice.org/xref/core/officecfg/registry/schema/org/openoffice/Office/UI/Commands.xcs#59 [2] https://opengrok.libreoffice.org/xref/core/sfx2/sdi/sfx.sdi#1837
(In reply to Maxim Monastirsky from comment #8) > 1) Same as above wrt. the "Properties" section in GenericCommands.xcu. Will look over these and see which ones in the menus deserve to have icons and will add links to them in links.txt, and remove the ones that dont. > 2) Find any occurrence of SID_HELPMENU in the codebase and simply remove it. Here are the occurences https://opengrok.libreoffice.org/search?project=core&q=SID_HELPMENU&defs=&refs=&path=&hist=&type=
First round of fixes. https://gerrit.libreoffice.org/#/c/43152/
Yousuf Philips committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4fd81a26681063dcc0d8d2eae795d39c8d894cb8 tdf#107569 Add small edit style icon It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Maxim Monastirsky committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ecc3d43d2feb4ec09a3f797a4eb6d2eb25e5ee7f Related: tdf#107569 Remove useless slots It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Yousuf Philips committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=dc2d133e7953f08f73ef9cd0b40786764b0e2035 tdf#107569 Tango: Fix missing icons in menu bar It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
When hoovering over the menu items in Writer I still get these /ImageArrayData.cxx:74: Failed to load image 'cmd/sc_recentfilelist.png' from icon theme 'tango' /ImageArrayData.cxx:74: Failed to load image 'cmd/sc_focustofindbar.png' from icon theme 'tango' /ImageArrayData.cxx:74: Failed to load image 'cmd/sc_pagedialog.png' from icon theme 'tango' /ImageArrayData.cxx:74: Failed to load image 'cmd/sc_watermark.png' from icon theme 'tango' /ImageArrayData.cxx:74: Failed to load image 'cmd/sc_rotate180.png' from icon theme 'tango' /ImageArrayData.cxx:74: Failed to load image 'cmd/sc_rotatereset.png' from icon theme 'tango' /ImageArrayData.cxx:74: Failed to load image 'cmd/sc_newwindow.png' from icon theme 'tango' /ImageArrayData.cxx:74: Failed to load image 'cmd/sc_wordcountdialog.png' from icon theme 'tango' Version: 6.0.0.0.alpha1+ Build ID: 380d6afe5fd691f6ad4b17fc38b79b9fca4ba906 CPU threads: 4; OS: Windows 6.3; UI render: default; TinderBox: Win-x86@39, Branch:master, Time: 2017-10-22_09:58:27 Locale: nl-NL (nl_NL); Calc: CL
@Maxim: We need to have a means of setting that an icon does not appear in the menu, even if it is to be displayed in the toolbar, sidebar and notebookbar. (In reply to Telesto from comment #14) > When hoovering over the menu items in Writer I still get these > /ImageArrayData.cxx:74: Failed to load image 'cmd/sc_recentfilelist.png' > from icon theme 'tango' Andreas set this so it appears in the notebookbar and preferable it shouldnt display in the menu > /ImageArrayData.cxx:74: Failed to load image 'cmd/sc_focustofindbar.png' > from icon theme 'tango' the menu entry is vnd.sun.star.findbar:FocusToFindbar and this should be turned off from looking for an icon, as you cant add it to the toolbar and find & replace already has an icon > /ImageArrayData.cxx:74: Failed to load image 'cmd/sc_pagedialog.png' from > icon theme 'tango' only available in breeze > /ImageArrayData.cxx:74: Failed to load image 'cmd/sc_watermark.png' from > icon theme 'tango' > /ImageArrayData.cxx:74: Failed to load image 'cmd/sc_rotate180.png' from > icon theme 'tango' > /ImageArrayData.cxx:74: Failed to load image 'cmd/sc_rotatereset.png' from > icon theme 'tango' removed > /ImageArrayData.cxx:74: Failed to load image 'cmd/sc_newwindow.png' from > icon theme 'tango' only available in breeze > /ImageArrayData.cxx:74: Failed to load image 'cmd/sc_wordcountdialog.png' > from icon theme 'tango' removed Patch - https://gerrit.libreoffice.org/43729
(In reply to Yousuf Philips (jay) from comment #15) > @Maxim: We need to have a means of setting that an icon does not appear in > the menu, even if it is to be displayed in the toolbar, sidebar and > notebookbar. Bug 98058, I'll add a comment there. > the menu entry is vnd.sun.star.findbar:FocusToFindbar and this should be > turned off from looking for an icon, as you cant add it to the toolbar What do you mean by that? Did you add it to the toolbar xml and it didn't work there?
Argh, I missed a few: warn:fwk.uiconfiguration:4832:4836:framework/source/uiconfiguration/ImageArrayta.cxx:74: Failed to load image 'cmd/lc_jumptospecificpage.png' from icon them'tango' warn:fwk.uiconfiguration:4832:4836:framework/source/uiconfiguration/ImageArrayta.cxx:74: Failed to load image 'cmd/sc_signature.png' from icon theme 'tango' warn:fwk.uiconfiguration:4832:4836:framework/source/uiconfiguration/ImageArrayta.cxx:74: Failed to load image 'cmd/sc_signpdf.png' from icon theme 'tango' warn:fwk.uiconfiguration:4384:4916:framework/source/uiconfiguration/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_mergedocuments.png' from icon theme 'tango' warn:fwk.uiconfiguration:4384:4916:framework/source/uiconfiguration/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_updateall.png' from icon theme 'tango' warn:fwk.uiconfiguration:4384:4916:framework/source/uiconfiguration/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_changepicture.png' from icon theme 'tango' warn:fwk.uiconfiguration:4832:4836:framework/source/uiconfigurati on/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_compressgraphic.png' from icon theme 'tango' in Version: 6.0.0.0.alpha1+ Build ID: 380d6afe5fd691f6ad4b17fc38b79b9fca4ba906 CPU threads: 4; OS: Windows 6.3; UI render: default; TinderBox: Win-x86@39, Branch:master, Time: 2017-10-22_09:58:27 Locale: nl-NL (nl_NL); Calc: CL
(In reply to Maxim Monastirsky from comment #16) > Bug 98058, I'll add a comment there. Thanks. > What do you mean by that? Did you add it to the toolbar xml and it didn't > work there? I meant that as it isnt an uno command, you cant add it to the toolbar through the customization dialog (bug 80914). I havent tried adding it to the toolbar xml, as I assume it wouldnt work, and as there wasnt a need to. (In reply to Telesto from comment #17) > Argh, I missed a few: > warn:fwk.uiconfiguration:4832:4836:framework/source/uiconfiguration/ > ImageArrayta.cxx:74: Failed to load image 'cmd/lc_jumptospecificpage.png' > from icon them'tango' fixed > warn:fwk.uiconfiguration:4832:4836:framework/source/uiconfiguration/ > ImageArrayta.cxx:74: Failed to load image 'cmd/sc_signature.png' from icon > theme 'tango' > warn:fwk.uiconfiguration:4832:4836:framework/source/uiconfiguration/ > ImageArrayta.cxx:74: Failed to load image 'cmd/sc_signpdf.png' from icon > theme 'tango' > warn:fwk.uiconfiguration:4384:4916:framework/source/uiconfiguration/ > ImageArrayData.cxx:74: Failed to load image 'cmd/sc_mergedocuments.png' from > icon theme 'tango' icon is in breeze, hasnt been created in tango > warn:fwk.uiconfiguration:4384:4916:framework/source/uiconfiguration/ > ImageArrayData.cxx:74: Failed to load image 'cmd/sc_updateall.png' from icon > theme 'tango' > warn:fwk.uiconfiguration:4384:4916:framework/source/uiconfiguration/ > ImageArrayData.cxx:74: Failed to load image 'cmd/sc_changepicture.png' from > icon theme 'tango' > warn:fwk.uiconfiguration:4832:4836:framework/source/uiconfigurati > on/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_compressgraphic.png' > from icon theme 'tango' fixed Patch - https://gerrit.libreoffice.org/43785
Another one. Highlight color -> custom color warn:vcl:2744:1544:vcl/source/gdi/bitmapex.cxx:111: BitmapEx::BitmapEx(): could not load image res/colorslider.png via icon theme tango warn:vcl:2744:1544:vcl/source/gdi/bmpacc.cxx:52: Forbidden Access to empty bitmap!
I should have been more systematic.. Didn't check Impress warn:fwk.uiconfiguration:5064:2684:framework/source/uiconfiguration/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_remote.png' from icon theme 'tango' warn:fwk.uiconfiguration:5064:2684:framework/source/uiconfiguration/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_importslidefromfile.png' from icon theme 'tango' warn:fwk.uiconfiguration:5064:2684:framework/source/uiconfiguration/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_slidechangewindow.png' from icon theme 'tango' warn:fwk.uiconfiguration:5064:2684:framework/source/uiconfiguration/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_normalmultipanegui.png' from icon theme 'tango' warn:fwk.uiconfiguration:5064:2684:framework/source/uiconfiguration/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_outlinemode.png' from icon theme 'tango' warn:fwk.uiconfiguration:5064:2684:framework/source/uiconfiguration/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_notesmode.png' from icon theme 'tango' warn:fwk.uiconfiguration:5064:2684:framework/source/uiconfiguration/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_diamode.png' from icon theme 'tango' warn:fwk.uiconfiguration:5064:2684:framework/source/uiconfiguration/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_notesmasterpage.png' from icon theme 'tango' warn:fwk.uiconfiguration:5064:2684:framework/source/uiconfiguration/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_handoutmode.png' from icon theme 'tango' warn:fwk.uiconfiguration:5064:2684:framework/source/uiconfiguration/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_slidechangewindow.png' from icon theme 'tango' warn:fwk.uiconfiguration:5064:2684:framework/source/uiconfiguration/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_photoalbumdialog.png' from icon theme 'tango' warn:fwk.uiconfiguration:2952:4108:framework/source/uiconfiguration/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_ruler.png' from icon theme 'tango' warn:fwk.uiconfiguration:2952:4108:framework/source/uiconfiguration/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_insertanchor.png' from icon theme 'tango'
(In reply to Telesto from comment #19) > warn:vcl:2744:1544:vcl/source/gdi/bitmapex.cxx:111: BitmapEx::BitmapEx(): > could not load image res/colorslider.png via icon theme tango > warn:vcl:2744:1544:vcl/source/gdi/bmpacc.cxx:52: Forbidden Access to empty > bitmap! No idea about this as the icon is there. https://cgit.freedesktop.org/libreoffice/core/tree/icon-themes/tango/res/colorslider.png Its been requested here https://opengrok.libreoffice.org/xref/core/cui/source/dialogs/colorpicker.cxx#909
(In reply to Yousuf Philips (jay) from comment #21) > No idea about this as the icon is there. > > https://cgit.freedesktop.org/libreoffice/core/tree/icon-themes/tango/res/ > colorslider.png That icon was not packaged into images_tango.zip, fix is here: https://gerrit.libreoffice.org/43796/
Maxim Monastirsky committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=48e64ea4a8201a43457e46422a07f14f697eb91e tdf#107569 Fix missing res/colorslider.png It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Yousuf Philips committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c566b78de541645d81463b460d3332da5878020f tdf#107569 Tango: Fix missing icons in Writer menu bar It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Yousuf Philips committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=51e2dc5139e0c34672eb433421cbe89e7854e6dd tdf#107569 Tango: Fix missing icons in Writer menu bar (part 2) It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
A polite ping to Yousuf Philips: is this bug fixed? if so, could you please close it as RESOLVED FIXED ? Thanks
(In reply to Xisco Faulí from comment #26) > A polite ping to Yousuf Philips: is this bug fixed? if so, could you > please close it as RESOLVED FIXED ? Thanks Additional work is needed to fix all the problems, but i'll leave it up to others to do so.
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
As tango is unmaintained and since the last update of tango there are a lot of new icons added, I think this bug can be closed and if someone will do tango work in the future the work can start with check the difference to other icon themes.