Created attachment 133246 [details] sample Steps to reproduce: 1. Open attached document Citation displays [CITATION Moz17 \l 1033] instead of (Mozilla, 1998-2017) Reproduced in Version: 5.3.3.2 Build ID: 1:5.3.3~rc2-0ubuntu0.16.10.1~lo0 CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; Layout Engine: new; Locale: es-ES (ca_ES.UTF-8); Calc: group
Regression introduced by: author Rohit Deshmukh <rohit.deshmukh@synerzip.com> 2014-03-12 09:37:38 (GMT) committer Miklos Vajna <vmiklos@collabora.co.uk> 2014-03-14 09:45:33 (GMT) commit 06f7d1a96eef5aa69d4872ff6d96eb5085296d09 (patch) tree 7b155faff164f15c78492b46a9c5586d05195e96 parent 7545a9054cd8fbca0073b4603b833080b4810a94 (diff) fdo#74775: Preseved Citation after round trip. Bisected with bibisect-43max.
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
*** Bug 127672 has been marked as a duplicate of this bug. ***
Hi Justin, I thought you might be interested in this issue...
*** Bug 94913 has been marked as a duplicate of this bug. ***
@Tamás, I thought you might also be interested in this issue...
I believe the problem is in https://opengrok.libreoffice.org/xref/core/sw/source/core/fields/fldbas.cxx?r=ebdf70cc#412 where it calls https://opengrok.libreoffice.org/xref/core/sw/source/core/fields/authfld.cxx?r=3c6cb83b#487, thus we use AUTH_FIELD_IDENTIFIER instead of AUTH_FIELD_TITLE, which is the right value for citations... I might take a deeper look at it if I find some time...
Instead we should call https://opengrok.libreoffice.org/xref/core/sw/source/core/fields/authfld.cxx?r=3c6cb83b#515
I feel brave enough to take a look at it :D
Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/417d993b8b8a86c019758ee0850e4b42967e2afa tdf#107784: DOCX Import: Show citation's title in fields It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Xisco Fauli committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/commit/fadce0c9a7ccbd7222df90e41d8fc16d9d67045f tdf#107784: DOCX Import: Show citation's title in fields It will be available in 6.3.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Xisco Faulí committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/commit/1d6429fb86d0ba8c03da8621512f3b675d1bcb81 Revert "tdf#107784: DOCX Import: Show citation's title in fields" It will be available in 6.3.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I'm going to revert the fix -> https://gerrit.libreoffice.org/#/c/79472/ I've realized it's too aggressive and it affects bibliography citations in general. I'll try to find another solution, for instance: --- a/sw/source/core/text/txtfld.cxx +++ b/sw/source/core/text/txtfld.cxx @@ -51,6 +51,7 @@ #include <fmtmeta.hxx> #include <reffld.hxx> #include <flddat.hxx> +#include <authfld.hxx> #include <IDocumentSettingAccess.hxx> #include <sfx2/docfile.hxx> #include <svl/itemiter.hxx> @@ -252,6 +253,14 @@ SwExpandPortion *SwTextFormatter::NewFieldPortion( SwTextFormatInfo &rInf, else if( subType == REF_SETREFATTR ) static_cast<SwFieldPortion*>(pRet)->m_nAttrFieldType = ATTR_SETREFATTRFLD; break; + case SwFieldIds::TableOfAuthorities: + { + OUString const aStr( bName + ? pField->GetFieldName() + : static_cast<SwAuthorityField const*>(pField)->ExpandCitation(AUTH_FIELD_TITLE, pFrame->getRootFrame()) ); + pRet = new SwFieldPortion(aStr); + } + break; but the test doesn't pass
Xisco Faulí committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/332a37ebf3eeb7546ef0972035d72c6e836bcc7d Revert "tdf#107784: DOCX Import: Show citation's title in fields" It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c02b5cf6472ccb45a916369db493a40ed3e21d60 tdf#107784: DOCX Import: Show citation's title in fields (2nd take) It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Xisco Fauli committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/commit/420c306394ff781fb361f1fb12b5b993a67dd36b tdf#107784: DOCX Import: Show citation's title in fields (2nd take) It will be available in 6.3.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.