Bug 107804 - Character and Paragraph sidebar content panels not expanded for some files (where missing fonts are substituted?)
Summary: Character and Paragraph sidebar content panels not expanded for some files (w...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
5.1.0.3 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, regression
: 113173 (view as bug list)
Depends on:
Blocks: Sidebar-Properties-Paragraph Sidebar-Properties-Character
  Show dependency treegraph
 
Reported: 2017-05-12 18:35 UTC by Timur
Modified: 2017-12-20 06:13 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Timur 2017-05-12 18:35:52 UTC
Open attachment 129585 [details] from Bug 104644 or attachment 107396 [details] from Bug 84703.
Go into text to get Character and Paragraph Properties in Sidebar. 
They should be expanded but are condensed, why? Click + to expand them.
Click to slide to get Slide and Layout Properties and then back to text. 
Character and Paragraph Properties are again condensed and not expanded. 

Not sure if it's related to missing fonts that are substituted. 
Both in Windows and Linux, also with 5.4+.
Comment 1 Buovjaga 2017-05-14 11:17:33 UTC
No repro in 5.0, regression.

In 5.3.2 on Linux, Char is collapsed, but Para is open..

Version: 5.4.0.0.alpha1+
Build ID: c90510acfe1ec042adf27452e311964a770965a6
CPU threads: 4; OS: Windows 6.2; UI render: default; 
TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2017-05-13_21:42:54
Locale: fi-FI (fi_FI); Calc: group

Version: 5.0.2.2 (x64)
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Locale: en-US (fi_FI)

Version: 5.3.3.1 (x64)
Build ID: 46360c72c4823cefeaa85af537fba22bd568da7e
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; Layout Engine: new; 
Locale: fi-FI (fi_FI); Calc: group

Arch Linux 64-bit, KDE Plasma 5
Version: 5.3.2.2
Build ID: 5.3.2-3
CPU Threads: 8; OS Version: Linux 4.10; UI Render: default; VCL: kde4; Layout Engine: new; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group

Arch Linux 64-bit, KDE Plasma 5
Version: 5.4.0.0.alpha1+
Build ID: c0968aa4673a8ac9a8a09a0e291b58b94bdbb35e
CPU threads: 8; OS: Linux 4.10; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on May 13th 2016
Comment 2 Timur 2017-05-17 08:46:54 UTC
I can reproduce with 5.1.0 on Windows LO 32-bit. Like there are some differences on Linux, no repro with 5.1.6 but repro later. Also, no repro with 5.1.2 LO 64-bit but repro later. Anyway, repro with master. I'll set version to 5.1.0.
Comment 3 Timur 2017-10-17 15:09:04 UTC
*** Bug 113173 has been marked as a duplicate of this bug. ***
Comment 4 Timur 2017-10-17 15:16:49 UTC
Norbert, you wrote that Bug 91806 seems to be the cause for regressions:
Bug 113173 (i.e. this bug 107804) and Bug 99537. 
Why? Did you bibisect it? You didn't cced author, so I do it now.
Comment 5 OfficeUser 2017-10-17 19:25:50 UTC
Refer to bug 113173 for additional presentations to reproduce the bug.
Comment 6 OfficeUser 2017-10-18 08:14:31 UTC
I can confirm that this bug is font related. I have changed all fonts in my attachment to duplicate bug 107804 to Arial. This made the sidebar working as expected.
Comment 7 OfficeUser 2017-10-18 08:18:20 UTC
I mean duplicate bug 113173.
Comment 8 Aron Budea 2017-10-19 17:07:49 UTC
Bibisected to the following range using bibisect-win32-5.1 (it's a single commit in the bibisect repo, further bibisecting not possible):
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=ff2bdd52f54db24f867957a3293fae08e6a431a3..9b6d78cc68e9dc644bf2d06b358049de3cd3ee8f
Comment 9 Aron Budea 2017-10-19 17:09:08 UTC
Also, the behavior was different with an existing profile, so I had to start LO with a clean profile at each step.
Comment 10 Aron Budea 2017-10-19 17:19:45 UTC
A wild guess? Even if this might be the commit, the real cause seems to be something else.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=9bd618740ea5da9d5077f755530de56f1e913bea
author		Michael Stahl <mstahl@redhat.com>	2015-12-01 22:59:19 (GMT)
committer	Michael Stahl <mstahl@redhat.com>	2015-12-02 10:13:20 (GMT)

tdf#96162: sfx2: avoid re-creating existing sidebar Panels
Comment 11 OfficeUser 2017-10-19 19:25:28 UTC
I had exactly the same idea.
Comment 12 OfficeUser 2017-11-03 09:53:59 UTC
The bugs I have reported in my duplicate bug 113173 have vanished with:

Version: 6.0.0.0.alpha0+
Build ID: cfbb8b5090537e79ba70e250ddee86d53facbe15
CPU threads: 8; OS: Linux 4.4; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2017-10-18_22:54:20
Locale: de-DE (de_DE.UTF-8); Calc: group

@Timur: Could you please check if "you" issue is fixed as well?

Maybe these problems have been fixed by the patch from bug 99537.
Comment 13 OfficeUser 2017-11-03 09:56:34 UTC
I have tried
bugzilla-libreoffice-fontbug.pptx
and cannot reproduce such problems.
Comment 14 Xisco Faulí 2017-11-03 10:19:46 UTC
It seems to be fixed in

Version: 6.0.0.0.alpha1+
Build ID: 1f8c3e3b78e0abb96d06a51eca354ae7ade5deb2
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group
Comment 15 Timur 2017-11-03 11:38:02 UTC
Xisco was faster :)
Looks OK now.
Comment 16 Aron Budea 2017-12-20 06:13:41 UTC
Fixed by the same commit as the one that fixed bug 99537:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=ce2e94a98f5fc85bef7623a0227b3a95d8093288