Created attachment 133397 [details] animation of selection with mouse Open the BASIC IDE and show a macro in the edit window. Select a line of the text. Notice that the entire window repeats to refresh, while you drag the mouse. I do not own a screen cast application, but can only take single pictures while moving the mouse. But this pictures show clearly that the edit window content is refreshed several times, see attachment. I use Version: 5.4.0.0.alpha1+ Build ID: 965494c544dd8f35ae83b7cf38549009da06c367 CPU threads: 4; OS: Windows 6.1; UI render: default; TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2017-05-10_23:06:27 Locale: de-DE (de_DE); Calc: group It happens too in Version: 5.3.3.2 Build ID: 3d9a8b4b4e538a85e0782bd6c2d430bafe583448 CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; Layout Engine: new; Locale: de-DE (de_DE); Calc: group It does not happen with Version: 5.2.6.2 Build ID: a3100ed2409ebf1c212f5048fbe377c281438fdc CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; Locale: de-DE (de_DE); Calc: group
I have this issue. I discovered that turning the new layout engine (SAL_NO_COMMON_LAYOUT=1) speeds things up a bit, but it still flickers badly while selecting text. It's obviously redrawing way too much.
Seems like this has been there since 5.0, but maybe gotten worse in 5.3.
Bibsected using bibisect-win32-5.3 with "set SAL_USE_COMMON_LAYOUT=1" (as the first result that came up was this: 8f2dd1df1d6cc94ebbc1149de72bc6d6dffa6533, Revert "Revert "Enable the new text layout engine by default"") 52fc4434554cb8bcbcc13469646a6ea5c99f77af is the first bad commit commit 52fc4434554cb8bcbcc13469646a6ea5c99f77af Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Fri Oct 28 12:35:08 2016 -0700 source 3d456dfa6637c6c3ebe7a21f1f1a5b05039cee2a # bad: [5e01bd2a91a717cdaccff18de7c44de37b270914] source 8f2dd1df1d6cc94ebbc1149de72bc6d6dffa6533 # good: [f45c7f1a4528ed75f559214e1d85745c8f7b1c2f] source b6011f07254f8003929320ad842d8d09daca0e09 git bisect start '5e01bd2a91a717cdaccff18de7c44de37b270914' 'f45c7f1a45' # good: [e2f8bf1b68f219578df7c5e05152c22de437854e] source f6998d9087c472954cc605c1308ec2df940dddd9 git bisect good e2f8bf1b68f219578df7c5e05152c22de437854e # good: [cd0fdaad92fdbe91c72347947043b6f5f4a8e600] source 29eb4f122bab9ba7280945d0c8a15588b1d46895 git bisect good cd0fdaad92fdbe91c72347947043b6f5f4a8e600 # good: [1b76dd1843459a206c0954a104ab7869114f32c0] source 141a7aa1b3faafa7bf5c45b73f1604b16809a1a3 git bisect good 1b76dd1843459a206c0954a104ab7869114f32c0 # good: [427e801080da6d20ba26d12fbdbd4ea81589f33f] source 94af3da7e11e82c4ed2d59655e246b5201c18709 git bisect good 427e801080da6d20ba26d12fbdbd4ea81589f33f # bad: [1ad8c06adf8e9e9d712808f18e0c6e37a798a193] source 1e467fa8ae06ee4953511973f1785f41d8ba9e31 git bisect bad 1ad8c06adf8e9e9d712808f18e0c6e37a798a193 # bad: [a3e9f0310e37e8c3e50981f76b0decf5ac4c0c3f] source 20dd5fbecc8990366727371f851ffb4914345601 git bisect bad a3e9f0310e37e8c3e50981f76b0decf5ac4c0c3f # bad: [c0dd27d8652b2cfcbf15fd3eb45eda79cd4088b1] source 70e97ade2f8dd6f61574dca985074f550db0630f git bisect bad c0dd27d8652b2cfcbf15fd3eb45eda79cd4088b1 # good: [77c16f95aefbf077e1ae46d3abef1c4a374884dc] source 5c33253daf23224424cf6b181a2c2235c4a82539 git bisect good 77c16f95aefbf077e1ae46d3abef1c4a374884dc # bad: [8a7d614e714389333ca05a3982516d08da6c4671] source 85c38f1cf4844a99bca3d08ddfcc0c798ce5873e git bisect bad 8a7d614e714389333ca05a3982516d08da6c4671 # bad: [52fc4434554cb8bcbcc13469646a6ea5c99f77af] source 3d456dfa6637c6c3ebe7a21f1f1a5b05039cee2a git bisect bad 52fc4434554cb8bcbcc13469646a6ea5c99f77af # good: [ee5bfce110bfa45d6fc6bd1fafc19f45bff43fb7] source c0baab9aa80bfa49b753d2d598a4fbc71ceb656e git bisect good ee5bfce110bfa45d6fc6bd1fafc19f45bff43fb7 # first bad commit: [52fc4434554cb8bcbcc13469646a6ea5c99f77af] source 3d456dfa6637c6c3ebe7a21f1f1a5b05039cee2a
I went for the change that caused this to go from slightly flickering to badly flickering. It might be worth going for the original issue as well (in a separate bug report), I can't decide which fix would be more significant. Adding Cc: to Khaled Hosny, please take a look. https://cgit.freedesktop.org/libreoffice/core/commit/?id=3d456dfa6637c6c3ebe7a21f1f1a5b05039cee2a author Khaled Hosny <khaledhosny@eglug.org> 2016-10-28 02:19:46 (GMT) committer Khaled Hosny <khaledhosny@eglug.org> 2016-10-28 19:22:54 (GMT) "tdf#98879: Fix vertical text on Windows for the new layout"
This commit simply enabled the DirectWrite text rendering code, if there are any bugs it must have been there already in that code.
.
It still happens on Version: 5.4.0.0.beta1 Build ID: 8672113ead4e403c55e31b1d9a3d1e0f3b299577 CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk2; Locale: it-IT (it_IT.UTF-8); Calc: group
It would be nice to be able to test this in earlier versions in Windows somehow. It occurs in Linux as well, but not with GTK3, only with GTK2 VCL plugin, and it started somewhere between 5.1.0.3 and 5.2.0.4. Bibisecting using repo lo-linux-dbgutil-daily-till52 pointed to this range: https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=e0d2acfa65d81da323cbe91e6451fca70e00bdd5..c56e0858b081b4dfe78745cf80c829f6c3c2e7b8
No "flicker" in Version: Version: 5.3.1.2 (x64) Build-ID: e80a0e0fd1875e1696614d24c32df0f95f03deb2 CPU-Threads: 8; BS-Version: Windows 6.19; UI-Render: Standard; Layout-Engine: neu; Gebietsschema: de-DE (de_DE); Calc: group Windows 10, 64 Bit - all updates. works perfekt. Testversion 5.4.0 "flickers". All: Basic-IDE.
*** Bug 111772 has been marked as a duplicate of this bug. ***
Seems to be reproducible in LO 5.3.5 and 6.0.0.0.alpha0+. See duplicate bug 111772. Best regards. JBF
*** Bug 113508 has been marked as a duplicate of this bug. ***
Removing keyword bibisectRequest as it's already bibisected.
Also reproducible on Windows with Version: 5.0.0.5 Build ID: 1b1a90865e348b492231e1c451437d7a15bb262b Locale: nl-NL (nl_NL) but not with: Versie: 4.4.7.2 Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600 Locale: nl_NL
Indeed, this should've been bibisected to the start of the flickering, which is somewhere in the following, rather large range in bibisect-win32-5.0 (opening the macro editor crashes in between, I only did a handful of skips during bibisecting, and didn't bother finding the exact start and end of the crashing): https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=cb4276278962c2cbd47d0685881fb2460bf31c70..848e020fcf3ba4d6c8ff0a03fb6049193cc78848
*** Bug 134018 has been marked as a duplicate of this bug. ***
Not sure, if that helps, but I did a bibisect with https://wiki.documentfoundation.org/QA/Bibisect/Windows#bibisect-win32-5.0: git.exe bisect bad 94da532b9fb51e2d0bc55ef7c5f252a3168b451c is the first bad commit commit 94da532b9fb51e2d0bc55ef7c5f252a3168b451c Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Wed Jun 3 14:03:40 2015 -0500 source 29b1e6718f6ebdb45d2a8c6a89a86bc0a6bbb3ae
Looks plausible, thanks Gerhard.
...which might be this change: https://cgit.freedesktop.org/libreoffice/core/commit/?id=29b1e6718f6ebdb45d2a8c6a89a86bc0a6bbb3ae commit 29b1e6718f6ebdb45d2a8c6a89a86bc0a6bbb3ae Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> AuthorDate: Wed May 6 15:49:16 2015 +0900 Commit: Jan Holesovsky <kendy@collabora.com> CommitDate: Thu May 7 09:57:50 2015 +0200 refactor "TextEdit" & co. to use RenderContext Change-Id: Ib26ecb9640d23714acec73304f26e2fd6af90ed4
I do not fully grasp the advantage of that change.
Probably gone in 7.0, didn't check though
Yes, looks good in 7.0 RC1.
Can this be back-ported to 6.x? In 7.0 there are still many other bugs.
(In reply to Gerhard Schaber from comment #23) > Can this be back-ported to 6.x? In 7.0 there are still many other bugs. No, impossible. It's fixed by the Skia backend. The only 'solution' is reporting the bugs present in 7.0 and/or attaching yourself (CC list) to bug you deem to see important. The result might be that those will sorted out first. No hard promises of course
(In reply to Telesto from comment #24) > (In reply to Gerhard Schaber from comment #23) > > Can this be back-ported to 6.x? In 7.0 there are still many other bugs. > > No, impossible. It's fixed by the Skia backend. The only 'solution' is > reporting the bugs present in 7.0 and/or attaching yourself (CC list) to bug > you deem to see important. The result might be that those will sorted out > first. No hard promises of course Hi Regina, The issue seems to be fixed with SKIA, could you please check again? what about GDI ?
The IDE has some small flickering when selecting text, if Skia is disabled. Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 58f2c1e6ab3052e0746dabb36e6061125779b034 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: default; VCL: win Locale: de-DE (en_US); UI: en-US Calc: CL The IDE has no flickering at all when selecting text, if Skia is enabled. Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 58f2c1e6ab3052e0746dabb36e6061125779b034 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: de-DE (en_US); UI: en-US Calc: CL So I would say, that the originally reported error is fixed.