1. Open attachment 103959 [details] from bug 82107
Observed behaviour: Numbering is duplicated in page 2
[Bug found by office-interoperability-tools]
Build ID: cb37c5f0f3de7b545231a53d46a5271058af76ad
CPU threads: 1; OS: Windows 6.1; UI render: default;
TinderBox: Win-x86@42, Branch:master, Time: 2017-06-23_06:55:41
Locale: es-ES (es_ES); Calc: group
Regression introduced by:
author Justin Luth <email@example.com> 2017-05-30 14:13:47 (GMT)
committer Justin Luth <firstname.lastname@example.org> 2017-06-09 05:35:18 (GMT)
commit fdfdea4d5af51a68f2d497cc5c3359d74c385fd5 (patch)
parent 691d1e90f62ce3f1930d3faf74af385d92f00d59 (diff)
tdf#82173 writerfilter: apply char properties to footnote
The char property values as defined in w:rPr were not connected
to the in-text footnote or endnote.
Bisected with bibisect-linux64-6.0
Adding Cc: to Justin Luth
Same behaviour seen in attachment 56090 [details] from bug 45182
Same result with attachment 104064 [details] from bug 81944
Easy to replicate by saving a working .docx in .rtf format. Only seems to affect .rtf - no idea why RTF would act differently here.
A simple fix is to only copy CONTEXT_CHARACTER formatting.
RTF!!! writerfilter/source/dmapper/DomainMapper_Impl.cxx:1725: ::PushFootOrEndnote topContext is PARA CHAR
DOCX!! writerfilter/source/dmapper/DomainMapper_Impl.cxx:1725: ::PushFootOrEndnote topContext is PARA CHAR
RTF export is terribly wrong, so just avoiding the problem when detecting RTFImport.
proposed fix: https://gerrit.libreoffice.org/39775
Abandoned the first proposed fix in favour of https://gerrit.libreoffice.org/40430.
RTF documents still couldn't do what bug 82173 fixed for .docx - keeping the char formatting around a footnote character. This fix does that, resolving the regression at the same time.
Justin Luth committed a patch related to this issue.
It has been pushed to "master":
tdf#108949 rtf writerfilter: apply char properties to footnote
It will be available in 6.0.0.
The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.
Build ID: 50799a721c7ddcf9475a1b79984ed64ddd7cdf57
CPU threads: 4; OS: Linux 4.8; UI render: default; VCL: gtk3;
Locale: ca-ES (ca_ES.UTF-8); Calc: group