Bug Hunting Session
Bug 112437 - Go to page toolbar control
Summary: Go to page toolbar control
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: topicUI
Depends on:
Blocks: UNO-Command-New Navigator Go-To-Page
  Show dependency treegraph
 
Reported: 2017-09-17 00:45 UTC by Jim Raykowski
Modified: 2018-05-10 02:18 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot of Go To Page toolbar control (11.47 KB, image/png)
2017-09-17 00:45 UTC, Jim Raykowski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Raykowski 2017-09-17 00:45:51 UTC
Created attachment 136292 [details]
screenshot of Go To Page toolbar control

I have made a Go To Page toolbar control. The attached screenshot shows it added  to the Findbar control through use of the customize option.
Comment 1 Heiko Tietze 2017-09-18 13:50:13 UTC
Great work, Jim. Guess everything was tracked under bug 79167 - otherwise you would have asked a question. So looking forward your next patch :-).

*** This bug has been marked as a duplicate of bug 79167 ***
Comment 2 Yousuf Philips (jay) (retired) 2017-09-18 17:00:16 UTC
A jump to page number toolbar control was created for the print preview toolbar (bug 80657), but it was a simple text field and not a spinbox. So please do create this control (might be useful if both toolbar controls shared code), though i'm doubtful that the find toolbar is a suitable place for it.

@heiko, @stuart, @cor: what is your take?
Comment 3 Jim Raykowski 2017-09-18 23:06:41 UTC
I created it to replace the spinbox page control in Navigator panel but like the 'Navigate By' and 'Previous/Next Navigate By' controls it will work in other toolbars. The Navigator panel toolbar is able to use this 'Jump to/Go to/Move to Page' control as well as the 'Navigate By' dropdown  and 'Previous/Next controls' that are part of the Find tool bar. I used the customize toolbar feature to add this control to the find bar for demo purposes.

Yes, I believe the current jump to page toolbar control only works in the print preview toolbar. I custom added to the Find tool bar and it didn't function as expected so I looked at the code and saw that it is intended for the print preview toolbar.
Comment 4 Yousuf Philips (jay) (retired) 2017-09-19 11:37:34 UTC
(In reply to Jim Raykowski from comment #3)
> I created it to replace the spinbox page control in Navigator panel

Sweet.

> I used the
> customize toolbar feature to add this control to the find bar for demo
> purposes.

Oh okay. It would be great to have it in .uno command form and functional everywhere, so that it can be added to any toolbars and hopefully it will wind up in one of the notebookbar implementations.

> Yes, I believe the current jump to page toolbar control only works in the
> print preview toolbar. I custom added to the Find tool bar and it didn't
> function as expected so I looked at the code and saw that it is intended for
> the print preview toolbar.

Thanks for the info.
Comment 5 Jim Raykowski 2017-09-27 08:00:11 UTC
Hello All,
 
I did a commit for this about a week ago at a time when gerrit was having troubles. The commit resulted in "No Builds Executed". There was a notice saying "If one of your Gerrit patch sets was affected by the purge, it should have received a "No Builds Executed" comment from Jenkins now. You can manually re-submit it by doing a rebase."

I read about git rebase and did some testing but would appreciate some help with this.

The link to the commit is
https://gerrit.libreoffice.org/42492
Comment 6 Jim Raykowski 2017-10-07 00:58:58 UTC
Thank you Yousuf for doing the rebase. Unless instructed different, I will wait for this to be merged before committing work done on tdf#89566 as it involves use of this control.
Comment 7 Xisco Faulí 2018-01-22 10:56:04 UTC
Dear Jim Raykowski,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assigned it back to yourself if you're still working on this.
Comment 8 Jim Raykowski 2018-05-10 02:18:17 UTC
  (In reply to Xisco Faulí from comment #7)
> Dear Jim Raykowski,
> This bug has been in ASSIGNED status for more than 3 months without any
> activity. Resetting it to NEW.
> Please assigned it back to yourself if you're still working on this.

Xisco, sorry about the delayed response. This wasn't accepted during review. There is already a toolbar control that does this using a different approach than the one I took.