Bug Hunting Session
Bug 112876 - Make use of scroll lock for navigation configurable (it conflicts with system use as keyboard layout indicator)
Summary: Make use of scroll lock for navigation configurable (it conflicts with system...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
5.3.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: easyHack, skillCpp
: 120869 (view as bug list)
Depends on:
Blocks: Options-Dialog-Calc
  Show dependency treegraph
 
Reported: 2017-10-04 12:30 UTC by Shay G
Modified: 2019-09-26 10:57 UTC (History)
15 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Shay G 2017-10-04 12:30:28 UTC
Hi,

Recently (1) scroll lock has started being used to navigate the document (Same as in MS Excel). However I use scroll lock to indicate current input language...

Is it possible to add an option for this?

Thanks

(1) https://bugs.documentfoundation.org/show_bug.cgi?id=46200
Comment 1 Aron Budea 2017-10-04 13:38:01 UTC
Seems reasonable, it was also requested in bug 46200 comment 31 and in bug 111627 (which also seems to be about a bug, but needs more details from the reporter).
I'm not sure why the feature should be deactivated by default, though, that needs further reasoning. CCing the others who requested this before.

UX team, please suggest a configuration option for this.
Comment 2 Shay G 2017-10-04 13:46:55 UTC
In debian, in a multi language config it should be disabled by default as debian uses scroll lock like this by default. On other distros it shouldn't.
Comment 3 erbe 2017-10-04 14:47:01 UTC
Hi,

I would say, to keep it simple, the option shall be enabled by default (like in MS Excel) in all distributions - if needed a user could disable it somewhere in configuration - and for this we would need an option somewhere in preferences. 

I also do use Debian with two keyboard layouts and don't use the scroll lock's LED to show me which keyboard layout I use. I can see it in Gnome or XFCE taskbar.

Regards
Comment 4 Heiko Tietze 2017-10-05 07:25:59 UTC
What I understand is that Shay wants to reconfigure the shortcut. For other functions that's done via tools > customize (greatly improved for 6.0) where .uno:ScrollLock should be bound to .key:ScrollLock (or whatever this is labeled internally). And this assignment can be removed or redefined.
Comment 5 Shay G 2017-10-05 14:04:34 UTC
(In reply to Heiko Tietze from comment #4)
> What I understand is that Shay wants to reconfigure the shortcut. For other
> functions that's done via tools > customize (greatly improved for 6.0) where
> .uno:ScrollLock should be bound to .key:ScrollLock (or whatever this is
> labeled internally). And this assignment can be removed or redefined.

Yes.
Comment 6 Dmitry 2017-11-14 21:23:44 UTC Comment hidden (me-too)
Comment 7 Sergey 2017-11-19 11:15:28 UTC Comment hidden (me-too)
Comment 8 Heiko Tietze 2017-11-19 11:42:31 UTC
(In reply to Sergey from comment #7)
> So I don't see why LibreOffice should make its default configuration conflicting
> with all these systems.

When a user wants to configure the scroll key him or herself, why not? By default it will be empty, of course.

Removing UX, dev please add scrollkey to customization.
Comment 9 Sergey 2017-11-19 12:52:03 UTC
(In reply to Heiko Tietze from comment #8)
> (In reply to Sergey from comment #7)
> > So I don't see why LibreOffice should make its default configuration conflicting
> > with all these systems.
> 
> When a user wants to configure the scroll key him or herself, why not? By
> default it will be empty, of course.
> 
> Removing UX, dev please add scrollkey to customization.

Yes, I was talking about default setting. User should be able to customize it, no question.
Comment 10 Norbert X 2017-11-30 16:42:58 UTC
Scroll Lock option is needed.

(see my comment 8 at bug 111627 - https://bugs.documentfoundation.org/show_bug.cgi?id=111627#c8 for details).
Comment 11 kolrac 2018-01-08 14:22:11 UTC
This is not the disturbing of a normal feature: some people assigned a feature to the Scroll Lock key  because of a bug in X11 and Wayland which prevents the key from working as expected. The normal feature, as originally intended, is to modify the behavior of arrow keys and that’s what LO Calc now does.

Also, adding an option to disable this feature means more complexity. Is the feature on or off, how will the ordinary user (possibly used to Excel which supports it) will figure it out? Not everybody reads the release notes. And what happens when or if the bug is fixed in X11 or in Wayland? (See <https://bugs.freedesktop.org/show_bug.cgi?id=94226> and <https://bugs.freedesktop.org/show_bug.cgi?id=104050>).

So, IMHO, no option to disable this is needed for the reasons explained above. If, however, developers decided to add such an option I think it should be disabled by default and the decision to enable it should be left to distro maintainers and/or the end users in order to avoid confusing the huge majority of the user base. Just my 2 cents.
Comment 12 Heiko Tietze 2018-02-13 08:42:35 UTC
Would be nice if the option gets predefined depending on the system capability whether scroll lock is available or not.
Comment 13 Eike Rathke 2018-02-15 15:31:49 UTC
Availabilty still doesn't tell anything about whether it behaves as expected or is unexpectedly abused by some Window manager or other means as an LED indicator activating the lock.
Comment 14 Karsten 2018-02-15 15:58:02 UTC
An option scroll behaviour with 3 choices would solve the problem:
* keyboard (as read from desktop system)
* on (permanent on)
* off (permanent off)
Comment 15 m.a.riosv 2018-03-07 01:23:46 UTC
*** Bug 116250 has been marked as a duplicate of this bug. ***
Comment 16 Eyal Rozenberg 2018-03-07 13:20:00 UTC
Changing the bug title because a configurable option is a possible fix, not the problem itself; and also to avoid dupes being created (like bug 116250).
Comment 17 Mike Kaganski 2018-07-19 00:18:19 UTC
Don't see why this easyhack needs much evaluation. It's known which commit ( http://cgit.freedesktop.org/libreoffice/core/commit/?id=453de3473cf6f383c71466a1ed15e28b844ed7e5 for bug 46200 ) changed the behaviour; so the only thing that is needed is to take a new configuration into account when evaluating the value of bool bScrollLock in ScCellShell::ExecuteCursor. I am sure that Heiko could assist with the new configuration option bits.
Comment 18 Mike Kaganski 2018-07-19 00:44:19 UTC
(In reply to kolrac from comment #11)
> If, however, developers decided to add such an option I think it
> should be disabled by default and the decision to enable it should be left
> to distro maintainers and/or the end users in order to avoid confusing the
> huge majority of the user base.

(In reply to Heiko Tietze from comment #12)
> Would be nice if the option gets predefined depending on the system
> capability whether scroll lock is available or not.

I agree with kolrac on this; when an option is available, it's maintainers' task to define customized defaults when they know it makes sense on the systems they maintain (in the absence of some universal API to obtain meaningful default from system). I don't think that we should try to change the default in LibreOffice from current mode; just introduce the option to disable use of Scroll Lock state for navigation, and let maintainers/users to decide.
Comment 19 Joseph Mitzen 2018-08-21 04:51:22 UTC
(In reply to kolrac from comment #11)

> Also, adding an option to disable this feature means more complexity. Is the
> feature on or off, how will the ordinary user (possibly used to Excel which
> supports it) will figure it out? Not everybody reads the release notes. And
> what happens when or if the bug is fixed in X11 or in Wayland? (See
> <https://bugs.freedesktop.org/show_bug.cgi?id=94226> and
> <https://bugs.freedesktop.org/show_bug.cgi?id=104050>).
> 
> So, IMHO, no option to disable this is needed for the reasons explained
> above. 

This feature whose only purpose seems to be to mimic Excel conflicts with both software and hardware in the real world. The comments here have mentioned some software it conflicts with. In terms of hardware, the popular Cooler Master CMStorm keyboard uses the scroll lock key to turn the backlight on and off. The keyboard is such that you need to have the backlight on, day or night, to see the key labels. This means that if you use LibreOffice you're either stuck in the bizarro scroll mode, meaning you can't use the keyboard to move around a spreadsheet, or you have to turn off the backlight, meaning you can't see the labels on your keys. 

That said, using the latest LibreOffice, 6.1.0.3, in OpenSUSE Tumbleweed, and a CMStorm keyboard, the scrolling no longer occurs. I assumed LibreOffice turned it off until I found this page. If LibreOffice didn't make the change, I wonder if OpenSUSE did? Very weird.
Comment 20 Roman Kuznetsov 2018-09-30 16:53:55 UTC
*** Bug 120206 has been marked as a duplicate of this bug. ***
Comment 21 Norbert X 2018-10-15 19:54:43 UTC Comment hidden (me-too)
Comment 22 Vladimir 2018-11-14 00:14:25 UTC Comment hidden (me-too)
Comment 23 Mike Kaganski 2018-11-14 05:30:47 UTC
(In reply to Vladimir from comment #22)
> ... and when i diceded to google it - what i saw? Proposal to change default
> befaviour of so many distros and DEs instead of adding a simple option?

Amazing how hard reading is.
Instead of seeing what actually is here (the proposal confirmed and set to NEW, supported by UX, and set to easy hack with code pointers, to help anyone interested to jump in and fix it), one sees such bizarre things you couldn't imagine.
Comment 24 Karsten 2018-11-14 07:59:22 UTC Comment hidden (me-too)
Comment 25 Buovjaga 2018-12-27 17:36:28 UTC
*** Bug 120869 has been marked as a duplicate of this bug. ***
Comment 26 Serhiy 2019-09-22 21:10:54 UTC
Please, make this option configurable, because as for now after so many years i can't use LibreOffice :(

I have HP ZBook laptop and on Windows 10 I can not turn on ScrollLock. After research I managed to turn on ScrollLock using onscreen keyboard, and now I can move cell selection by arrow keys only up and down, but left and right arrows move a sheet itself, instead of cell selection. That's very pity and make the navigation to be very hard, I can't work in LO like this, sorry.

LO  6.3.1.2 (64 bit), Windows 10 Pro, HP ZBook 15.