Description: When an update to some extension is available, an alert is shown. An icon should appear in the top right corner of the LibO window. Unfortunately, with LibO and the kde VCL this does not work as it should. A notification is shown, but there is no icon. As a matter of fact, the icon is there, just not visible. Hovering with the mouse on the top right corner of LibO makes a small frame appear together with the notification text. Steps to Reproduce: See description. It is impossible to reproduce the issue with user actions. An extension update should be available. Actual Results: See description Expected Results: See description Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: TextDocument [Information guessed from browser] OS: Linux (All) OS is 64bit: yes Builds ID: LibreOffice 5.4.2.2 User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0
Could you please attach an screenshot ?
Created attachment 137073 [details] Screenshot showing the issue
Screenshot has been provided. This is when you hover with the mouse, which gives you the notification and the small squared frame. Otherwise, nothing is shown at all.
In fact, a regression in 5.4. Libreoffice 5.3 used to show the icon on my same platform.
Confirmed under Windows.
Still an issue in LibO 6.0.1 RC 1
Still an issue as of 6.0.3.1
Created attachment 141386 [details] Windows 7 invisible update icon
Having this issue on Windows 7 64-bit, running version 6.0.1.1 (x64). Will attach screenshot. I'm seeing this issue in both Writer and Calc.
Confirming for LO 6.0.21 reporting an update to 6.0.3 on Windows 7 SP1 x64 (German) with Java 1.8u162 and OpenGL acceleration enabled (GT1050Ti). Hovering the area displays the button frame. The notification bubble on top of the application window also looks a bit strange, like missing its border on one side, and missing possible shadow effects.
Bug is still present as of 6.1 beta. The update reminder feature has been broken through 5.4, 6.0 and now it may remain broken through the 6.1 cycle too. May I suggest that the feature is temporarily hidden/disabled altogether for 6.1 until it can be fixed? IMHO, as is it is very confusing for users (who see a notification without knowing what it refers to) and gives a very poor impression of the application for a very little advantage.
*** Bug 117396 has been marked as a duplicate of this bug. ***
I could 'bibisect' it with bibisect-linux-64-releases and it started in libreoffice-5.4.0.0.alpha1
@Andreas, @Heiko, would you mind checking if the icon still exists in the build system?
Created attachment 142978 [details] how the icon in previous versions
It should be https://opengrok.libreoffice.org/xref/core/icon-themes/colibre/extensions/source/update/ui/onlineupdate_26.png since it was https://gerrit.libreoffice.org/#/c/53092/5/icon-themes/galaxy/extensions/source/update/ui/onlineupdate_26.png,unified for Galaxy.
*** Bug 118669 has been marked as a duplicate of this bug. ***
Nice comment with code pointer from V Stuart: https://bugs.documentfoundation.org/show_bug.cgi?id=118669#c1
(In reply to Xisco Faulí from comment #18) > Nice comment with code pointer from V Stuart: > https://bugs.documentfoundation.org/show_bug.cgi?id=118669#c1 I'll just add them here... Clicking Help -> Check for Updates, enables the "LibreOffice update available" Balloon on the MenuBar, but no icon is shown on the button. Looks like the Static definition of the bitmap/icon used by the createMenuBarUI used for the updatecheck needs a tweak. =-ref-= https://opengrok.libreoffice.org/xref/core/extensions/source/update/check/updatecheck.cxx#184 https://opengrok.libreoffice.org/xref/core/extensions/source/update/ui/updatecheckui.cxx#79 https://opengrok.libreoffice.org/xref/core/extensions/inc/bitmaps.hlst#42
*** Bug 118815 has been marked as a duplicate of this bug. ***
*** Bug 121042 has been marked as a duplicate of this bug. ***
*** Bug 121941 has been marked as a duplicate of this bug. ***
Ok the icons extensions/source/update/ui/onlineupdate_16 extensions/source/update/ui/onlineupdate_26 are available in - breeze, breeze_dark, breeze_svg - colibre, colibre_svg - elementary, elementary_svg where onlineupdate_26 is 24x24px and onlineupdate_16 is 16x16px in karasa_jaga onlineupdate_26 is 66x21px and onlineupdate_16 is 44x13px and in tango onlineupdate_26 is 22x22px and onlineupdate_16 is 16x16px in sifr, sifr_dark, sifr_svg and tango_svg the icons are missing. so from my point of view I don't think it's an icon issue the issue is somewhere in the code.
(In reply to andreas_k from comment #23) The bitmaps.hlst mapping suggests they should be in core/extensions/source/update/ui, but I don't see them there. Otherwise, wouldn't they be better handled if moved to receive the same handling in all icon-themes? From core/extensions/source/update/ui to core/icon-themes/<theme>/res
(In reply to V Stuart Foote from comment #24) > (In reply to andreas_k from comment #23) > The bitmaps.hlst mapping suggests they should be in > core/extensions/source/update/ui, but I don't see them there. > > Otherwise, wouldn't they be better handled if moved to receive the same > handling in all icon-themes? > > From core/extensions/source/update/ui to core/icon-themes/<theme>/res ah thanks stuart, I copy the colibre update icon into core/extensions/source/update/ui, but I recommend to use the icon theme related icons as you also suggested Stuart.
Sergio, please verify that this patch works.
andreas kainz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/4f89c98d715592be42d8d378786d79eb27acadcb%5E%21 tdf#113205 add onlineupdate icons to core/extensions/source/update/ui It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
andreas kainz committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/8c7473e2998e13fc9c62aaa9ce9d7b536e81be57%5E%21 tdf#113205 add onlineupdate icons to core/extensions/source/update/ui It will be available in 6.2.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Created attachment 148051 [details] Screenshot with 6.2.0.1 (In reply to Commit Notification from comment #28) > It will be available in 6.2.0.1. Still reproducible with Version: 6.2.0.1 (x64) Build ID: 0412ee99e862f384c1106d0841a950c4cfaa9df1 CPU threads: 12; OS: Windows 10.0; UI render: default; VCL: win; Locale: ru-RU (ru_RU); UI-Language: en-US Calc: CL
The installed LibreOffice does not contain any "onlineupdate*.png". Using ProcMon, I can see that LibreOffice looks for %AppData%\LibreOffice\4\cache\colibre\100\extensions\source\update\ui\onlineupdate_16.png - with PATH NOT FOUND result (no "colibre" directory under "%AppData%\LibreOffice\4\cache" exists).
I couldn't grasp the packing machinery involved, but the pushed commits are clearly wrong, and what's missing is correct packing of the PNGs into the theme ZIPs. Adding the icons to the ZIP's extensions/source/update/ui/onlineupdate_NN.png fixes the problem.
Bibisected to https://git.libreoffice.org/core/+/816190b7b0f0cb75782cd12fe2cd908fdaf819fa using /bibisect-win32-5.4. Caolán, could you please take a look?
Hmm, I think the makefile rule in postprocess/CustomTarget_images.mk means that only images like these in a "res" subdir make their way into the zip file
https://cgit.freedesktop.org/libreoffice/core/commit/?id=5135a19c0cdc2937499e126dd5429eeb24a023a9 unzip -l instdir/share/config/images_breeze.zip |grep onlineupdate 344 01-10-2019 09:15 extensions/res/update/ui/onlineupdate_16.png 330 01-10-2019 09:15 extensions/res/update/ui/onlineupdate_26.png that seems to do it backport to 6.2 in gerrit, fixed in master
(In reply to Caolán McNamara from comment #34) Thank you very much! Do you think that previous commits should be reverted?
yeah, I'll take care of that now
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/9df951314107ba69efb820797b8b5f2918351952%5E%21 Resolves tdf#113205: move extension 'source' resources to 'res' It will be available in 6.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/fa4507a7e59cb88f87392b1cb2513d0b62c32d8b%5E%21 Related: tdf#113205, revert add icons to extensions/source/update/ui It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Caolán McNamara from comment #36) > yeah, I'll take care of that now Cherry-picked to 6-2 as well -> https://gerrit.libreoffice.org/#/c/66160/ Any chance https://cgit.freedesktop.org/libreoffice/core/commit/?id=5135a19c0cdc2937499e126dd5429eeb24a023a9 could be cherry-picked to 6-1 ? gerrit prompts as merge conflict
https://gerrit.libreoffice.org/#/c/66165/
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-1": https://git.libreoffice.org/core/+/f90139b70faf19beac1c4e812d67087502e27abf%5E%21 Resolves tdf#113205: move extension 'source' resources to 'res' It will be available in 6.1.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/bbdd753f1e0155c483a554d3f28cbc3f1521105d%5E%21 Related: tdf#113205, revert add icons to extensions/source/update/ui It will be available in 6.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified with version 6.2.2 (64 bit, Win 10). Icon for extension update is now visible at the right end of the menu bar.
Icon still (or again) does not work right for me. Version: 6.4.3.2 Build ID: 747b5d0ebf89f41c860ec2a39efd7cb15b54f2d8 CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: kf5; Locale: it-IT (en_US.UTF-8); UI-Language: en-US Calc: threaded Unfortunately, I made the mistake of updating the extension and now I cannot trigger the icon appearance anymore to take a screenshot.
don't reopen a bug that was closed over 12 months ago if a new problem similar to the old one reappears, there's no guarantee its the same problem, and it means the bug is assigned to the person who fixed the first instance and that might be the wrong person for the new instance, the original assignee may no longer even work on LibreOffice, just open a new bug
OK, sorry for following wrong procedure, I'll open a new bug.
Note that priority was "major" before I reopened by mistake. Cannot revert that.
*** Bug 133425 has been marked as a duplicate of this bug. ***