Created attachment 137322 [details] Sample file Attached file contains a bookmark named "Első" and a cross reference to it. After saving to DOCX format and reloading the cross reference becomes "Els%C5%91" while the bookmark still says "Első" and the reference breaks. After hitting space in the paragraph with the broken reference the referenced text is replaced with "Error: Reference source not found" in the document.
Created attachment 137323 [details] Screenshot of the document in LO 5.4
I can't reproduce it in Version: 6.0.0.0.alpha1+ Build ID: 0c46b3a9a384d5b70a708c3e9459a790dd815c63 CPU threads: 1; OS: Windows 6.1; UI render: default; Locale: fr-BE (es_ES); Calc: group Could you please try to reproduce it with a master build from http://dev-builds.libreoffice.org/daily/master/ ? You can install it alongside the standard version. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the master build
Created attachment 137329 [details] Example file in odt
Created attachment 137330 [details] Example file saved as docx
Created attachment 137331 [details] Example file saved as docx then resaved again In 6.0 alpha it is not broken the same way. Now the bookmark name changes as well: while it becomes an unreadable "Els%C5%91" it is consistent with the reference name, so they work. After one more resave to docx the names become: "Els%25C5%2591" - even harder to read, but still consistent. Version: 6.0.0.0.alpha1+ Build ID: 93947341acb91c7ad508d1de72f5705f730d8e93 CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk2; Locale: en-US (hu_HU.UTF-8); Calc: group
I could reproduce it: 1. Open attachment from comment 3 3. Save as docx 4. Open "fields" in the context menu of the cross-reference => Name of the bookmark is Első 5. Save as docx 6. Close and reopen 7. Open "fields" in the context menu of the cross-reference => Name of the bookmark is Els%C5%91 I couldn' reproduce the folloing behaviour: "After hitting space in the paragraph with the broken reference the referenced text is replaced with "Error: Reference source not found" in the document." Version: 6.0.0.0.alpha1 (x64) Build ID: c1d1f859b268f650143d48f294999cda0fa57350 CPU threads: 4; OS: Windows 10.0; UI render: default; Locale: de-DE (de_DE); Calc: group
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Still happens with Version: 6.2.0.0.alpha1+ Build ID: b6b31bbb1a9e2272ac77de127825c4ee9f71effa CPU threads: 4; OS: Windows 6.3; UI render: GL; VCL: win; Locale: hu-HU (hu_HU); Calc: CL
How to reproduce (the example document with the bug) in Writer (6.3): 1. create some text (for example write "lorem" and hit f3) 2. select some section of the text (for example the first sentence) 3. click on insert menu, select bookmark 4. give it a name which contains non-ASCII characters (for example Első) 5. go to somewhere else in the document, for example to the end in a new line 6. click on insert menu, select cross-reference 7. select the value "Bookmark" in "Type" listbox, then select the value "Reference" in the "Insert reference to..." listbox 8. in the "Selection" listbox, double click on the previously named bookmark 9. save the file as docx and reload it The bug is because the bookmark name will be converted to Els%25C5%2591, but the cross-reference still point at Első
Is it possible that somehow this is solved by the version 6.1.0.3? I can make an export to docx from this odt example file with the working cross-reference.
(In reply to Adam Kovacs from comment #10) > Is it possible that somehow this is solved by the version 6.1.0.3? I can > make an export to docx from this odt example file with the working > cross-reference. Comment fix: until the version 6.1.0.3.
So the reference is not broken in the version 6.1.0.3, but of course, the non ASCII characters will be converted. For example ő to %C5%91.
bookmarkName and sToken need to be decoded https://opengrok.libreoffice.org/xref/core/sw/source/filter/ww8/docxattributeoutput.cxx?r=1fe24bb1#1614 https://opengrok.libreoffice.org/xref/core/sw/source/filter/ww8/docxattributeoutput.cxx?r=1fe24bb1#1985 sToken = INetURLObject::decode(sToken, INetURLObject::DecodeMechanism::Unambiguous, RTL_TEXTENCODING_UTF8);
In document.xml, the these are the related xml tags: <w:bookmarkStart w:name="Els%C5%91" w:id="0"/> <w:instrText> REF Els%C5%91 \h </w:instrText>
Adam Kovacs committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/b9afb9959c31c3c57d0f2fe91107a92abfd82cdb%5E%21 tdf#113483: DOCX: fix encoding of bookmarks with non-ASCII letters It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified for DOCX. Backport to 6.2 wouldn't hurt, I guess. DOC is still wrong. Adam, could you handle DOC here or we should open a new one?
Timur: it's better a new bug report for the obsolete DOC, if it's really needed. We'll check the back-port, too. Thanks for the verification!