Bug 113623 - FILESAVE ODT: Error saving the document. Write Error. Error in writing sub-document styles.xml.
Summary: FILESAVE ODT: Error saving the document. Write Error. Error in writing sub-do...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha1+
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisectRequest
: 113631 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-11-03 11:26 UTC by Telesto
Modified: 2018-08-09 15:30 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
TB39 20171101, SAL_LOG of Writer error crash on save (460.07 KB, application/x-zip-compressed)
2017-11-03 23:37 UTC, V Stuart Foote
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2017-11-03 11:26:59 UTC
Description:
Error saving the document. Write Error. Error in writing sub-document styles.xml.

Steps to Reproduce:
1. Open attachment 124534 [details] (bug 99416)
2. Save file as -> 

Actual Results:  
File won't save.  Write Error. Error in writing sub-document styles.xml.

Expected Results:
Normal saving..


Reproducible: Always


User Profile Reset: No



Additional Info:
Found in:
Version: 6.0.0.0.alpha1+
Build ID: 06cad1a9a42ea74434f9ed0e4027163d029eb4a1
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-11-02_23:40:06
Locale: nl-NL (nl_NL); Calc: CL


User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Comment 1 raal 2017-11-03 15:52:01 UTC
No repro; Version: 6.0.0.0.alpha1+
Build ID: c79467ba954987f1d239c594c1e1b3af3f5515f6
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk3;
Comment 2 Xisco Faulí 2017-11-03 16:57:31 UTC
I can't reproduce it in

Version: 6.0.0.0.alpha1+
Build ID: c79467ba954987f1d239c594c1e1b3af3f5515f6
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

nor in

Version: 6.0.0.0.alpha1+
Build ID: b03fe77699b1ad30a9441bd9b283f25579ac261e
CPU threads: 1; OS: Windows 6.1; UI render: default; 
Locale: fr-BE (es_ES); Calc: group

could you please try with a fresh profile?
Comment 3 V Stuart Foote 2017-11-03 21:15:17 UTC
*** Bug 113631 has been marked as a duplicate of this bug. ***
Comment 4 V Stuart Foote 2017-11-03 21:17:14 UTC
With 2017-11-03 TB42 64-bit Windows build, getting a save error with Writer documents.

"Write Error.
Error in writing sub-document styles.xml"

Build has no issue saving from Calc, Impress, Draw or Formula editor. Just from Writer with error as above.


=-testing-=
On Windows 10 Home 64-bit en-US with
Version: 6.0.0.0.alpha1+ (x64)
Build ID: 8c374022790b54834fa54615e1953c8ee30641a8
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2017-11-03_01:58:27
Locale: en-US (en_US); Calc: group
Comment 5 V Stuart Foote 2017-11-03 21:26:31 UTC Comment hidden (obsolete)
Comment 6 V Stuart Foote 2017-11-03 23:37:29 UTC
Created attachment 137511 [details]
TB39 20171101, SAL_LOG of Writer error crash on save

So went back to the 2017-11-01 TB39 x86 build--dae6ba564fcf20299b7a560aeb346efc84364d41, and this issue was already present.

Attaching SAL_LOG, sorry for the the OpenGL Info noise.
Not sure what it means but this looks to be the failing sequence...

line 82368 --> SfxDocumentEvent: OnSaveAs

line 83245 --> SwXMLWriter::WriteThroughComponent: stream settings.xml 

line 83261 --> SwXMLWriter::WriteThroughComponent: stream styles.xml

line 83275 --> com.sun.start.comp.Writer.XMLOasisStylesExporter

line 83623 --> saxwriter.cxx:128 cached Sequence not written

line 83983 --> SfxDocumentEvent: OnSaveAsFailed

line 85838 get the painting for the Error Box, at line 85885.
Comment 7 V Stuart Foote 2017-11-04 15:17:04 UTC
OK, so working with TB42 builds, narrow it down to between 2017-10-30 and 2017-10-31 

https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=d30522e46ca884e9bc74af21711d9537e8118859..13c5dd1d98a480cb01ca8f24242c80e326e4ade8

But, is resolved today with:
Version: 6.0.0.0.alpha1+ (x64)
Build ID: d8f0e4144d51ff5709d005d289d71aa32f323913
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2017-11-04_01:29:18
Locale: en-US (en_US); Calc: group

Which makes the table style work on bug 101349 suspect.

https://gerrit.libreoffice.org/#/c/43986
https://gerrit.libreoffice.org/#/c/44256

@Telsto -- is the Windows bibisect granular enough to identify specific commit?
Comment 8 V Stuart Foote 2017-11-06 18:47:13 UTC
@Telesto, able to bibisect? Or should we just close...

@Heiko, please be careful with additional work on the table style for bug 101349, at least poke this issue so we know to check.
Comment 9 Telesto 2017-11-06 19:19:36 UTC
(In reply to V Stuart Foote from comment #8)
> @Telesto, able to bibisect? Or should we just close...
> 
> @Heiko, please be careful with additional work on the table style for bug
> 101349, at least poke this issue so we know to check.

I'm having some issues with the bibisect repro...
Comment 10 V Stuart Foote 2017-11-07 02:48:09 UTC
(In reply to V Stuart Foote from comment #8)

> @Heiko, please be careful with additional work on the table style for bug
> 101349, at least poke this issue so we know to check.

The revised copy of table styles went in and is not causing a problem with ODT saves on Windows.

https://gerrit.libreoffice.org/#/c/44381/
Comment 11 V Stuart Foote 2017-11-07 02:54:31 UTC
This looks to have been helpful as well...

https://gerrit.libreoffice.org/#/c/44254/
Comment 12 Heiko Tietze 2017-11-07 08:08:03 UTC
(In reply to V Stuart Foote from comment #11)
> This looks to have been helpful as well...
> 
> https://gerrit.libreoffice.org/#/c/44254/

This patch provides cross-platform compatibility for the binary table style format, and eventually the new set of TS thereby. But anyway, it's not a final design as TS requires XML serialization.
Comment 13 Timur 2017-12-18 10:13:59 UTC
Does this makes sense to stay open? It happens sometimes. 
There's Bug 112405 for 5.4.1 and colleague of mine reported the same for 5.3.7.
Comment 14 Telesto 2017-12-18 16:49:27 UTC
@Timur
Thanks for the reminder. Closing as WFM; issue is gone..

@V Stuart
Is a reverse bibisect still needed?
Comment 15 V Stuart Foote 2017-12-18 17:41:48 UTC
(In reply to Telesto from comment #14)
> @V Stuart
> Is a reverse bibisect still needed?

No, I think Michael S. had helped Heiko through the table auto format structural issues for doing styles. So resolved without needing more precise bibisect.