Description: If you set the direction of a comment (in a docx-imported file) from LTR to RTL, then save, close the file, and reopen - the direction seems to be reverse - RTL. Steps to Reproduce: See above Actual Results: Direction of words gets reversed Expected Results: Direction shouldn't be reversed Reproducible: Always User Profile Reset: No Additional Info: Linux Mint 18.3, LO 6.0.0.beta2 User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
I confirm it with Version: 5.4.4.2 (x64) Build-ID: 2524958677847fb3bb44820e40380acbe820f960 CPU-Threads: 4; BS: Windows 6.19; UI-Render: Standard; Gebietsschema: it-IT (de_DE); Calc: group
Bug still manifests with: Version: 6.1.1.2 Build ID: 5d19a1bfa650b796764388cd8b33a5af1f5baa1b CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; Locale: en-GB (en_GB.UTF-8); Calc: group threaded
In fact, the bug applies more generally than I had previously thought - it doesn't require importing a DOCX: 1. Create a new Writer document 2. Make sure the default style's direction is LTR 3. Type in some text (doesn't really matter, you could just comment on an empty paragraph, but to be nice.) 4. Insert a comment with a single paragraph of text - enough text to require multiple lines in the comment box 5. Set the comment box paragraph's direction to RTL, manually 6. Save as DOCX 7. Close the document 8. Open the file you just saved The comment will have LTR direction. If you do this via an ODT rather than a DOCX (in step 6) you won't get this bug.
Created attachment 144958 [details] A document for reproducing the bug The bug doesn't manifest by loading this document; you need to take the last several steps of the reproduction instructions: 5. Set the comment box paragraph's direction to RTL, manually 6. Save as DOCX 7. Close the document 8. Open the file you just saved And you'll see the bug.
Dear Eyal Rozenberg, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
I am experiencing this bug EVERY SINGLE DAMN DAY (!) ... comment direction setting is currently _the_ most annoying broken LO RTL issue AFAIC. Seeing this right now with: Version: 6.3.1.2 Build ID: 1:6.3.1-1 CPU threads: 4; OS: Linux 5.2; UI render: default; VCL: gtk3; Locale: he-IL (en_IL); UI-Language: en-US Calc: threaded
*** Bug 142518 has been marked as a duplicate of this bug. ***
Created attachment 180947 [details] bug_114734_msWord2003.docx: contains <w:bidi/> in comment.xml Yes, DOCX has the ability to render this. I had to use MS Word 2003 to modify the example file. So LO fails in both import and export to handle bidi in comments.
Import exception writerfilter/source/dmapper/DomainMapper_Impl.cxx:2550: finishParagraph() com.sun.star.beans.UnknownPropertyException message: "Unknown property: ParaStyleName at /persistent/git/libreoffice2/editeng/source/uno/unotext.cxx:1980" Also - watch out that you aren't bitten by Left/Right justify changes... For export, we currently don't export any paragraph properties in WriteOutliner (aka draw stuff) in any of DOC/RTF/DOCX.
(In reply to Justin L from comment #9) > Also - watch out that you aren't bitten by Left/Right justify changes... Well, if I saved something to a DOCX a certain way, I should just get it the same way when I load... but perhaps I'm not following you? > For export, we currently don't export any paragraph properties in > WriteOutliner (aka draw stuff) in any of DOC/RTF/DOCX. I'm pretty much clueless about the file formats. What kind of "draw stuff" are you not exporting? It seems to me like most things do get exported. Again, sorry for being dense; please try giving me the newbie explanation here.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cf02b94bc513ee1b742b4c5d7174632b568e8b72 tdf#114734 writerfilter: avoid PostIt exception It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Commit Notification from comment #11) > Comments (aka AnnotationMarks) cannot contain > a paragraph style. The exception was causing > all properties to be dropped. So, I saw you add an "in comments" condition in a few places. Does that mean that, now, comments _can_ contain a paragraph style? If not, I don't quite see how your commit only affects direction. > IIRC, LO interally always refers to justify literally, > while DOCX normally depends on the RtL context, > treating LEFT as START and RIGHT as END. See also my bug 131192 about Left/Right vs Start/End.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a73daa562c82a5c058a217ba80035da08d40451d tdf#114734 docx export: save comment paragraph properties It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
VERIFED with Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 4827d5cb1508f6bca9489e31b877cfff36393c50 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL Justin, thank you for fixing it!
(In reply to Commit Notification from comment #13) > Justin Luth committed a patch related to this issue. > It has been pushed to "master": > > https://papas-freezeria.com/ > a73daa562c82a5c058a217ba80035da08d40451d > > tdf#114734 docx export: save comment paragraph properties > > It will be available in 7.5.0. > > The patch should be included in the daily builds available at > https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More > information about daily builds can be found at: > https://wiki.documentfoundation.org/Testing_Daily_Builds > > Affected users are encouraged to test the fix and report feedback. it's pretty good
*** Bug 136041 has been marked as a duplicate of this bug. ***
(In reply to Eyal Rozenberg from comment #10) > > For export, until comment 13 we did't export any paragraph properties in > > WriteOutliner (aka draw stuff) in any of DOC/RTF/DOCX. > > I'm pretty much clueless about the file formats. What kind of "draw stuff" > are you not exporting? Please try giving me the newbie explanation here. Most things (paragraph properties/styles/objects) are handled directly by Writer (sw) code. But a few things (most prominently comments, textboxes, shapes) are handled by Draw/Impress (editeng) code. So these are always special cases that need to be handled separately, and will have bugs/different capabilities/handling than other aspects of a text document. (In reply to Eyal Rozenberg from comment #12) > > Comments (aka AnnotationMarks) cannot contain a paragraph style. > > The exception was causing all properties to be dropped. > > Does that mean that, now, comments _can_ contain a paragraph style? No, not a style. AFAIK, EDITENG has no access to SW style information, so RTL and other character/paragraph properties can only be applied via direct formatting.
(In reply to Justin L from comment #17) Since the bug has been fixed for two years, I'm guessing you're replying to be more informative for future readers, and myself, so first - thanks :-) > (In reply to Eyal Rozenberg from comment #10) > > > Comments (aka AnnotationMarks) cannot contain a paragraph style. > > > The exception was causing all properties to be dropped. > > > > Does that mean that, now, comments _can_ contain a paragraph style? > No, not a style. AFAIK, EDITENG has no access to SW style information, so > RTL and other character/paragraph properties can only be applied via direct > formatting. I should mention textboxes can contain paragraph and other styles in ODF... but indeed, it seems LO doesn't let us use this capability at all, for now. Let me drop some relevant links here: * Bug 111921: Support Paragraph Styles on the Text inside of Textboxes; blocking * Bug 163245: Can't apply Character, Paragraph and List Styles within a textbox in Writer * Bug 152653: Introduce proper Paragraph Style support in Impress/Draw