Bug 115550 - Wrong place for border of images, should rotate at image, but is at edge of bounding box
Summary: Wrong place for border of images, should rotate at image, but is at edge of b...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha0+
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: implementationError
: 120989 (view as bug list)
Depends on:
Blocks: Writer-Images Borders Regress-Rotated-Images
  Show dependency treegraph
 
Reported: 2018-02-08 15:02 UTC by Regina Henschel
Modified: 2024-03-06 15:05 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
Test case for rotating (84.42 KB, application/vnd.oasis.opendocument.text)
2018-03-04 17:46 UTC, Buovjaga
Details
Screenshot (58.77 KB, image/png)
2021-07-31 11:07 UTC, Regina Henschel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2018-02-08 15:02:51 UTC
If an image has a border and the image is rotated with wrap setting "parallel" (="square" in Word UI, or "Page Wrap" in context menu), then the border is not drawn around the image but at the edge of the bounding box. That is unexpected behavior, because graphic images and other word processing applications have the border at the image, which means the border is rotated too.
Comment 1 Buovjaga 2018-03-04 17:46:12 UTC
Created attachment 140336 [details]
Test case for rotating

Repro.

Arch Linux 64-bit
Version: 6.1.0.0.alpha0+
Build ID: 13164cc99dc6184fb2c12e56e9c0dea0d5692eec
CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on March 4th 2018
Comment 2 Buovjaga 2018-03-04 17:47:13 UTC
Let's ask what Armin thinks.
Comment 3 Fernando 2018-09-16 07:13:56 UTC
I noticed this behavior recently. 

Also, if you create a Google Doc's Text Document and insert the image there, add a border to it, rotate the image, download the document as an odt file and open it on LibreOffice, Writer will be able to add/remove the image's border, and the border will rotate with the image. Rotation will behave better too.

Steps to reproduce:
 - Create an empty Google Docs text document
 - Insert an image, and then select it
 - Add a border to the image (By clicking the 'border color' item on the toolbar)
 - Rotate the image to any arbitrary degree
 - Go to "File->Download as->Open Document Format (.odt)"
 - Save the file to disk
 - Open the file with LibreOffice Writer
 - Now rotate the image and/or add/remove the border. You will notice Writer does a good job rotating the border together with the image.
 - Now go to Insert->Image and insert another image (or the same if you have it locally) to the document.
 - Add a border to the recently inserted image.
 - Rotate the recently inserted image. You will notice Writer Does not rotate the border together with the image as this bug reports.

Note 1: The context menu for the two objects are different.
Note 2: When the google doc's exported image is selected Writer will show the 'Drawing Object Properties' toolbar. When the Writer's inserted image is selected then the 'Image' and 'Frame' toolbars are shown. The border for the writer's inserted image is controlled through the 'Frame' toolbar.
Comment 4 Cor Nouws 2019-02-09 20:40:40 UTC
I would swear I heard Armin talk about this during his presentation on developing the feature.. But details.. :) ?
Comment 5 QA Administrators 2021-02-09 05:09:11 UTC Comment hidden (obsolete)
Comment 6 BogdanB 2021-07-31 08:14:20 UTC Comment hidden (obsolete)
Comment 7 Regina Henschel 2021-07-31 11:07:49 UTC
Created attachment 173995 [details]
Screenshot

The error still exists. Screenshot is from current master. I have set the border to red, so that it is better visible.
Comment 8 BogdanB 2021-07-31 11:17:03 UTC
Ok confirm still exists with
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 5aa74aa1e6fac571f99146ebcb6adc9feb1459ad
CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-07-28_19:35:14
Calc: threaded

I was rotating by 90.
Comment 9 Gabor Kelemen (allotropia) 2022-03-06 17:54:43 UTC
This behavior started in 6.0 with commit:

https://git.libreoffice.org/core/+/a42b0985c7619efdc934bb1cf19e5e2c2b6faea2

author	Armin Le Grand <Armin.Le.Grand@cib.de>	Fri Sep 22 15:28:33 2017 +0200
committer	Armin Le Grand <Armin.Le.Grand@cib.de>	Fri Oct 20 14:13:20 2017 +0200

RotGrfFlyFrame: Initial adaptions

With the first implementation of arbitrary rotation of images. Before only 90/180/270 degrees rotation was possible and those options still behave correctly.
Comment 10 Gabor Kelemen (allotropia) 2022-03-07 12:32:00 UTC
*** Bug 120989 has been marked as a duplicate of this bug. ***
Comment 11 Sophie Sipasseuth 2024-03-06 15:05:36 UTC
Repro with this version of LibreOffice:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: fc9c15ec702d8a06e8747ee5b858751e5a90e30a
CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: fr-FR (fr_FR); UI: en-US
Calc: threaded