Description: Windows bitmap must be 32-bit aligned (cf http://www.fileformat.info/format/bmp/egff.htm - “Pixels are packed into bytes and arranged as scan lines. Each scan line must end on a 4-byte boundary, so one, two, or three bytes of padding may follow each scan line.”). Our OpenGL and OS X implementations don’t honour this (see https://opengrok.libreoffice.org/xref/core/vcl/opengl/salbmp.cxx#772 and https://opengrok.libreoffice.org/xref/core/vcl/quartz/salbmp.cxx#317). In fact, our test code notes this also - see https://opengrok.libreoffice.org/xref/core/vcl/qa/cppunit/BitmapTest.cxx#334 I’m logging this as a bug I’ll need to fix when I get back from holidays. Steps to Reproduce: n/a Actual Results: n/a Expected Results: n/a Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (iPad; CPU OS 11_2_6 like Mac OS X) AppleWebKit/604.1.34 (KHTML, like Gecko) CriOS/64.0.3282.112 Mobile/15D100 Safari/604.1
Good luck with it Chris, let us know if it needs testing...
I’ll add some unit tests, the only user testing is to insert some bitmaps into documents on OS X systems, and systems that use OpenGL. But it’s largely something that is not user visible.
Proposed patch is now on gerrit: https://gerrit.libreoffice.org/#/c/51222/
Chris Sherlock committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=460f39e687393b3a8906d2adc3e8f7a0c749851a tdf#116213 OS X and OpenGL bitmap scaline sizes are not 32-bit aligned It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
For QA: I opened a number of PNG images, including a 7x3 PNG, to see if everything worked alright, also checked toolbars and other UI elements.
Created attachment 140699 [details] Splash screen This is what the splash screen looks like for me in a recent master build (e08e6516a01f28f2dd2581e3326be6d6b6eddb55) / Windows 7, with OpenGL enabled. Some toolbar icons, and the document previews in the start center are also messed up. Reverting 460f39e687393b3a8906d2adc3e8f7a0c749851a fixes this issue for me.
On both my Nvidia gtx 650 and Intel HD 5000, all bitmaps are corrupted. See Bug 116484 for a test document.
Stephan Bergmann committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ebe247642d85d39b6e1ffae3cf92c31748f2e983 Revert "tdf#116213 OS X and OpenGL bitmap scaline sizes are not 32-bit aligned" It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
*** Bug 116484 has been marked as a duplicate of this bug. ***
Since the commit has been reverted, I'm closing bug 116484 as a duplicate of this one. @Chris, If you submit a new patch, please make sure bug 116484 isn't introduced again...
*** Bug 116551 has been marked as a duplicate of this bug. ***
I have tested with Version: 6.1.0.0.alpha0+ (x64) Build ID: 751191ed2d7d6af6eddc3d738e8c45b0a2ab2572 CPU threads: 4; OS: Windows 10.0; UI render: GL; TinderBox: Win-x86_64@42, Branch:master, Time: 2018-03-22_00:36:35 Locale: de-DE (de_DE); Calc: CL and using OpenGL for all rendering all test cases described in Bug 116551: Problem did not occur! All pictures were displayed correctly.
Thanks folks, I tested in debug mode on OS X, it appears this is why things weren’t picked up. Of course, don’t understand the comment “And why would fixing tdf#116213 for Windows require touching the macOS-specific code, anyway?” - not sure what this means, given Windows bitmap padding isn’t a bug, it’s part of the Bitmap specification.
Dear Chris Sherlock, This bug has been in ASSIGNED status for more than 3 months without any activity. Resetting it to NEW. Please assigned it back to yourself if you're still working on this.
Dear Chris Sherlock, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Chris, Polite ping. What is the status of this issue?
Let's leave this one.