Bug 116629 - notebookbar hide arrow
Summary: notebookbar hide arrow
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.3.0
Keywords:
Depends on:
Blocks: 122248 122255
  Show dependency treegraph
 
Reported: 2018-03-25 20:44 UTC by andreas_k
Modified: 2019-05-16 07:43 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
hide arrow for standard toolbars and notebookbar (32.84 KB, image/jpeg)
2018-03-25 20:44 UTC, andreas_k
Details
Add an icon to the arrow (137.89 KB, image/jpeg)
2019-04-30 15:32 UTC, andreas_k
Details

Note You need to log in before you can comment on or make changes to this bug.
Description andreas_k 2018-03-25 20:44:12 UTC
Created attachment 140879 [details]
hide arrow for standard toolbars and notebookbar

can we change the hide arrow from notebookbar to the same style than the default toolbar (double arrow)
Comment 1 Kshitij 2018-03-26 00:31:11 UTC
Hide arrow is set to NEXT symbol type in PriorityMergedHBox.cxx.
I searched for the other symbols in class symboltype
enum class SymbolType : sal_uInt16
{
    DONTKNOW         = 0,
    IMAGE            = 1,
    ARROW_UP         = 2,
    ARROW_DOWN       = 3,
    ARROW_LEFT       = 4,
    ARROW_RIGHT      = 5,
    SPIN_UP          = 6,
    SPIN_DOWN        = 7,
    SPIN_LEFT        = 8,
    SPIN_RIGHT       = 9,
    FIRST            = 10,
    LAST             = 11,
    PREV             = 12,
    NEXT             = 13,
    PAGEUP           = 14,
    PAGEDOWN         = 15,
    PLAY             = 16,
    STOP             = 19,
    CLOSE            = 25,
    ROLLUP           = 26,
    ROLLDOWN         = 27,
    CHECKMARK        = 28,
    RADIOCHECKMARK   = 29,
    FLOAT            = 31,
    DOCK             = 32,
    HIDE             = 33,
    HELP             = 34,
    PLUS             = 35,
    MENU             = SymbolType::SPIN_DOWN
};

No symbol was matching(looks alike) to double arrow. So, I guess it cannot be changed directly.
Comment 2 V Stuart Foote 2018-03-26 16:24:44 UTC
Reasonable, but for LO toolbars the double >> signifies that additional toolbar items are available; while the rotated triangle is to expose/hide additional items. It is only when the Notebookbar UI is reduced in width and the content is hidden (with the triangle icon now) that the >> icon would be appropriate.

=> NEW
Comment 3 andreas_k 2018-12-08 23:38:32 UTC
any idea how to fix this bug?
Comment 4 andreas_k 2019-04-30 15:32:04 UTC
Created attachment 151096 [details]
Add an icon to the arrow

is it possible to add an icon to the > arrow. This will help to click it (which is now very difficult, cause the > is very tiny) and as MSO use it in there 2019 implementation users will know how it work.

Let me know if it's possible, dan I will add the icon. I think 14x16 px size will be ok.
Comment 5 Szymon Kłos 2019-05-08 09:48:58 UTC
Yes, it is possible to insert an icon in a button. Nice easy hack for a GSoC warmup and become familiar with simple widgets. Added Sumit to CC :)

Code Pointers:
https://opengrok.libreoffice.org/xref/core/include/vcl/button.hxx?r=ed901c33#80
Button has some methods to setup image inside.

Examples of usage:
https://opengrok.libreoffice.org/xref/core/sfx2/source/sidebar/TabBar.cxx?r=01757656#69

https://opengrok.libreoffice.org/xref/core/sfx2/source/dialog/dinfdlg.cxx?r=da92911d#1398
Comment 6 Commit Notification 2019-05-09 21:53:19 UTC
andreas kainz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/425a570a114d9a087e5320f071604f64d43fcec1%5E%21

tdf#116629 add chevron icon for notebookbar hide button

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 andreas_k 2019-05-09 22:05:42 UTC
this is where the chevron was drawn for toolbars best would be to use this for draw the chevron also in notebookbars.

https://opengrok.libreoffice.org/xref/core/vcl/source/window/toolbox.cxx?r=3f6fcaa9#2409
Comment 8 Commit Notification 2019-05-10 10:06:42 UTC
Sumit Chauhan committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/96dd1cd36c2f9446d3455a06b5f77a3954950c03%5E%21

tdf#116629 added chevron icon for noteboookbar hide button

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Szymon Kłos 2019-05-16 07:42:16 UTC
@andreas_k can be closed now?