Bug 116757 - Track Changes should be able to show original document
Summary: Track Changes should be able to show original document
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.0.2.1 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:7.2.0
Keywords: needsDevEval
: 136090 (view as bug list)
Depends on:
Blocks: Track-Changes
  Show dependency treegraph
 
Reported: 2018-04-02 15:08 UTC by Mike Sapsard
Modified: 2023-09-08 07:16 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot of the new feature "Show Insertions in Margin" and the new menu of Show Changes icon (87.52 KB, image/png)
2021-01-20 18:17 UTC, László Németh
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Sapsard 2018-04-02 15:08:40 UTC
When editing, Writer allows Track Changes to be turned on or off. It also allows changes to be accepted or rejected. Unlike Word it does not allow the document before changes to be viewed.

These are Word options. The last one is not available in Writer.
Final: Show Markup shows all tracked changes.
Final hides tracked changes to show the document with all proposed changes included.
Original: Show Markup shows the original text with tracked changes and comments.
Original shows the document before any changes were made.
Comment 1 Mike Sapsard 2018-04-03 07:59:02 UTC
Would it also be possible to have an option that just placed a vertical side bar next to changes, without highlighting the changes in the text. This would allow layout and text flow consequences to be inspected.

An option to make such side bars to be printable or not would also be useful for editors.
Comment 2 Heiko Tietze 2018-04-03 08:56:10 UTC
Sounds like a reasonable enhancement. 

Today we have View > Track Changes that shows the modifications when checked (option #1) or just the result (option #2). The checkbox has no effect when no changes have been made. 

We could go with radio buttons 
Track Changes >
 ( ) Original (layout before the changes)
 (o) Modifications (as today with show TC checked)
 ( ) Final (as today with show TC unchecked)

Was thinking about a checkbox that enables these options but it makes not much sense to have [x] Show Track Changes with (o) Original below.

And I don't see the need for the option original with modifications as this just "underlines" the other part, which probably ends up in severe confusion what option is active.

Weird effect of this new option is that changing the text with TC active and "original" set would have no effect anymore - you do not see what you type. As a counter measure we could automatically switch to "modification" when TC is enabled.
Comment 3 Mike Sapsard 2018-04-03 09:56:32 UTC
If the toolbar had radio buttons:
Track changes>
o Show all changes
o Show deletions only
o Show additions only
o Show original (Read only)

it should work. It would allow people to quickly view changes in different ways.
Comment 4 Heiko Tietze 2018-04-03 10:10:41 UTC
(In reply to Mike Sapsard from comment #3)
> If the toolbar had radio buttons:
> Track changes>
> o Show all changes
> o Show deletions only
> o Show additions only
> o Show original (Read only)
> 
> it should work. It would allow people to quickly view changes in different
> ways.

Too complicated in my opinion, no clear use case (why should I want to see only deletions), and workaround is the list of TC that has a good indicator for the types.
Comment 5 Mike Sapsard 2018-04-04 08:37:04 UTC
I agree that When working alone on a small document, it would rarely be used.

However, consider your commercial customer base. I suggest you also ask for the opinions of a few people who work on very large documents (several hundred pages) with several editors, and strict deadlines.
Comment 6 Timur 2020-09-21 13:52:33 UTC
*** Bug 136090 has been marked as a duplicate of this bug. ***
Comment 7 Commit Notification 2021-01-20 18:08:37 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6aeeef8807fef36295b65d0a300a21466bfbeda0

tdf#116757 sw ChangesInMargin: add "Show Insertions in Margin"

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 László Németh 2021-01-20 18:14:20 UTC
tdf#116757 sw ChangesInMargin: add "Show Insertions in Margin"

layout mode to allow to show the original text inline,
i.e. only deletions, while insertions are showed in margin
(opposite of the Show Deletions in Margin mode).

Add a menu to the Show Changes icon on the
Changes toolbar with menu items for the 3 layout modes
"All Changes Inline", "Deletions in Margin" and
"Insertions in Margin" with the following behavior:

– Selecting a menu item turns on also the Show Changes mode
  to show the result immediately;

– Disabling Show Changes mode always show the final text, i.e.
  only insertions. Enabling Show Changes mode again shows the
  changes according to the last Show Changes mode selected in
  the menu.

– The new "Insertions in Margin" mode is intended to be only a
  run-time option, i.e. it's not possible to set it as a default
  Show Changes mode in Options, unlike "Deletions in Margin".
Comment 9 László Németh 2021-01-20 18:17:16 UTC
Created attachment 169058 [details]
screenshot of the new feature "Show Insertions in Margin" and the new menu of Show Changes icon

Note: the "In" will be lowered in "Deletions In Margin" and "Insertions In Margin". Also it would be fine to fix the missing radio button...
Comment 10 Timur 2021-01-20 19:43:09 UTC
This work complements great feature of bug 34355 (candidate for a backport).
Latee should be in https://wiki.documentfoundation.org/ReleaseNotes/7.1 (I'm away from computer and cannot do it myself).
Comment 11 László Németh 2021-01-22 11:25:08 UTC
(In reply to Timur from comment #10)
> This work complements great feature of bug 34355 (candidate for a backport).
> Latee should be in https://wiki.documentfoundation.org/ReleaseNotes/7.1 (I'm
> away from computer and cannot do it myself).

@Timur: Indeed. Unfortunately, it contains new strings, not only a new feature, so likely it's too late for a back port. Thanks for your feedback!
Comment 12 NISZ LibreOffice Team 2021-02-08 11:32:30 UTC
Verified in
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 44b914b1e2616ca8f70e896e653a46ca93610234
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded