Bug 117120 - Firebird Migration: Add 'Don't ask again' option to the migration dialog
Summary: Firebird Migration: Add 'Don't ask again' option to the migration dialog
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha0+
Hardware: All All
: high enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Database-Firebird-Migration Supress-migration-dialog
  Show dependency treegraph
 
Reported: 2018-04-20 08:34 UTC by Xisco Faulí
Modified: 2018-11-21 17:25 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
Save dialog with the option (15.14 KB, image/png)
2018-04-20 08:34 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2018-04-20 08:34:49 UTC
Created attachment 141498 [details]
Save dialog with the option

Steps to reproduce:
1. Open attachment 141320 [details] from bug 116980
2. Select 'later' when the migration dialog prompts.
3. Close the file
4. Repeat the previous steps

Observed behaviour: Every time the file is open, the migration dialog is prompted.

Expected behaviour: There should be a 'Don't ask again' checkbox as when LibreOffice saves to other formats different than ODF

Reproduced in

Version: 6.1.0.0.alpha0+
Build ID: cb5f6503f593d7c7a719542281b9efd274134f7c
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group
Comment 1 V Stuart Foote 2018-04-20 12:51:32 UTC
Going forward, the pop-up conversion will become tedious for those not ready to migrate.

Expect it would be set per document and recorded per document to user profile.

Once a decision has been made per document, suppressing the "offer" to migrate with a 'Don't ask again' checkbox is as appropriate as having backed out the automatic migration.

Needed for the duration of the transition off HSQLDB.
Comment 2 Robert Großkopf 2018-07-27 06:16:50 UTC
Don't know if we should say this is importance "medium" and "enhancement". I con't decide this, but for me it is "high" and "major". The migration will come with the following behavior:
Dialog will appear every time you open a database for internal HSQLDB and switch to the tables.
If pressing "Yes" dataloss in most of the databases will be the "normal" behavior. Forms with subforms won't work (bug117589).
This is totally unusable for normal working with databases. It is only experimental.
Everybody who asks me (as author of the German Base-Handbuch) I have answered: Please don't use LO 6.1 together with internal databases. I couldn't help you to get a working migrated database afterwords.
Comment 3 Robert Großkopf 2018-07-27 07:25:27 UTC
(In reply to robert from comment #2)

Have reset my user-profile after testing with another PC. The dialog doesn't appear any more with a new user-profile and LO 6.1.0.2 on OpenSUSE 42.3 64bit rpm Linux.
Comment 4 Xisco Faulí 2018-07-27 08:24:16 UTC
(In reply to robert from comment #3)
> (In reply to robert from comment #2)
> 
> Have reset my user-profile after testing with another PC. The dialog doesn't
> appear any more with a new user-profile and LO 6.1.0.2 on OpenSUSE 42.3
> 64bit rpm Linux.

If you reset the user profile, the option 'Experimental feature' get disabled. You have to enable it again to see the dialog...
Comment 5 Xisco Faulí 2018-11-21 15:06:05 UTC
*** Bug 121587 has been marked as a duplicate of this bug. ***
Comment 6 Thomas Krumbein 2018-11-21 15:35:18 UTC
sorry, it doesn´t help just to close the bug and explain, it is just a duplicate.

And yes, same problematic, but different aspect:

Description:
using a base hsqldb file as a data source causes a pop-up message "Confirm Migration". 
This may be ok, if a user open a base file first time, but unfortunartly this massage appears every time, when you call a connection via macro.

macro stops at this moment and it is never a good idea, when users will migrate at this time!

Remove this message imitatively! 


Steps to Reproduce:
1. register a base file with hsqldb as darta-source

2. write a macro, with uses data out of the database. therefor connect to database 
   
Function knp_getConnection_BaseDok
  Dim oDBC As Variant
  Dim oDataSource As Variant
On Error Goto Fehler:
  oDBC = createUnoService("com.sun.star.sdb.DatabaseContext")
  oDataSource = oDBC.getByName("NameofDataSource")
  knp_getConnection_BaseDok = oDataSource.getConnection("","")
Fehler:
End Function

3. run macro - 

Actual Results:
popup message appears at every connection call and every data-transfer

Expected Results:
no popup at all!!


Reproducible: Always
Comment 7 Thomas Krumbein 2018-11-21 15:37:41 UTC
And:

This is NOT an enhancement. It is a critical bug!

All programmed macro-applications which uses a datasource based on a HSQLDB Base File is broken!!
Comment 8 Thomas Krumbein 2018-11-21 15:40:14 UTC
Hmm, I am not allowed to change priority.... so someone has do do this with more rights.

Hopeful someone is a practical person and knows how LO is used in productivity outside....
Comment 9 Drew Jensen 2018-11-21 17:17:20 UTC
(In reply to Thomas Krumbein from comment #8)
> Hmm, I am not allowed to change priority.... so someone has do do this with
> more rights.
> 
> Hopeful someone is a practical person and knows how LO is used in
> productivity outside....

First there will come a time, when the HSQL support is removed from LO, when this behavior will be appropriate.

For now though with HSQL support still in the package it is not a requirement. 

Offering to do so when an ODB is opened directly from Base IMO is a good nudge.

Offering the option on the prompt dialog to not do so again, I would assume this is a session only choice, keeps it unobtrusive.
Comment 10 Drew Jensen 2018-11-21 17:21:24 UTC
Changed importance to high. Given some other open issues at the moment this option to begin the migration assistant from outside of the Base module can leave the user in a precarious situation with this datasource requiring at a minimum they close the LO session completely and relaunch the application to get back the ability to work with the data inside.
Comment 11 Drew Jensen 2018-11-21 17:25:33 UTC
(In reply to Drew Jensen from comment #9)
> (In reply to Thomas Krumbein from comment #8)
> > Hmm, I am not allowed to change priority.... so someone has do do this with
> > more rights.
> > 
> > Hopeful someone is a practical person and knows how LO is used in
> > productivity outside....
> 
> First there will come a time, when the HSQL support is removed from LO, when
> this behavior will be appropriate.
> 
> For now though with HSQL support still in the package it is not a
> requirement. 
> 
> Offering to do so when an ODB is opened directly from Base IMO is a good
> nudge.
> 
> Offering the option on the prompt dialog to not do so again, I would assume
> this is a session only choice, keeps it unobtrusive.

I would add this that turning this feature, launching the MA from outside of Base, would be appropriate with the final release of LO which contains HSQL support, so the nudge to convert gets some umph behind it.