Bug 121587 - Base "Confirm Migration" message pops up everytime via macro
Summary: Base "Confirm Migration" message pops up everytime via macro
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
6.1.3.2 release
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Database-Firebird-Migration Database-Firebird-Migration-Dialog
  Show dependency treegraph
 
Reported: 2018-11-21 13:33 UTC by Thomas Krumbein
Modified: 2019-09-12 18:24 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Krumbein 2018-11-21 13:33:53 UTC
Description:
using a base hsqldb file as a data source causes a pop-up message "Confirm Migration". 
This may be ok, if a user open a base file first time, but unfortunartly this massage appears every time, when you call a connection via macro.

macro stops at this moment and it is never a good idea, when users will migrate at this time!

Remove this message imitatively! 


Steps to Reproduce:
1. register a base file with hsqldb as darta-source

2. write a macro, with uses data out of the database. therefor connect to database 
   
Function knp_getConnection_BaseDok
  Dim oDBC As Variant
  Dim oDataSource As Variant
On Error Goto Fehler:
  oDBC = createUnoService("com.sun.star.sdb.DatabaseContext")
  oDataSource = oDBC.getByName("NameofDataSource")
  knp_getConnection_BaseDok = oDataSource.getConnection("","")
Fehler:
End Function

3. run macro - 

Actual Results:
popup message appears at every connection call and every data-transfer

Expected Results:
no popup at all!!


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Xisco Faulí 2018-11-21 15:06:05 UTC Comment hidden (obsolete)
Comment 2 Xisco Faulí 2018-11-21 17:16:16 UTC Comment hidden (obsolete)
Comment 3 Xisco Faulí 2018-11-29 13:27:30 UTC
Let's keep it a new and block bug 121599
Comment 4 Tamas Bunth 2019-01-31 14:32:55 UTC
Hi,

So the expected result is no popup dialog.

There are still two alternatives:

- The migration assistant runs silently for all the HSQL databases it touches.

- No migration

Which one would be better?
Comment 5 Alex Thurgood 2019-01-31 15:13:50 UTC
(In reply to Tamas Bunth from comment #4)


> There are still two alternatives:
> 
> - The migration assistant runs silently for all the HSQL databases it
> touches.
> 
> - No migration
> 
> Which one would be better?


IMO, no migration. Someone who programs access to an hsqldb embedded ODB via macro programming could be said to be supposed to know that the move to Firebird as default is underway - thus, if the db hasn't yet been migrated, the macro developer has deliberately planned it that way, and decided to stick with hsqldb (at least until such time as they decide to migrate to Firebird out of choice and adapt the macro to deal with that). 

At worst, what happens if no migration occurs ? The user continues to be able to use the database as before, and the macro continues to work as planned by the original developer of the macro program.
Comment 6 Gerhard Weydt 2019-01-31 18:49:08 UTC
(In reply to Alex Thurgood from comment #5)
> (In reply to Tamas Bunth from comment #4)
> 
> 
> > There are still two alternatives:
> > 
> > - The migration assistant runs silently for all the HSQL databases it
> > touches.
> > 
> > - No migration
> > 
> > Which one would be better?
> 
> 
> IMO, no migration. Someone who programs access to an hsqldb embedded ODB via
> macro programming could be said to be supposed to know that the move to
> Firebird as default is underway - thus, if the db hasn't yet been migrated,
> the macro developer has deliberately planned it that way, and decided to
> stick with hsqldb (at least until such time as they decide to migrate to
> Firebird out of choice and adapt the macro to deal with that). 
> 
> At worst, what happens if no migration occurs ? The user continues to be
> able to use the database as before, and the macro continues to work as
> planned by the original developer of the macro program.

I fully agree. As long as important bug reports concerning the Firebird migration are still open, programmers must have the choice to use the old database where they can be sure their applications work. After the discussions we had a while ago, I am sure the decision to definitely migrate to Firebird will be taken only when these bugs have been resolved, then it will be quite safe to migrate the applications.
Comment 7 Xisco Faulí 2019-08-02 09:10:52 UTC
I think this is fixed by
https://gerrit.libreoffice.org/plugins/gitiles/core/+/77ef0a92b3bd19f836d0fcb2a41af5e643129283%5E%21, Could anyone confirm with a daily build containing the commit ?
Comment 8 Tamas Bunth 2019-09-12 18:24:58 UTC
I can confirm the bug is fixed. I move it to fixed.