1. open two new Calc documents 2. add some comment to any cell in one document 3. copy that cell to clipboard 4. close the document without saving 5. paste on any cell in the second document => crash This is almost identical to bug 104967 that was fixed by forgetting some caption details owned by the closed document, the crash is just some calls below ScPostIt::CreateCaption() now. However, in master/6.1 in ScDocument::~ScDocument() asking ScDocument::IsClipboardSource() returns false because in ScModule::GetClipDoc() SfxViewShell::Current() returns nullptr, which it didn't before. Some logic when view shells are destroyed seem to have changed meanwhile. The effect is that ClosingClipboardSource() is not called anymore and the caption and item set items are not forgotten and still point to drawing details of the already closed document. Hence, asking for bibisect to find the culprit.
Regression introduced by: author Henry Castro <hcastro@collabora.com> 2017-08-12 19:46:27 -0400 committer Henry Castro <hcastro@collabora.com> 2017-12-08 13:06:57 +0100 commit 1b7a8277aa3e9f73ccdf15e933a1ee3b42849a44 (patch) tree 64474c3499c36d31f0ea13d348245a6bea6abbe6 parent 630be5751029fc8ebf5a8784fb1c07894a0e1600 (diff) sc lok: 1 view has 1 clipboard to transfer data In tiled rendering case, each view copy and paste the contents of the clipboard associated with the view Bisected with: bibisect-linux64-6.1 Adding Cc: to Henry Castro
Thanks a lot! @Henry: can you fix that please?
Henry Castro committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a2e6f31c6f90e446d1462e7c80f6b1317f7825bc tdf#117228: crash in SfxItemSet::GetItemState... It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Fixes the copy case, but when the comment is visible (shown) in step #3 cutting the comment instead of copying then closing the document and pasting into another document still crashes. If you'd like to investigate that?
Sigh.. it also crashes if the original sequence is repeated, i.e. 1. open two new Calc documents 2. add some comment to any cell in one document 3. copy that cell to clipboard 4. close the document without saving 5. paste on any cell in the second document 6. create new third Calc document 7. copy cell from second document to clipboard 8. close second document 9. paste to third document => crash
Thanks. Oh Interesting ... I have to finish some javascript clean ups. I will work on it tomorrow :)
*** Bug 117545 has been marked as a duplicate of this bug. ***
*** Bug 117546 has been marked as a duplicate of this bug. ***
Hi Eike, Sorry I could not reproduce the crash. I have followed the steps, >> 8. close second document I tried: + saving the document. + creating 3 views with Window->New Window. + the steps of duplicate Bug 117545
Not new view windows, three Calc *documents*
I also tried creating documents. I was using File->New->Spreadsheet But I did reproduce https://bugs.documentfoundation.org/show_bug.cgi?id=117997 I think It should be related to this one.
I can't reproduce the steps from comment 5 Version: 6.1.0.0.beta1+ Build ID: 8b96445766efe237eb47608ade6c147673466e2e CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded
I still repro comment 1 (with a small tweak) 1. Open a Calc document (Document 1) 2. Insert a comment with some comment to - in my case - A1 3. Copy that cell to clipboard 4. Open a new calc document 5. Close Document 1 without saving 6. Paste in Document 2 -> Crash Version: 6.2.0.0.alpha0+ Build ID: 7530424771c84d50f1e7e9ec5eba0bffc91d655a CPU threads: 4; OS: Windows 6.3; UI render: default; TinderBox: Win-x86@42, Branch:master, Time: 2018-06-06_05:38:42 Locale: nl-NL (nl_NL); Calc: CL
(In reply to Telesto from comment #13) > I still repro comment 1 (with a small tweak) > > 1. Open a Calc document (Document 1) > 2. Insert a comment with some comment to - in my case - A1 > 3. Copy that cell to clipboard > 4. Open a new calc document > 5. Close Document 1 without saving > 6. Paste in Document 2 -> Crash Confirmed in Version: 6.1.0.0.beta1+ Build ID: 8b96445766efe237eb47608ade6c147673466e2e CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded
Hi, I submitted a patch to gerrit https://gerrit.libreoffice.org/#/c/55490/, according to my tests I got no more crash with tdf#117997 and tdf#117228. I will appreciate your help testing if there are more side effects Thanks
Henry Castro committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=b6b1ded0a0539e7be1b5338de378a3276a6ff445 sc: replace ScCaptionPtr with std::shared_ptr, tdf#117997, tdf#117228 It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Henry Castro committed a patch related to this issue. It has been pushed to "libreoffice-6-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ee7638061e787e6a1c37b2d3be1c14852cbc3381&h=libreoffice-6-1 sc: replace ScCaptionPtr with std::shared_ptr, tdf#117997, tdf#117228 It will be available in 6.1.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in Versión: 6.1.0.1 Id. de compilación: 378e26bd4f22a135cef5fa17afd5d4171d8da21a Subprocs. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; Configuración regional: es-ES (es_ES); Calc: group threaded @Henry, Thanks for fixing this!! Should it be closed as RESOLVED FIXED ?