Description: Add color drawing styles in Draw in addition existing styles Steps to Reproduce: 1. I want add color drawing styles in Draw in addition existing styles 2. 3. Actual Results: we have only old drawing styles in Draw from 199x Expected Results: now we'll have our old styles and additional nice color drawing styles for 2-D shapes Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
Created attachment 141925 [details] File ODG with new color drawing styles
Created attachment 141926 [details] Screenshot with color drawing styles
Should we change/add draw styles? Topic for the next weekly meeting.
I dislike to add more graphic styles to the default and would like to remove a lot of the existing ones. For example "title" is not needed. The needed styles for shapes depend on the used template and is related to the content of the presentation. So I would prefer to add suitable styles to the document templates and remove as much as possible from the default. The usage does not become easier with more styles. However, some users need assistance in creating styles that harmonize to each other and to the presentation object styles and the backgrounds. That does not only include colors but fonts too. So another idea can be, to provide a tool, that can change the basic styles all together to a selectable theme.
Support for themes and/or color schemes would be a huge improvement. Even for advanced users, built-in themes are a great as a starting point, and the ability to create your own would make it easier to keep templates for various kinds of documents in sync. It might be helpful to look at how MS Office does this. It's been several years since I've used it, but I remember in Powerpoint 2010 there was a drop-down that offered basic shapes with several colors and designs much like the attachments here, and several nice built-in color schemes. Word also provided several style sets for text with previews (which were rather ugly). I have no idea how these are implemented. In the case of LO drawing objects, I'm imagining a system where each main style come with several child styles, one for each theme color. Probably just 4-5 would be adequate for most uses. Then, changing the theme would change the colors (and perhaps other attributes) of these styles. Something like: - Object with fill 1 (main theme color) - Object with fill 2 - Object with fill 3 - Object with fill 4 - Object without fill 1 - Object without fill 2 ... I agree with Regina that the current built-in drawing styles need some cleanup, but unless ODF has some other provision for color schemes, I suspect something like this would be required.
Created attachment 142082 [details] Test for new styles of https://gerrit.libreoffice.org/#/c/54188/ I have tried the patch from https://gerrit.libreoffice.org/#/c/54188/. I see these problems: (1) Shapes, which have lighten and darken areas, lose these areas. That is not a problem of gradient or missing line, as you can see in the page, where I have applied gradients by toolbar. (2) If you open the file in an actual release version, the gradients are black to white. The reason is, that the needed draw:fill-gradient-name is missing in the style in the file.
(In reply to Regina Henschel from comment #6) > I see these problems: Thanks, looking into it. When I open the file with 6.0 it shows 'filled > filled_blue' in the styles list (coming from another source) while 6.1 has "Filled > Blue". Looks like more expertise is needed here.
Finished the second part. Opening a document with new gradient styles in 6.0 still fails. It works when the style is created manually (under Default). New style names are taken regardless it is used or not - and apply as black/white gradient. Asked Mike on IRC and he didn't see a problem skimming over the changes. Armin, Samuel: please help.
For problem (1) I have found, that it has nothing to do with the new styles, but it is already present in LO54. I will write a bug report for it.
Created attachment 142115 [details] Solution for missing gradient names @Heiko: Your gradients need names, see attached file. I have used a name, which does not need encoding. You should try, whether a name with space will work too. I suggest to use a name which contains the style name. You know, I'm not a experienced developer but a beginner. So I cannot guarantee, that the proposed solution is correct in all aspects. But in my test, the file format is correct now and LO6.0 shows no longer the default black/white gradient, but the green, specified one.
(In reply to Regina Henschel from comment #10) > @Heiko: Your gradients need names, see attached file. Yes, works like a charm now. Thanks for the dev advice :-)
(In reply to Regina Henschel from comment #9) > For problem (1) I have found, that it has nothing to do with the new styles, > but it is already present in LO54. I will write a bug report for it. So how do we proceed with the patch? +1 it on Gerrit, if you think the removed and added styles make sense. Otherwise we can still work on it.
I have set it already to +1 on Gerrit :). A short test of roundtrip with PowerPoint has no problems. So I think, it is ready to be pushed.
heiko tietze committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d30867653af6fa59a9221a2430c064a9ea903cc1 tdf#117455 - New drawing styles It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
verified in build from 17 April 2018
Is it possible to make legacy drawing styles as extension?
(In reply to Volga from comment #16) > Is it possible to make legacy drawing styles as extension? You can save new empty drawing from old version of LibreOffice as template and use it later for creating new drawing. It that template will be save all legacy drawing styles
(In reply to Volga from comment #16) > Is it possible to make legacy drawing styles as extension? No, the styles are hard-coded. So kompilainenn's workaround is your only chance to get back what I removed (hardly can think of why someone uses those styles).
*** Bug 94369 has been marked as a duplicate of this bug. ***