Bug 117826 - Area fill pattern is off (dashes at instead of solid horizontal lines) in Presentation mode with Skia or OpenGL
Summary: Area fill pattern is off (dashes at instead of solid horizontal lines) in Pre...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
6.1.0.0.beta1+
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Regressions-imageHandling Skia
  Show dependency treegraph
 
Reported: 2018-05-26 19:14 UTC by Telesto
Modified: 2020-09-02 01:15 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
Example file (45.42 KB, application/vnd.oasis.opendocument.presentation)
2018-05-26 19:14 UTC, Telesto
Details
Screenshot (39.61 KB, image/png)
2018-05-26 19:15 UTC, Telesto
Details
Viewing the example presentation in 6.1.0.0.beta1 (x64) (43.27 KB, image/png)
2018-05-28 19:10 UTC, Christoffer
Details
Bibisect log (2.91 KB, text/plain)
2018-05-30 16:19 UTC, Telesto
Details
Bibisect log (2.91 KB, text/plain)
2018-05-30 18:29 UTC, Telesto
Details
attachment 142298 open LO 6242 in Presentation mode w OpenGL (19.50 KB, image/png)
2019-07-06 15:05 UTC, V Stuart Foote
Details
open LO 6242 in Edit mode w OpenGL (18.01 KB, image/png)
2019-07-06 15:05 UTC, V Stuart Foote
Details
fill of smilly face eyes during presentation--Skia Vulkan (40.65 KB, image/png)
2020-09-02 01:14 UTC, V Stuart Foote
Details
fill of smilly face eyes during presentation -- default GDI (30.78 KB, image/png)
2020-09-02 01:15 UTC, V Stuart Foote
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2018-05-26 19:14:16 UTC
Description:
Pattern is off (dashes instead of horizontal lines) in Presentation mode with OpenGL

Steps to Reproduce:
1. Open the attached file
2. Start presentation mode (F5)

Actual Results:  
Dashes (and the smiley eyes aren't correct either)

Expected Results:
No dashes


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Version: 6.2.0.0.alpha0+
Build ID: 938ec2597be2e0ad3af2fb99f77de7f87285ad86
CPU threads: 4; OS: Windows 6.3; UI render: GL; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-05-25_23:38:38
Locale: nl-NL (nl_NL); Calc: CL


User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Comment 1 Telesto 2018-05-26 19:14:43 UTC
Created attachment 142298 [details]
Example file
Comment 2 Telesto 2018-05-26 19:15:52 UTC
Created attachment 142299 [details]
Screenshot
Comment 3 Roman Kuznetsov 2018-05-27 20:04:29 UTC
i don't look dashes, but eyes have some problems (less then you have)

LO 6.1 beta 1 Windows 10

regression?
Comment 4 Telesto 2018-05-27 20:34:30 UTC
(In reply to kompilainenn from comment #3)
> regression? 

Not sure about the regression keyword, it's also broken in 6.0. Only differently (pattern outside the shape).
Comment 5 Christoffer 2018-05-28 19:10:15 UTC
Created attachment 142355 [details]
Viewing the example presentation in 6.1.0.0.beta1 (x64)
Comment 6 Telesto 2018-05-30 16:19:09 UTC Comment hidden (obsolete)
Comment 7 Telesto 2018-05-30 18:21:34 UTC Comment hidden (obsolete)
Comment 8 Telesto 2018-05-30 18:25:05 UTC
(In reply to kompilainenn from comment #3)
> i don't look dashes, but eyes have some problems (less then you have)

Eye issue: bug 117910
Comment 9 Telesto 2018-05-30 18:29:58 UTC
Created attachment 142422 [details]
Bibisect log

I bisected the dashes to:
author	Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>	2018-03-31 17:27:01 +0900
committer	Tomaž Vajngerl <quikee@gmail.com>	2018-04-10 08:33:55 +0200
commit ea3d755ac949c1b6dada5c341e018f8c23f5d395 (patch)
tree 086b3573d3e2f64fd918df4996d1f00ad9aa863b
parent 94185507ed11bf6e2e2e9fa47c247680ae1edb36 (diff)
vcl: detach usage and remove GraphicManager and GraphicCache
Also remove some GraphicObjectTest because they call into
GraphicManager which now doesn't exist anymore.

The same commit causes a slowness for opening entering the presentation mode (6 seconds delay after the commit 2 seconds before.. Only with OpenGL enabled
Comment 10 Aron Budea 2018-06-11 00:10:27 UTC
Confirmed using LO 6.1 beta 1 / Windows 7.
Comment 11 Xisco Faulí 2018-06-12 15:34:11 UTC
Adding Cc: to Tomaž Vajngerl
Comment 12 QA Administrators 2019-06-13 03:00:37 UTC Comment hidden (obsolete)
Comment 13 Xisco Faulí 2019-07-06 13:00:06 UTC Comment hidden (obsolete)
Comment 14 V Stuart Foote 2019-07-06 14:27:17 UTC
Can not reproduce with Winodws 10 Home 64-bit en-US with Intel HD Graphics 620 (Driver Version	25.20.100.6519) with current master or with
Version: 6.2.4.2 (x64)
Build ID: 2412653d852ce75f65fbfa83fb7e7b669a126d64
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

Checked the graphic and Area fill _is_ set to Horizontal line. When rendered to editmode canvas the horizontal line fill shows. And when opened to presentation mode (laptop display) same horizontal line fill. That is with OpenGL rendering mode and default (GDI) with Hardware Acceleration or CPU only rendering.

In edit mode the eyes are also filled with the face's Horizontal lines, but expect that as the eyes are Z-order layer behind the face layer. The eyes have their own area fill, not sure what it is supposed to be.

But in presentation mode that fill is truncated, and is filled by area fill of the face. That happens with either OpenGL rendering or Default rendering (HA, CPU).

Changing the Area fill for the Smiley object from Horizontal lines to "Dashed diagonal" pattern makes the layer difference obvious, the eyes keep their area fill (though clipped in presentation) and the face's area fills in.

As Xisco beleives he has fixed the issue with the eyes for bug 126184 with:
https://gerrit.libreoffice.org/#/c/75143/  when that rolls to daily we can test. Otherwise it kind of suggests the issue is an OpenGL driver issue handling the lines for folks on Windows 7 (so far just Telesto and Aron).
Comment 15 V Stuart Foote 2019-07-06 15:05:00 UTC
Created attachment 152601 [details]
attachment 142298 [details] open LO 6242 in Presentation mode w OpenGL
Comment 16 V Stuart Foote 2019-07-06 15:05:47 UTC
Created attachment 152602 [details]
open LO 6242 in Edit mode w OpenGL
Comment 17 Luboš Luňák 2020-09-01 11:01:58 UTC
I cannot reproduce any problem with the lines with Skia (and this is now in the list of Skia bugs). Please check if you can reproduce and provide more info.
Comment 18 V Stuart Foote 2020-09-02 01:14:50 UTC
Created attachment 164999 [details]
fill of smilly face eyes during presentation--Skia Vulkan

Affecting Skia rendering as well as OpenGL. Likewise default GDI has issues in that the fill differs (line spacing) from edit mode.


Version: 7.1.0.0.alpha0+ (x64)
Build ID: a486fd929d4b3e915f928ef495b6cb2b96d74a3a
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 19 V Stuart Foote 2020-09-02 01:15:51 UTC
Created attachment 165000 [details]
fill of smilly face eyes during presentation -- default GDI