Bug 118776 - FILEOPEN Text set to no fill in PPTX is black in Impress
Summary: FILEOPEN Text set to no fill in PPTX is black in Impress
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Justin L
URL:
Whiteboard: target:7.3.0
Keywords: filter:pptx
Depends on: 137438
Blocks: PPTX-Texteffect
  Show dependency treegraph
 
Reported: 2018-07-15 20:48 UTC by Aron Budea
Modified: 2021-11-21 08:35 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample PPTX (28.56 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2018-07-15 20:48 UTC, Aron Budea
Details
"Reference" PPT (85.50 KB, application/vnd.ms-powerpoint)
2018-07-15 20:51 UTC, Aron Budea
Details
No text should be displayed with a shape behind (34.05 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2019-10-13 19:19 UTC, Xisco Faulí
Details
The sample file in PP and current Impress master (120.44 KB, image/png)
2021-01-28 10:41 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aron Budea 2018-07-15 20:48:59 UTC
Created attachment 143563 [details]
Sample PPTX

The attached PPTX, created in PowerPoint contains a single slide piece of text in a text box, with Text Fill (Drawing Tools / Format tab) set to No Fill is invisible in PowerPoint.

In Impress the text is black (and after rountrip, in PowerPoint as well).

Not sure what can be done in Impress, setting color to white doesn't do it, as the text has to be invisible (ie. with any background).

Observed using LO 6.1.0.1 & 3.3.0 / Windows 7.
Comment 1 Aron Budea 2018-07-15 20:51:07 UTC
Created attachment 143564 [details]
"Reference" PPT

Apparently what happens in the case of PPT is that such text is removed, see the attached sample PPT saved from the previous PPTX in PowerPoint.
Comment 2 raal 2018-07-16 21:06:31 UTC
I can confirm with Version: 6.2.0.0.alpha0+
Build ID: d11313f341d1d9a9c73c736932441a89d5292e37
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk3;
Comment 3 QA Administrators 2019-07-17 02:49:05 UTC Comment hidden (obsolete)
Comment 4 Aron Budea 2019-07-19 03:00:48 UTC
Still buggy in LO 6.4.0.0.alpha0+ (3600ec48823cda1c408b2f21a906d1df273be5da) / Windows 7.
Comment 5 Xisco Faulí 2019-10-13 19:10:05 UTC
I've just submitted a patch to gerrit < https://gerrit.libreoffice.org/#/c/80743/ > that makes Impress behave the same way as Writer, However, the problem is that LibreOffice doesn't support fill:none for text
Comment 6 Xisco Faulí 2019-10-13 19:19:53 UTC
Created attachment 154975 [details]
No text should be displayed with a shape behind
Comment 7 Commit Notification 2019-11-25 11:44:36 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e01df3488abe6d319c6874ca870afb82a3ad9b1e

tdf#118776: pptx import: draw char noFill as transparent

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2020-05-22 19:05:19 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8bf3e3fbdb708a75237a120d4f6fc46fe67dbbb9

tdf#129686: Revert "tdf#118776: pptx import: draw char noFill as transparent"

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Aron Budea 2020-05-24 05:21:55 UTC
I have no idea how to create this kind of XML content in PP, but it seems that if the <a:noFill/> tag is inside an <a:ln> (outline properties), then it's applied to the text fill, which shouldn't happen. As far as I can see LO doesn't support independent text outline, it only has a check box to switch on outline (with no fill).
Comment 10 NISZ LibreOffice Team 2021-01-28 10:41:44 UTC
Created attachment 169223 [details]
The sample file in PP and current Impress master

Still a problem in:

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 7eb289c49cc7245ef3001a39be0c15d06bbe875b
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: CL
Comment 11 Commit Notification 2021-11-20 14:13:29 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/823a351adb0384598304d597ae7f637079ca6175

tdf#118776 drawingml: treat XML_nofill as (mostly) transparent

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Gerald Pfeifer 2021-11-21 08:35:56 UTC
Verified with last night's daily build,
LibreOfficeDev 7.3.0.0.alpha1 918b62bea6cf82ce952c8d225dcabd4d08a2abf7 

(I'm wondering whether bug#138223 might be related? No change for the
bug document there, though.)