Bug 119028 - OpenGL: Sleeping and waking the computer up with a dialog open crashes LO
Summary: OpenGL: Sleeping and waking the computer up with a dialog open crashes LO
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
5.4.0.3 release
Hardware: All Windows (All)
: medium major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, haveBacktrace, regression
: 115178 (view as bug list)
Depends on:
Blocks: Crash VCL-OpenGL
  Show dependency treegraph
 
Reported: 2018-08-01 00:20 UTC by Aron Budea
Modified: 2020-08-28 12:20 UTC (History)
9 users (show)

See Also:
Crash report or crash signature: ["OpenGLContext::AcquireFramebuffer(OpenGLTexture const &)"]


Attachments
Backtrace (1.94 KB, text/plain)
2018-08-20 02:36 UTC, Aron Budea
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aron Budea 2018-08-01 00:20:43 UTC
Have OpenGL enabled.
Start Writer, open a dialog, eg. Format -> Character, make the computer go to sleep, and wake it up again.

=> Crash.

https://crashreport.libreoffice.org/stats/crash_details/13011227-71e7-41c8-9faf-156decec13fd

Observed using LO 6.1.0.2 / Windows 7.
Comment 1 V Stuart Foote 2018-08-01 01:20:34 UTC
Can not reproduce on Windows 10 Home 64-bit en-US with Intel HD 620 GPU
Version: 6.1.0.2 (x64)
Build ID: b3972dcf1284967612d5ee04fea9d15bcf0cc106
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
Locale: en-US (en_US); Calc: CL

1. Opening Writer
2. Open Format -> Character
3. put Windows to sleep
4. wake Windows

The LibreOffice and the character dialog reopen cleanly, no crash.

=--=
opengl_device.log

DriverVersion: 24.20.100.6025
DriverDate: 4-25-2018
DeviceID: PCI\VEN_8086&DEV_5916&SUBSYS_39FD17AA&REV_02
AdapterVendorID: 0x8086
AdapterDeviceID: 0x5916
AdapterSubsysID: 0x39fd17aa
DeviceKey: System\CurrentControlSet\Control\Video\{DADD6A53-B3C6-11E7-867C-A8C975C9851F}\0000
DeviceString: Intel(R) HD Graphics 620
Comment 2 Aron Budea 2018-08-01 03:51:53 UTC
My LO & driver details:

Version: 6.1.0.2 (x64)
Build ID: b3972dcf1284967612d5ee04fea9d15bcf0cc106
CPU threads: 4; OS: Windows 6.1; UI render: GL; 
Locale: en-US (en_US); Calc: CL

DriverVersion: 10.18.10.4885
DriverDate: 12-11-2017
DeviceID: PCI\VEN_8086&DEV_0166&SUBSYS_21F517AA&REV_09
AdapterVendorID: 0x8086
AdapterDeviceID: 0x0166
AdapterSubsysID: 0x21f517aa
DeviceKey: System\CurrentControlSet\Control\Video\{6C095915-A1C8-47BC-A940-7636102EEA44}\0000
DeviceString: Intel(R) HD Graphics 4000


It's also a regression, as there's still a crash in 5.4.0.3, but not in 5.3.0.3.
Bibisected to the following range, unfortunately this single commit in the repo is huge, consisting of >800 source commits.

https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=aabc5aab5af27e929a81a6036d2f470ab1f5ac4d..3e973760b788c49396c7a18404bffa0505e65a04
Comment 3 Aron Budea 2018-08-01 04:03:06 UTC
(In reply to V Stuart Foote from comment #1)
> 1. Opening Writer
> 2. Open Format -> Character
> 3. put Windows to sleep
> 4. wake Windows
Additionally, putting Windows to sleep via Start menu -> Sleep isn't enough for LO to crash. But closing the lid is (it's a notebook). No idea what the difference is.
Comment 4 Jean-Baptiste Faure 2018-08-01 07:03:05 UTC
Not reproducible for me with LO 6.1.1.0.0+ built at home under Ubuntu 16.04 x86-64.

Best regards. JBF
Comment 5 Roman Kuznetsov 2018-08-01 12:49:48 UTC
Aron, I have Intel HD 4000 and Win 7, but I can't activate OpenGL in LibreOffice, because driver is in black list.
How did you do your case?
Comment 6 Aron Budea 2018-08-01 14:58:26 UTC
(In reply to kompilainenn from comment #5)
> Aron, I have Intel HD 4000 and Win 7, but I can't activate OpenGL in
> LibreOffice, because driver is in black list.
> How did you do your case?
You can force it by checking the checkbox below where OpenGL can be enabled.
Comment 7 Miklos Vajna 2018-08-01 15:22:21 UTC
BTW note that there is a reason why something is blacklisted; it's not too interesting if known-to-be-problematic HW causes problems.
Comment 8 Aron Budea 2018-08-01 15:32:55 UTC
It's hard to establish in general whether something is due to the known-to-be-problematic hardware or not, so I would prefer avoiding jumping to conclusions in advance.
Comment 9 Aron Budea 2018-08-01 23:37:51 UTC
Reproduced on a desktop computer with different hardware. I had to adjust the power button to perform sleep fot this [1], as initiating sleep from Windows doesn't result in a crash.

https://crashreport.libreoffice.org/stats/crash_details/fb395275-edcd-4f34-9937-97fc983ac36b

DriverVersion: 24.20.11019.1004
DriverDate: 5-29-2018
DeviceID: PCI\VEN_1002&DEV_67DF&SUBSYS_341A1462&REV_EF
AdapterVendorID: 0x1002
AdapterDeviceID: 0x67df
AdapterSubsysID: 0x341a1462
DeviceKey: System\CurrentControlSet\Control\Video\{FC4A5D3E-8972-4D80-962E-36E5D0BB86EF}\0000
DeviceString: Radeon RX 570 Series

[1] https://www.digitaltrends.com/computing/make-pcs-power-button-stuff/
Comment 10 V Stuart Foote 2018-08-02 01:20:15 UTC
(In reply to Aron Budea from comment #9)
> Reproduced on a desktop computer with different hardware. I had to adjust
> the power button to perform sleep fot this [1], as initiating sleep from
> Windows doesn't result in a crash.

Nope, still can't reproduce a crash with Power button -> Sleep, and Windows wake up, unlock, restore.

Version: 6.2.0.0.alpha0+ (x64) with Intel HD 620 GPU
Build ID: 7119184f4b5441600f7b3eae7ec6771c094bbb7f
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-07-23_05:38:07
Locale: en-US (en_US); Calc: CL

I'll check behavior on an nVidia GTX 750 TI in a bit, and can follow-up with a AMD  box tomorrow.

=--=
opengl_device.log

DriverVersion: 24.20.100.6025
DriverDate: 4-25-2018
DeviceID: PCI\VEN_8086&DEV_5916&SUBSYS_39FD17AA&REV_02
AdapterVendorID: 0x8086
AdapterDeviceID: 0x5916
AdapterSubsysID: 0x39fd17aa
DeviceKey: System\CurrentControlSet\Control\Video\{DADD6A53-B3C6-11E7-867C-A8C975C9851F}\0000
DeviceString: Intel(R) HD Graphics 620
Comment 11 Aron Budea 2018-08-19 19:04:34 UTC
Bibisected further to the following commit. This crash seems to be hard to repro for others (the crash report server has crashes with the same signature and slightly different backtraces), nevertheless, adding Cc: to Caolán McNamara.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=482d7ce61b423600b41b459eb26a2cc221cd0acf
author		Caolán McNamara <caolanm@redhat.com>	2016-11-25 20:25:27 +0000
committer	Caolán McNamara <caolanm@redhat.com>	2016-12-13 11:33:18 +0000

change from glew to epoxy
Comment 12 Aron Budea 2018-08-20 02:36:04 UTC
Created attachment 144314 [details]
Backtrace

Here's an attempt of a backtrace taken with VS. I have doubts about the accuracy of the BT, considering the computer going to sleep is a difficult period to debug. What seems to be sure though is that the crash happens when going to sleep rather than coming back from it.
Comment 13 Caolán McNamara 2018-08-28 14:37:39 UTC
I wonder if an upgrade of epoxy to latest 1.5.2 would make any difference here, if anyone can test (tomorrow's daily) or build-their own with

https://cgit.freedesktop.org/libreoffice/core/commit/?id=7d0d1b198e8f87b9a59a584abf71800874f6a431

to see if that helps.
Comment 14 Aron Budea 2018-08-28 21:25:43 UTC
Thanks for the attempt Caolán, unfortunately it still crashes with a fresh master build (e055b4a0fc23e1d0ad5d498f9195790dd41f6b3e) that includes the mentioned commit.
Comment 15 Aron Budea 2018-10-07 23:38:39 UTC
Let's set this to confirmed, the crash is there beyond doubt.
Comment 16 Xisco Faulí 2018-11-27 14:43:50 UTC
*** Bug 115178 has been marked as a duplicate of this bug. ***
Comment 17 Michael Meeks 2019-04-30 10:33:48 UTC
Miklos - would be interested if you can reproduce (?)
Comment 18 Miklos Vajna 2019-04-30 12:13:07 UTC
I tried, but I can't. Here is what I tried:

As far as I see this was self-confirmed, so it's probably something special with Aron's setup.

I know he uses the non-default Windows 7 "basic" theme, so I switched to that, force-enabled GL, then started Writer, the Format -> Character dialog, then sent the laptop to sleep.

I could resume and continue using Writer without problems.

I tried this using both the nvidia card and the integrated intel card, neither of them resulted in a crash for me.

This is master, commit 6e07375f92f79959cc9288bb2a3b237b480e952c.

I wonder what else is needed to trigger the bug.
Comment 19 Aron Budea 2019-04-30 12:22:15 UTC
Interesting... So, let me copy my comment from bug 124709 with details, as I checked again, and this setting affects the current bug as well, no crash with a (default) Aero theme, but there's a crash with my usual theme:
"I normally don't use Aero themes on Win7. By enabling Aero themes, I can't repro this issue, and by going back to my usual Windows 7 Basic (non-Aero) theme, [...]

The actual setting this might be depending on is the "desktop composition", see:
https://support.lenovo.com/us/en/solutions/ht071432 "

I've got no idea what else might be different in my case compared to Miklos' setup. Anyway, let's lower severity, since the issue depends on very specific settings.
Comment 20 Buovjaga 2020-08-28 12:20:22 UTC
As Skia with Vulkan will replace OpenGL UI rendering on all platforms, it does not make sense to keep OpenGL UI reports open.

Details about Skia: https://www.collaboraoffice.com/success-story/implementing-vulkan-capable-libreoffice-user-interface-using-the-skia-library/