Bug 119661 - Embed linked image via menu "links to external files"->"Break link" doesn't work
Summary: Embed linked image via menu "links to external files"->"Break link" doesn't work
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.1.0.3 release
Hardware: All All
: high major
Assignee: Not Assigned
URL:
Whiteboard: target:6.3.0 target:6.2.1 target:6.1....
Keywords: bibisected, regression
: 122371 (view as bug list)
Depends on:
Blocks: Regressions-imageHandling
  Show dependency treegraph
 
Reported: 2018-09-03 10:58 UTC by Kai Struck
Modified: 2024-09-24 12:39 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Try to embed linked image by menu "links to external files"->"Break link" (11.78 KB, application/vnd.oasis.opendocument.text)
2018-09-03 10:59 UTC, Kai Struck
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Struck 2018-09-03 10:58:01 UTC
Description:
Embed linked image via menu "links to external files"->"Break link" doesn't work
Image is still linked and doesn't get embedded.

LO6.1.0.3
LO6.1.2.0.0
Win7 32bit

Steps to Reproduce:
1.insert image with checkbox "linked" or load example document (attached)
2.go to menu "links to external files"->"Break link"
3.Save document and reopen

Actual Results:
image is still linked and not embedded

Expected Results:
image should be embedded.


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Kai Struck 2018-09-03 10:59:37 UTC
Created attachment 144624 [details]
Try to embed linked image by menu "links to external files"->"Break link"
Comment 2 Xisco Faulí 2018-09-03 14:24:03 UTC
This doesn't work since https://cgit.freedesktop.org/libreoffice/core/commit/?id=9fb7aaf570c03c8a26d763f1205fb8c890e8211a, before this commit the 'link to external files didn't work since https://cgit.freedesktop.org/libreoffice/core/commit/?id=27008aa028cde8d270e898c5743a9fe5c7701dab, before this commit, everything worked fine.

Adding Cc: to Tomaž Vajngerl
Comment 3 Xisco Faulí 2019-01-18 11:42:01 UTC
*** Bug 122371 has been marked as a duplicate of this bug. ***
Comment 4 Commit Notification 2019-02-04 09:25:24 UTC
Tomaž Vajngerl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/6a36bedd0a418ce12543f797ab46f24ee57feb6c%5E%21

tdf#119661 remove the original URL when removing a graphic link

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2019-02-05 09:35:49 UTC
Tomaž Vajngerl committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/380fd85348084e3b35531bc6b50f6e2629b49bcc%5E%21

tdf#119661 remove the original URL when removing a graphic link

It will be available in 6.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Xisco Faulí 2019-02-05 15:03:21 UTC
Verified in

Version: 6.3.0.0.alpha0+
Build ID: f8c4459bbda62cb905d0c007cac044f3410ab76b
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@Tomaž Vajngerl, thanks for fixing this issue!! Closing as VERIFIED FIXED
Comment 7 Commit Notification 2019-02-05 15:05:19 UTC
Tomaž Vajngerl committed a patch related to this issue.
It has been pushed to "libreoffice-6-1":

https://git.libreoffice.org/core/+/71021e2f2619ed3c363e1d4cc1cde79bb1f2bd29%5E%21

tdf#119661 remove the original URL when removing a graphic link

It will be available in 6.1.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2021-04-07 06:41:36 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c38a4a2dbae58f031ce383237b94a4b0829cf2fe

tdf#119661: sw: Add UItest

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.