Bug 120802 - “Toggle Ordered List” and "Toggle Unordered List" remove a list style applied to a paragraph - should it?
Summary: “Toggle Ordered List” and "Toggle Unordered List" remove a list style applied...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Bullet-Number-Outline-Lists Writer-Styles-List
  Show dependency treegraph
 
Reported: 2018-10-22 18:03 UTC by Harald Koester
Modified: 2021-05-05 14:10 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Koester 2018-10-22 18:03:01 UTC
The function of the button “Toggle Numbered List” is quite confusing, especially after the change from version 6.0.x to 6.1.x.

In order to reproduce the bug:

[1] Create a new text document and open list styles in sidebar.
[2] Insert a bit of text in one paragraph.
[3] Click “Toggle Numbered List” in toolbar Formatting. The number is inserted and the paragraph is aligned at 0.64 cm. Version 6.1.2: Style “List 1” is highlighted. This style is a bulleted list, not a numbered list. Version 6.0.6: No Style is highlighted. Expected: No highlighting, because I don't expect an assignment of a list style. With this button I only expect a direct formatting.
[4] For me it is not clear, if with version 6.1.2 in step 4 a list style has been assigned or if the display is wrong. Do this: Open paragraph dialogue: Format > Paragraph… > Tab “Outline & Numbering”: Version 6.1.2: The field “Numbering style” is empty. If an assignment has been performed I would expect, that the style “Numbering 123” is displayed here. Or if an assignment has not been performed I expect, that “None” is displayed. Version 6.0.6: “None” is displayed in field “Numbering style”.
[5] Close dialogue with Cancel.
[6] Remove number: Click “Toggle Numbered List” again.
[7] Assign style “Numbering 123” with double-click. A number is inserted.
[8] Click “Toggle Numbered List”. The number is removed. A list style is no longer valid. Expected: With the button I only expect that a direct formatting is changed. Here in this case the style is changed to “None”.

There is a problem at step 8. It is not possible to remove a list style directly to “None”. This is currently only possible with a workaround:

[8] Format > Paragraph > Tab “Outline & Numbering” > Field “Numbering style”: Select “None”. Then OK.

So the 'style' “None” should also be displayed as selectable style in the style selection tab of the sidebar.

The behaviour is equivalent, if you use a bulleted list instead of a numbered list.
Comment 1 Dieter 2018-12-05 20:53:02 UTC
Harald, I don't know, if all the obeservations fits to one bug. So I would concentrate on steps 1-3. But I can reproduce them with

Version: 6.2.0.0.beta1 (x64)
Build ID: d1b41307be3f8c19fe6f1938cf056e7ff1eb1d18
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-US (de_DE); UI-Language: en-GB
Calc: threaded


So I renamed the bug report.

Steps to reproduce
1. Open a new document
2. Open list styles in the sidebar
3. Click "Toggle Numbered List" => style "List 1" is highlighted
4. Click "List 1" => style of the list changes
5. Click "Toggle Bullet List" => style List 1" is highlighted
6. Click "List 1" => style of list changes

Expected result: "List 1" shouldn't be highlighted.

Harald, if you don't agree, please feel free to change it again.
Comment 2 Dieter 2018-12-06 13:03:42 UTC
I can't reproduce it in

Version: 6.1.3.2 (x64)
Build-ID: 86daf60bf00efa86ad547e59e09d6bb77c699acb
CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; 
Gebietsschema: de-DE (de_DE); Calc: group threaded
Comment 3 Xisco Faulí 2018-12-12 18:17:31 UTC
Same behaviour in

Version: 5.4.0.0.alpha1+
Build ID: 9feb7f7039a3b59974cbf266922177e961a52dd1
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

@Dieter Praas, why do you say it's not reproducible in 6.1.2.1 ?
Comment 4 Dieter 2018-12-12 20:06:25 UTC
(In reply to Xisco Faulí from comment #3)
> @Dieter Praas, why do you say it's not reproducible in 6.1.2.1 ?

Because no list style is highlighted in the sidebar.

But I can reproduce it with

Version: 5.4.7.2 (x64)
Build-ID: c838ef25c16710f8838b1faec480ebba495259d0
CPU-Threads: 4; BS: Windows 6.19; UI-Render: GL; 
Gebietsschema: de-DE (de_DE); Calc: CL
Comment 5 Harald Koester 2018-12-19 11:58:40 UTC
(In reply to Dieter Praas from comment #1)
> Harald, I don't know, if all the obeservations fits to one bug. So I would
> concentrate on steps 1-3. But I can reproduce them with
> 
> Version: 6.2.0.0.beta1 (x64)
> Build ID: d1b41307be3f8c19fe6f1938cf056e7ff1eb1d18
> CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
> Locale: en-US (de_DE); UI-Language: en-GB
> Calc: threaded
> 
> 
> So I renamed the bug report.
> 
> Steps to reproduce
> 1. Open a new document
> 2. Open list styles in the sidebar
> 3. Click "Toggle Numbered List" => style "List 1" is highlighted
> 4. Click "List 1" => style of the list changes
> 5. Click "Toggle Bullet List" => style List 1" is highlighted
> 6. Click "List 1" => style of list changes
> 
> Expected result: "List 1" shouldn't be highlighted.
> 
> Harald, if you don't agree, please feel free to change it again.

The problem is not only a highlighting problem. The main problem of these buttons is, that it is not transparent, if they change the list style or not (step 3 and step 8 of initial report). To my opinion the buttons should never change the style. But then you have a problem: Then a list style can only be removed by the described workaround. So I asked for a style "None" in the style selection list in the sidebar.
Comment 6 QA Administrators 2020-12-19 03:48:52 UTC Comment hidden (obsolete)
Comment 7 sdc.blanco 2021-03-02 02:35:57 UTC
(In reply to Harald Koester from comment #0)

> [3] Click “Toggle Numbered List” in toolbar Formatting. The number is
> Expected: No highlighting
No highlighting in 7.2.0.0.alpha0+  (also following procedure in comment 1)

> [7] Assign style “Numbering 123” to a paragraph.
> [8] Click “Toggle Numbered List”. 
> Actual: The number is removed. A list style is no longer valid. 
> Expected: With the button I only expect that a direct
> formatting is changed. Here in this case the style is changed to “None”.

Reproduced with:
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 6fb9f368c6824a8ff7bc5bc5cf66fc2df7d055b7
CPU threads: 8; OS: Windows 10.0 Build 19041; UI render: default; VCL: win
Locale: en-US (en_DK); UI: en-US
Calc: threaded

> There is a problem at step 8. It is not possible to remove a list style
> directly to “None”. This is currently only possible with a workaround:
Now there is a "No List" command.

> So the 'style' “None” should also be displayed as selectable style in the
> style selection tab of the sidebar.
Bug 115071 

To summarize: The remaining issue in the OP -- now formed as a question:

Should the "Toggle Ordered List" (F12) icon on the Formatting bar "remove" a  list style with enumeration?

(and the same thing happens with "Toggle Unordered List" if a bulleted list style is used).

(modifying summary accordingly)
Comment 8 sdc.blanco 2021-03-02 03:47:54 UTC
Same thing happens if a list style is assigned to a paragraph.

1. Make new Paragraph Style (e.g.,:  "Text Body 123"), with Numbering 123 assigned as List Style in the "Outline & List" tab.
2. Apply "Test Body 123" PS to a paragraph.  Result: Number appears.
3. Toggle Ordered List in Formatting Bar, with cursor in paragraph with the new style.

Actual: Numbering disappears.
Expected: Paragraph with "Text Body 123" PS style should not have its list number affected by the Toggle Ordered List.

As noted in comment 0:
> Expected: With the button I only expect that a direct formatting is changed.
As expressed in many BZ comments, direct formatting lists are supposed to be different from list styles, which presumably leads to the belief that using the icons on the formatting bar should have *nothing* to do with list styles. This bug report gives some empirical counter-evidence to that belief.
Comment 9 Justin L 2021-05-05 14:10:14 UTC
(In reply to Harald Koester from comment #0)
> [6] Remove number: Click “Toggle Numbered List” again.
> [7] Assign style “Numbering 123” with double-click. A number is inserted.
> [8] Click “Toggle Numbered List”. The number is removed. A list style is no
> longer valid. Expected: With the button I only expect that a direct
> formatting is changed. Here in this case the style is changed to “None”.

So - when double-clicking on a numbering style, you ARE applying direct formatting for numbering. Indirect formatting only comes from the numbering rules attached to paragraph styles.

[I'm not sure what happens under the hood for an "unnamed" style created by the toolbar buttons, compared to the named styles that are available.]

Since the list button toggles off numbering, I'm a little puzzled why that no-list toolbar button was added. As far as I am concerned, it all makes sense to me to toggle. [Actually, the new no-list button is what confuses me.] This is NOTABUG AFAIAC.