Bug 121298 - Context Menu: DrawText add direct formating
Summary: Context Menu: DrawText add direct formating
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
(earliest affected)
Hardware: All All
: medium normal
Assignee: Not Assigned
Depends on:
Blocks: Context-Menu
  Show dependency treegraph
Reported: 2018-11-09 07:35 UTC by andreas_k
Modified: 2018-11-20 08:29 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:

Add direct formating options in DrawText cause here are no styles options available (23.53 KB, image/png)
2018-11-09 07:35 UTC, andreas_k
DrawTex Context Menu in 6.1 (5.41 KB, image/png)
2018-11-09 10:00 UTC, andreas_k

Note You need to log in before you can comment on or make changes to this bug.
Description andreas_k 2018-11-09 07:35:06 UTC
Created attachment 146470 [details]
Add direct formating options in DrawText cause here are no styles options available

In an textshape (all apps) or an celltext (calc) you can edit text only with direct formating (bold, italic, ...) As we have with right click styles options in Text areas, I'd recommend to have direct formating options for DrawText and Celltext.

how it will look like you can see in the attachment.

patches are:
https://gerrit.libreoffice.org/#/c/63138/ (for writer, impress, draw, ...)
https://gerrit.libreoffice.org/#/c/63135/ (for calc)

in calc there is instead of Increase/Decrease Size Sub/Super Script.
Comment 1 Heiko Tietze 2018-11-09 09:49:35 UTC
The direct formatting was removed because of the duplication at toolbar and sidebar. See discussion in bug 81132 and bug 86606. It was not an unanimously decision and some discussion balanced the pro and cons of size, a11y, workflow. For the size, I would target not more than 10 items per context menu, a11y is up to the experts (Stuart, Alex: what do you think?), and workflow is a +1 from my side since alternatives are good.
Comment 2 andreas_k 2018-11-09 10:00:01 UTC
Created attachment 146487 [details]
DrawTex Context Menu in 6.1

This is the drawtext context menu before the change.
Comment 3 Cor Nouws 2018-11-14 19:04:31 UTC
Patch gives small increase in size. Increase and Decrease Size will be appreciated. Ally is a thing too.
Expecting that in Draw-text quick direct formatting on small pieces is more common than styles, I have no objection against this change.
Comment 4 Heiko Tietze 2018-11-15 08:17:21 UTC
Stuart, what is your take on this?
Comment 5 Thomas Lendo 2018-11-15 21:15:55 UTC
I don't see the benefit for direct formatting features in the context menu. It's the same in comments. We bring inconsistency in the UI and a lot of mess that was removed a few years ago.

The changes in the past were discussed intensely.

-1 from me.
Comment 6 andreas_k 2018-11-19 12:56:49 UTC
Stuard any feedback?
Comment 7 V Stuart Foote 2018-11-19 21:21:36 UTC
(In reply to andreas_k from comment #6)
> Stuard any feedback?

Sorry, had to ponder this for a bit.

I do not like the idea of pushing Direct Formatting back into the context menu, it is not necessary when we have the Sidebar decks--Properties & Styles.

And for Draw TextObjects we provide the Sidebar Properties deck showing style or direct formatting, and in Draw itself we provide the Styles Deck to manipulate a Draw Text Object box holding text cursor focus.

So, it is not clear that a Context menu is *required* in the general case.

But that said, for MUFFIN modes where we suppress Sidebar use, the context menu *would* be of use--and if I recall at the 4.4 -> 5.0 cut over we had left that on the table. Jay had proposed a context sub-menu for Direct Formatting [1]. As then, I would be responsive to exposing a DF sub-menu in those MUFFIN modes when Sidebar is otherwise hidden.

But I would not put clutter of DF back directly on the root of context menus anywhere in the GUI.

[1] https://bugs.documentfoundation.org/show_bug.cgi?id=86606#c5
Comment 8 andreas_k 2018-11-19 21:31:51 UTC
Thanks for the feedback