1. Open attachment 140889 [details] from Bug 116643 2. Go to slide 4 3. Select the picture With gen and gtk2 backends we see the media control toolbar appear. GTK3 says Picture1 selected. The video does not play in the slideshow. Arch Linux 64-bit Version: 6.1.3.2 Build ID: 6.1.3-2 CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: fi-FI (fi_FI.UTF-8); Calc: group threaded Arch Linux 64-bit Version: 6.3.0.0.alpha0+ Build ID: 9059457a1a8385cb80b5dd2c797cee77af4222a9 CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US Calc: threaded Built on 30 November 2018
Slide no 4 appears blank with a Question mark(?) symbol in my Presentation. Version: 6.0.6.2 Build ID: 0c292870b25a325b5ed35f6b45599d2ea4458e77 CPU threads: 2; OS: Windows 6.1; UI render: default; Locale: en-US (en_US); Calc: group
(In reply to Durgapriyanka from comment #1) > Slide no 4 appears blank with a Question mark(?) symbol in my Presentation. > > Version: 6.0.6.2 > Build ID: 0c292870b25a325b5ed35f6b45599d2ea4458e77 > CPU threads: 2; OS: Windows 6.1; UI render: default; > Locale: en-US (en_US); Calc: group There is no problem on Windows, you are just lacking video codecs: https://github.com/Nevcairiel/LAVFilters/releases
This seems to have begun at the below commit. Adding Cc: to Jan Holesovsky ; Could you possibly take a look at this one? Thanks 5a4eaa341cdf46e679a5063dddfdf0c0f86b588c is the first bad commit commit 5a4eaa341cdf46e679a5063dddfdf0c0f86b588c Author: Jenkins Build User <tdf@pollux.tdf> Date: Thu Sep 7 01:04:21 2017 +0200 source 2f07a533ed7b52fb0420e6f0a98f42019dcf185f author Jan Holesovsky <kendy@collabora.com> 2017-09-05 17:15:03 +0200 committer Jan Holesovsky <kendy@collabora.com> 2017-09-06 14:47:42 +0200 commit 2f07a533ed7b52fb0420e6f0a98f42019dcf185f (patch) tree 5a36dbe2198a518eec2279dc92d0f57eef5eedbd parent e64ebbb7ac530f82bf26a67fed0e1d22b254ff93 (diff) tdf#106867: Import target for commands in PPTX.
I don't see a significant difference between gtk2 and gtk3 on my machine, in both cases the video is paused by EffectCommands::TOGGLEPAUSE in slideshow/source/engine/animationnodes/animationcommandnode.cxx by AnimationCommandNode::activate_st. Which matches with the bisect commit. I get the impression from this code that there should be an unpause scheduled in which doesn't seem to arrive
Hmh, it seems I was confused. Indeed, GTK2 has the same behaviour.
confident enough that this is a generic problem rather than a GTK3 one so removing that tag. original pptx xml looks like... <p:cmd type="call" cmd="togglePause"> <p:cBhvr> <p:cTn id="12" dur="1" fill="hold"> </p:cTn> <p:tgtEl> <p:spTgt spid="124"> </p:spTgt> </p:tgtEl> </p:cBhvr> </p:cmd> and https://gerrit.libreoffice.org/#/c/64548/ would fix this in the sense that the video is paused for a short time and then continues. But I don't really know how this is supposed to work to know if that's even close to right fix.
(In reply to Caolán McNamara from comment #6) > and https://gerrit.libreoffice.org/#/c/64548/ would fix this in the sense > that the video is paused for a short time and then continues. But I don't > really know how this is supposed to work to know if that's even close to > right fix. After applying the patch, Picture1 selected is still shown in the status bar instead of media controls, but the video *does* play during the slideshow.
(In reply to Buovjaga from comment #7) > (In reply to Caolán McNamara from comment #6) > > and https://gerrit.libreoffice.org/#/c/64548/ would fix this in the sense > > that the video is paused for a short time and then continues. But I don't > > really know how this is supposed to work to know if that's even close to > > right fix. > > After applying the patch, Picture1 selected is still shown in the status bar > instead of media controls, but the video *does* play during the slideshow. Hmm, maybe my observation is useless as the media controls are shown in the sidebar and they work fine.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/1aa10fcb668f67f4313b7170a4090027e52164c5%5E%21 tdf#121830 TogglePause should reset to original state on deactivate_st ? It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
the major brokenness seems fixed, thb seems happy enough that this fix is how its supposed to work. backport to 6-2 in gerrit
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/d6b1e268796aac1448f8fe6a153d4aa129466c76%5E%21 tdf#121830 TogglePause should reset to original state on deactivate_st ? It will be available in 6.2.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
issue verified in Version: 6.3.0.0.alpha0+ Build ID: fcc76610649a9830859f9e2efe2a06dbc6db74da CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded However, it introduced bug 121942
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-1": https://git.libreoffice.org/core/+/8b550ff4c320e3c3e1495b4a38858c23c420dc86%5E%21 tdf#121830, tdf#121942 TogglePause should reset to original... It will be available in 6.1.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-1-4": https://git.libreoffice.org/core/+/1ec50207dfe7ac7463ee9dff5b89c26af8b4e3b8%5E%21 tdf#121830, tdf#121942 TogglePause should reset to original... It will be available in 6.1.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.