Bug 122361 - Tabbed NB left edge of 'File' Tab lacks edge decoration (Win 10 WDM only) so looks odd against the NB print button, when unselected
Summary: Tabbed NB left edge of 'File' Tab lacks edge decoration (Win 10 WDM only) so ...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.2.0.1 rc
Hardware: x86-64 (AMD64) Windows (All)
: lowest trivial
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 125224 125293 (view as bug list)
Depends on:
Blocks: Notebookbar
  Show dependency treegraph
 
Reported: 2018-12-28 12:49 UTC by John Mills
Modified: 2020-05-23 00:17 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of missing tab left hand line. (12.88 KB, image/png)
2018-12-28 12:55 UTC, John Mills
Details
Screenshot of panel not having left hand side decoration when File tab looses focus (10.63 KB, image/png)
2019-01-03 10:41 UTC, James
Details
LibreOffice_Bug_122361_Possible_Solution.png (428.26 KB, image/png)
2020-05-15 13:43 UTC, John Mills
Details

Note You need to log in before you can comment on or make changes to this bug.
Description John Mills 2018-12-28 12:49:01 UTC
Description:
Please forgive me if this is not in an expected format. This is my first bug submission.

In the new tabbed interface the end of the first tab(file)has no left side of the rectangle only a top and right line. This can be clearly seen when you select the Home tab.

Could this be assigned to the viewing and accessibility sub components of UI. I'm not sure how this is done. 

Perhaps this should be submitted to Andreas Kainz?

This looks very unprofessional and not finised. The file tab should look like all oter tabs it is inconsistent currently. 

Steps to Reproduce:
1.Open the view menu option
2.Select User Interface
3.Select Tabbed

Actual Results:
The File tab has no left hand side to the rectange only top and right, this can be clearly seen when selecting the 'Home' tab

Expected Results:
That this is fixed by amending the user interface to improve consistency of the user interface.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Comment 1 John Mills 2018-12-28 12:55:07 UTC
Created attachment 147875 [details]
Screenshot of missing tab left hand line.

Please can you send to a member of the UI team who works on the notebook bar interface.

I hope this helps,

Kind regards,

John Mills
Comment 2 V Stuart Foote 2018-12-29 00:21:56 UTC
And when you select the File tab? Edge is present there--so this is just when File Tab is unselected. The Groupedbar Compact flavor of MUFFIN is not affected.

And, actually suspect all the the Notebook bar tabs similarly lack the left edge decoration--and we'll find it is just the File tab butting up against the Print widget in the abbreviated toolbar that is missing a right edge decoration.

So, confirmed on Windows builds.

But personally this is a pretty trivial issue.
Comment 3 Xisco Faulí 2019-01-02 14:46:53 UTC
I can't reproduce it in

Versión: 6.2.0.1
Id. de compilación: 0412ee99e862f384c1106d0841a950c4cfaa9df1
Subprocs. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; VCL: win; 
Configuración regional: es-ES (es_ES); Idioma de IU: es-ES
Calc: threaded
Comment 4 James 2019-01-03 10:41:50 UTC
Created attachment 147970 [details]
Screenshot of panel not having left hand side decoration when File tab looses focus
Comment 5 James 2019-01-03 10:45:15 UTC
I can confirm that I have this issue too. Windows 10 X64 bit build 6.2.0.1. If this is a quick fix can this be corrected before RC2?
Comment 6 V Stuart Foote 2019-01-03 13:37:11 UTC
The missing left edge decoration of the left most tab of the 'Tabbed' Notebookbar UI is visible on Windows 10 Home 64-bit en-US 

with experimental mode enabled on
Version: 6.1.4.2 (x64)
Build ID: 9d0f32d1f0b509096fd65e0d4bec26ddd1938fd3
CPU threads: 4; OS: Windows 10.0; UI render: GL (and Default);
Locale: en-US (en_US); Calc: CL

also on 
Version: 6.2.0.0.beta1 (x64)
Build ID: d1b41307be3f8c19fe6f1938cf056e7ff1eb1d18
CPU threads: 4; OS: Windows 10.0; UI render: GL (and Default); VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

also on current master/6.3.0
Version: 6.3.0.0.alpha0+
Build ID: 02399a217b94660efc874e589fc4140bbbabd884
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded
Comment 7 James 2019-01-03 14:24:19 UTC
I think the bug title is a little inaccurate, it is the left hand decoration of the 'File' tab missing ONLY when it does not have focus. When it does have focus it is there. 

As the default starting point of LibreOffice is the 'Home' tab it is very noticeable that the left end of the File tab is not shown. 

When the File tab is selected the edge is there, only when it looses focus (default starting point) it is not there. Does that make sense?

James
Comment 8 James 2019-01-03 14:26:40 UTC
This is with build:

Version: 6.1.0.3
Build ID: efb621ed25068d70781dc026f7e9c5187a4decd1
CPU threads: 4; OS: Windows 10.0; UI render: default; 
Locale: en-US (en_GB); Calc: CL
Comment 9 James 2019-01-03 14:28:08 UTC
And also on :

Version: 6.2.0.1 (x64)
Build ID: 0412ee99e862f384c1106d0841a950c4cfaa9df1
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-GB (en_GB); UI-Language: en-US
Calc: threaded
Comment 10 andreas_k 2019-04-10 21:19:01 UTC
I can confirm this bug and hope it can be fixed
Comment 11 V Stuart Foote 2019-05-15 07:03:41 UTC
*** Bug 125293 has been marked as a duplicate of this bug. ***
Comment 12 John Mills 2020-05-15 13:41:29 UTC
Hi all,

There is a very simple solution to this bugg that I hope can be implemented for Microsoft Windows Users. 

It also helps with usability for those that are visually impaired / colour blind by providing good contrast between the tab items and menu background.

By default there in LibreOfficeis there isno Personalization themes active. Hence there is no difference between the colour of the menu tabs and the background colour behind them. This can be seen in the original screenshot. 

However if a different Personalization colour is selected like Light Grey or Green etc there is a good contrast that makes the application easier to use in the   Notebookbar. This improved usability and could be a medical improvement for users that struggle to differentiate similar colours.

By changing the default colour to one of the personalization colours usability and menu consistency is improved.

I am attaching a screenshot(LibreOffice_Bug_122361_Possible_Solution.png)to this comment to illustrate this point and how the change would look by default. This is a simple fix that improves usability and makes the interface look more consistent and professional. It is my opinion that changing to the light grey colour is an improvement for the reasons stated and would be a simple fix to implement.I understand that the severity was rated as 'trivial' but I believe this is an incorrect judgement due to Microsoft users being by far the biggest users of LibreOffice and that this simple change will improve consistency, usability and productivity. 

Kind regards and many thanks
Comment 13 John Mills 2020-05-15 13:43:12 UTC
Created attachment 160862 [details]
LibreOffice_Bug_122361_Possible_Solution.png

Possible solution to bug by changing default colour from the Personalization menu.
Comment 14 V Stuart Foote 2020-05-15 14:48:15 UTC
(In reply to John Mills from comment #12)
> Hi all,
> 
> There is a very simple solution to this bugg that I hope can be implemented
> for Microsoft Windows Users. 
> 
Yes that is one approach, but providing better logic for handling of the Notebook Bar's GUI elements is still the correct approach to this trivial UI glitch.

Otherwise we are waiting on MS to provide C++ API support for non-UWP applications to support correct import of desktop themes. Meaning, rather than hardcode coloring individual UI elements--we can apply coloring as set by the os/DE, as done now for the Linux os/DE builds but lacking for Windows (and macOS)

That support then gets us integration with the HC and other Assistive Technology that MS provides in its 'Ease of Access' framework.
Comment 15 andreas_k 2020-05-22 23:15:48 UTC
I think it's an duplicate of BUG 125224 the vertical line of the tab is missing.
Comment 16 V Stuart Foote 2020-05-23 00:16:26 UTC
*** Bug 125224 has been marked as a duplicate of this bug. ***