Download it now!
Bug 122366 - Index filter results will be reset after clicking one of the entries
Summary: Index filter results will be reset after clicking one of the entries
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Documentation (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:6.3.0
Keywords:
Depends on:
Blocks: New-Help
  Show dependency treegraph
 
Reported: 2018-12-29 01:38 UTC by Franklin Weng
Modified: 2019-05-02 19:52 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Franklin Weng 2018-12-29 01:38:53 UTC
Both in offline and online help (https://help.libreoffice.org), when I entered a search term (for example, "date format") the results would be shown in the left field.  Then, when I clicked one of the result, the page would refresh but then the sort result would be reset too.

I would like to read more results of the "date format" related topics, but everytime I need to search again.  If I went back to the previous page, the search term was in the input field, but the left field was still of before searching.

It will be more convenient to keep the results until I reset or change the search input.
Comment 1 Olivier Hallot 2018-12-29 10:38:11 UTC
confirmed.
Comment 2 Buovjaga 2018-12-29 13:35:17 UTC
This request will conflict with the feature of bug 119415. Note that you will not see the feature in action if visiting the old version https://help.libreoffice.org/6.1 - you have to visit https://help.libreoffice.org/6.2

Now, after implementing the request of bug 119415, the index will *always* change, if you click on any other topic besides GLOBAL.

If we try to implement Franklin's request, the result will *always* be lacking and not be what Franklin wants.

Franklin's search results would never be 100% preserved, if he clicked some other topic besides GLOBAL.

Therefore I do not know, if this request should be implemented.
Comment 3 Heiko Tietze 2019-01-04 09:17:25 UTC
When a filter (module here) is set by the user this has to be respected. So I would keep the filter active. But in the current solution it's not transparent what module has been selected. So my proposal is to add "All Modules" to the list and change the label according what is selected. Furthermore, I would keep the search term alive when the module is changed and restart the search.
Comment 4 Buovjaga 2019-01-04 09:50:17 UTC
(In reply to Buovjaga from comment #2)
> This request will conflict with the feature of bug 119415. Note that you
> will not see the feature in action if visiting the old version
> https://help.libreoffice.org/6.1 - you have to visit
> https://help.libreoffice.org/6.2

The links went to the old wiki. This is the correct link: https://helponline.libreoffice.org/6.2/

Someone else can implement this how they want. Removing myself.
Comment 5 Commit Notification 2019-05-02 18:19:19 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/+/578f74466fcbf2dca537859e73064bfb4583928a%5E%21

tdf#122366 Store search filter value in sessionStorage
Comment 6 Buovjaga 2019-05-02 19:52:58 UTC
Would be great to hear opinions on the patch. Is sessionStorage enough or is localStorage needed?
Mike's bug 123318 is touching on the other stuff mentioned in this report (Heiko's "my proposal is to add "All Modules" to the list and change the label according what is selected").