Created attachment 148541 [details]
Shows Navigator > Bookmarks > Bookmark > Edit...
In a document, add some bookmarks (Insert > Bookmark). Go to the Navigator. Expand Bookmarks.
Currently for each bookmark under Bookmarks, a selection can be made via right-click > Bookmark > Edit... This displays the "Insert Bookmark" window. The same one that is under Insert > Bookmark.
In the Navigator, the right-click menu for each bookmark already contains Bookmark > Delete and Bookmark > Rename. I'm not sure what the purpose of Bookmark > Edit is when executed from Navigator > Bookmarks.
From the Bookmark window:
The button Rename is already on the Navigator > Bookmarks right-click menu.
The button Delete is already on the Navigator > Bookmarks right-click menu.
The button Goto is achieved by double-clicking a specific bookmark.
The button Insert, which is active, seems to just add another bookmark, but which one is not clear.
- In the Bookmark window nothing is highlighted/selected in the list.
- I selected a bookmark in the Navigator with a different page than was added when I clicked Insert.
- Last, I repositioned myself to a specific page in the document and clicked to establish the cursor position.
I right-clicked a bookmark > Bookmark > Edit..., and it wasn't that page number either.
If Insert doesn't make sense from Navigator > Bookmarks, how about changing Edit... to View.... If Insert does make sense, I wasn't able to get it to work. It would not insert the current cursor position as a bookmark. However, I think it might be the last bookmark inserted successfully from the Insert > Bookmark menu.
Also, Rename should be "Rename...". It opens a dialog.
Also, clicking the Insert button should not close the Bookmark window, no matter how it was invoked (Insert > Bookmark or Navigator > Bookmarks > abookmark > Bookmark > Edit.... A user may want to add/insert many bookmarks. It seems they would position cursor in the document and click Insert, position again someplace else, and click Insert again. But currently clicking the Insert button closes the window.
If I hover over an object in the Navigator (i.e., Tables, Bookmarks), the "Extended Tips" will show how many there are. It would be helpful if the hover over a specific bookmark showed the Page number.
In the lower left-hand corner, if you right-click the page numbers, the bookmark list appears. It would be helpful if the page number appeared in the list too (2-column list).
Currently version: 184.108.40.206
Please see if should be CC'd to Bug 115817.
Of course, we could move Remove, Delete, and Goto into a context menu. But on the other hand, duplicate functions help to understand the functionality and support accessibility. So double-click is not clear to all users but Goto is, for example.
The Insert button makes sense when you add a new bookmark via menu.
About the ellipsis for Rename I wouldn't stress it too much and show it only when complex input follows. Otherwise we clutter the menus.
Up for discussion (other additions beyond the bookmarks dialog are better handled in extra tickets).
I appreciate that there are (at least) two different ways to work with bookmarks. WFM.
(In reply to Cor Nouws from comment #3)
> I appreciate that there are (at least) two different ways to work with
> bookmarks. WFM.
Two different was would also exist when the buttons Go to, Rename, and Delete go into a context menu. That makes the dialog in fact a bit cleaner.
Could be an easy hack.
(In reply to Heiko Tietze from comment #4)
> (In reply to Cor Nouws from comment #3)
> > I appreciate that there are (at least) two different ways to work with
> > bookmarks. WFM.
> Two different was would also exist when the buttons Go to, Rename, and
> Delete go into a context menu. That makes the dialog in fact a bit cleaner.
Which context menu? The description in the topic is a bit confusing to me.
Mind that the dialog is easier when you want to do actions on more bookmarks.
(NB Help misses information on the 'hidden' property).
(In reply to Cor Nouws from comment #5)
> Which context menu?
A context that would be have to be introduced taking the less important functions in order to streamline the dialog.
(In reply to Heiko Tietze from comment #6)
> A context that would be have to be introduced
> taking the less important functions in order to streamline the dialog.
I don't see less important functions
(In reply to Cor Nouws from comment #7)
> (In reply to Heiko Tietze from comment #6)
> > A context that would be have to be introduced
I seriously do not understand what the idea is as to where to add a context menu..
(apart from the rest from the discussion ;) )
Created attachment 152128 [details]
Mockup for context menu
Quick and dirty mockup. Goal is to streamline the dialog by moving the less important functions into a context menu. "Go to" would be the default when you double click an entry, Rename could be assigned to F2, and Delete to Del (plus a confirmation box).
The mockup doesn't consider any change to other parts of the dialog.
(In reply to Heiko Tietze from comment #9)
> Created attachment 152128 [details]
> Mockup for context menu
Thanks. It doesn't make me enthusiastic Heiko.
There's enough of space for the buttons.
And visible buttons improve usability and accessibility.
I don't see the point, really, for this mini-changes that hide functions.
(In reply to Cor Nouws from comment #10)
> There's enough of space for the buttons.
> And visible buttons improve usability and accessibility.
> I don't see the point, really, for this mini-changes that hide functions.
It's not always good usability to expose functions. Of course, primary and frequently used functions have to be easily to reach but secondary and special features could go into a context menu to make the dialog lighter. Another argument, not in this case, is to have standard functionality usually accessible per shortcut there, for example copy/paste. So the question is how important Delete, Rename, and GoTo (double click) is here.
(In reply to Cor Nouws from comment #5)
> (NB Help misses information on the 'hidden' property).
Is it even possible to edit the condition on bookmarks through the UI? (I could not find a way.)
May be related to bug #101856 and this commit: http://cgit.freedesktop.org/libreoffice/core/commit/?id=7a586a9c6bf28088c72f163d724d1cb3259e7920