Bug 123123 - Hyperlink dialog window is too small / doesn't remember size
Summary: Hyperlink dialog window is too small / doesn't remember size
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.2.0.3 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Dialog-Remember-Settings Hyperlink-Dialog
  Show dependency treegraph
 
Reported: 2019-02-02 14:38 UTC by bugzilla2
Modified: 2023-07-01 09:05 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Patch (2.87 KB, patch)
2021-06-30 13:35 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description bugzilla2 2019-02-02 14:38:42 UTC
Description:
Starting with LibO 6.2 the Hyperlink dialog window is smaller than it used to be. I have already read Bug 112117, which states that the old size was to big for some users. Nevertheless, for me this is a change to the worse. Can we revert the size or instead make the dialog remember its last window-size?

Steps to Reproduce:
1. Open the Hyperlink dialog window
2.
3.

Actual Results:
The Dialog is smaller then in LibO 6.1

Expected Results:
The Dialog should have same size than in LibO 6.1 or remember its last window-size.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Comment 1 Dieter 2019-02-02 16:24:01 UTC
I confirm, that the width changed:

LO 6.1.5.2   22 cm
LO 6.3.0.0   16 cm

I agree, that it is small, but for me it is not too small. I also think, we should merge this bug with bug 112117, becoause otherwise we discuss one topic (what the best width?) in two different reports.
Comment 2 bugzilla2 2019-02-02 17:56:33 UTC
For me it is "too small", because I permanently (or at least most times) have to make the window bigger. So this change decreases my productivity :/
Comment 3 Heiko Tietze 2019-02-04 16:27:16 UTC
Let's have a sane default width (eg. 600x480px), allow resizing and remember the last width/height. This should solve the moved buig 112117.
Comment 4 bugzilla2 2019-02-05 09:38:18 UTC
800px width is less then before, but I'd be fine, if windows position and size is saved.

I have read in other bugs regarding hyperlink dialogue, that one was annoyed of the dialog showing the "mode" "Internet" by default. He said it was "Document" once. So maybe we can also save the last used "mode" of the Dialogue? So that a user that often uses "in document links" doesn't have to switch it all the time?

Last but not least, does the window check if its bigger then the screen? If no, I think it should do so. Imagine one works with a Notebook that is sometimes docked (big screen) and sometimes not (tiny screen). If the user makes the dialogue bigger on the big screen, it should not extend the screen once he is back on the tiny screen. The dialogue thus should rescale to fit the current screen.

The last two points are not that "urgent" (at least to me ;)). But Id be really happy, if the save/restore window size could make it into 6.2.1 (guess its to late for 6.2.0)...
Comment 5 bugzilla2 2019-02-05 09:50:55 UTC
Ohh, I had the "recommended" width by Heiko wrong in mind. He suggested 600px, not 800px as I wrote. Well, 600px is not a lot bigger then it is now in 6.2 (536px). Compared to 873px width as it was until 6.1.

Well, whatever size it will be in the future, im fine, if the (resized) windows size and position is saved/restored (for ALL documents, not just the current document) ;)
Comment 6 bugzilla2 2020-06-04 13:37:42 UTC
Oh nooooo, this Bug is back in 6.4.4 :( It was fine in 6.3 Series, and now the tiny window is back, and the windows-position is still not saved :(

Please make Writer remember the size of that window, so I don't have to adjust the size everytime I create a Link (which I do VERY OFTEN)...

This regression alone makes me thinking about moving back to 6.3.6...
Comment 7 bugzilla2 2020-06-04 14:07:45 UTC
my other hyperlink-dialog-related Bug: Bug 133675
Comment 8 bugzilla2 2020-06-27 10:28:34 UTC Comment hidden (obsolete)
Comment 9 bugzilla2 2020-07-10 12:26:44 UTC Comment hidden (obsolete)
Comment 10 bugzilla2 2021-02-18 13:12:25 UTC
Bug still present in 7.0 and 7.1 series :/

Since nothing is happening on that bug, is it possible to change the default-width in a XML-files? Or are these values hardcoded?
Comment 11 Heiko Tietze 2021-06-30 13:35:16 UTC
Created attachment 173292 [details]
Patch

We had a similar discussion for the print dialog (bug 134640). The dialog size depends on environment and dialog design and any user-settings will be obsolete when this changes.

I played with the code and this patch works as it restores the last size but the user cannot shrink the dialog size, only grow in size is possible.
Comment 12 bugzilla2 2021-07-01 14:01:07 UTC
Thanks Heiko for having an eye on this :)
Will this patch be integrated in a dev-build for review, or do I have to compile LO myself to test the patch? I doubt that I'm able to do the later :/
Comment 13 Heiko Tietze 2021-07-02 08:24:36 UTC
(In reply to bugzilla2 from comment #12)
> Thanks Heiko for having an eye on this :)
> Will this patch be integrated in a dev-build for review, or do I have to
> compile LO myself to test the patch? I doubt that I'm able to do the later :/

You have to apply the patch to the sources and compile the code. Since shrinking the dialog below the previous size is impossible I believe this approach is not working. And to my knowledge we do not have means to overcome the limitation nor is it wanted. Caolan, please resolve WF if this summary is correct.
Comment 14 bugzilla2 2023-07-01 09:05:59 UTC
Dialog size still not remembered in LibO 7.5 ...