Bug 125352 - File with linked frames and inserted image in the second frame crashes on close (see comment 2)
Summary: File with linked frames and inserted image in the second frame crashes on clo...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
3.5.0 release
Hardware: All All
: high major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: haveBacktrace, preBibisect, regression
Depends on:
Blocks: Frame Crash
  Show dependency tree / graph
 
Reported: 2019-05-18 12:33 UTC by Usama
Modified: 2022-06-30 18:09 UTC (History)
7 users (show)

See Also:
Crash report or crash signature: ["SwPageFrame::RemoveFlyFromPage(SwFlyFrame *)"]

Attachments
sample file with frames and image (10.90 KB, application/vnd.oasis.opendocument.text)
2019-05-18 12:33 UTC, Usama 		Details
Backtrace of crash with Win master (9.52 KB, text/plain)
2019-05-19 14:09 UTC, Buovjaga 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Usama 2019-05-18 12:33:02 UTC 
Created attachment 151496 [details]
sample file with frames and image

In writer:
1. Insert two frames
2. Link the frames
3. In the second frame insert an image from file or gallery
4. Save and from menu File >> Close 
5. Crash

Tested on both GNU/Linux and the currently popular OS too.

Version: 6.3.0.0.alpha0+
Build ID: 98630a0bd49bd80652145a21e4e0d0ded792b36b
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-05-04_04:44:35
Locale: tr-TR (tr_TR.UTF-8); UI-Language: en-US
Calc: threaded


Version: 6.3.0.0.alpha1+
Build ID: 31cc28ca7c02f28b64e9d757c9fc17e2a81ba352
CPU threads: 1; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-05-15_04:21:42
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded
Comment 1 Usama 2019-05-18 12:35:55 UTC 
Aslo crashs on:
Version: 5.1.6.2
Build ID: 1:5.1.6~rc2-0ubuntu1~xenial6
CPU Threads: 4; OS Version: Linux 4.4; UI Render: default; 
Locale: tr-TR (tr_TR.UTF-8); Calc: group
Comment 2 Buovjaga 2019-05-18 13:32:36 UTC 
More exact steps to repro from scratch:

1. Insert two frames (Insert - Frame)
2. Link the frames using the Link button in the Frame toolbar (with the first frame selected, then click the second with the tool activated) 
3. Focus inside the first frame so the text cursor is inside it
4. Hit Enter for newlines until you are in the second frame
5. Insert an image from file (Insert - Image) or gallery (right-click - Insert)
6. Save and File - Close

Already in 3.5.0, but not in 3.3.0 (Win 10)

There is no crash, if the image is inserted into the first frame.
Comment 3 Buovjaga 2019-05-19 14:09:29 UTC 
Created attachment 151512 [details]
Backtrace of crash with Win master

TB39 build from today
Version: 6.3.0.0.alpha1+
Build ID: 3f5f67c68ae42cd14c08341b597e0331358a0d3f
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: fi-FI (fi_FI); UI-Language: en-US
Calc: threaded
Comment 4 Xisco Faulí 2020-01-20 15:45:22 UTC 
*** Bug 130089 has been marked as a duplicate of this bug. ***
Comment 5 Xisco Faulí 2020-01-20 15:46:16 UTC 
@Michael, I thought you might be interested in this issue...
Comment 6 QA Administrators 2022-05-17 03:31:31 UTC Comment hidden (obsolete)
Comment 7 Gabor Kelemen (allotropia) 2022-06-30 18:09:46 UTC 
I can't reproduce the crash (opening and closing attachment 151496 [details]) in 7.1 since:

https://git.libreoffice.org/core/+/aeeea34074ebaeead66b81d78237361e096852ac

author	Caolán McNamara <caolanm@redhat.com>	Wed Jun 03 20:01:52 2020 +0100
committer	Caolán McNamara <caolanm@redhat.com>	Fri Jun 05 11:08:30 2020 +0200

crashtesting: null deref

Thanks Caolán!