Bug 125577 - EDITING: Impress: Background image turns to solid blue when editing Master Slide
Summary: EDITING: Impress: Background image turns to solid blue when editing Master Slide
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
5.3 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected
Depends on:
Blocks: Master-Slide
  Show dependency treegraph
 
Reported: 2019-05-29 12:57 UTC by Andrés Maldonado
Modified: 2022-09-13 06:39 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
Screenshot (125.86 KB, image/png)
2019-05-29 12:59 UTC, Andrés Maldonado
Details
fix_125577.patch (9.36 KB, patch)
2019-06-04 15:01 UTC, Andrés Maldonado
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrés Maldonado 2019-05-29 12:57:43 UTC
Description:
If I add a new Master, give it a background, delete it and create another one, the last one has a solid blue background.

Steps to Reproduce:
1. In Impress, go to View > Master Slide
2. Create a New Master
3. On the Slides panel, select the new Master
4. On the Properties panel, select Insert Image
5. Pick some image (tested with .jpg and .png)
6. Delete the Master
7. Create a New Master

Actual Results:
The new Master has a solid blue background

Expected Results:
The new Master should have the image as background


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
This is related to https://bugs.documentfoundation.org/show_bug.cgi?id=101711

This bug is present in:

Version: 6.3.0.0.alpha1+ (x64)
Build ID: 93139c011411b0e48c5fc8d39fe9203f55c7ff0a
CPU threads: 2; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

and on versions 5.3.x.

It is not present in LibreOffice 5.2.7.2

In branch 5.2, 78ec0b2b (https://gerrit.libreoffice.org/#/c/29490/) fixes the bug.
Comment 1 Andrés Maldonado 2019-05-29 12:59:30 UTC
Created attachment 151760 [details]
Screenshot
Comment 2 Andrés Maldonado 2019-06-04 15:01:56 UTC
Created attachment 151910 [details]
fix_125577.patch

I managed to fix this bug in branch libreoffice-6-2-4 by "porting" 78ec0b2b, but I'm not sure if it is the best solution...

However, as far as I tested, the fix doesn't cause regressions (the bugs described in https://bugs.documentfoundation.org/show_bug.cgi?id=125577 and https://bugzilla.redhat.com/show_bug.cgi?id=1353069 are gone)

Should I submit this to Gerrit ?
Comment 3 Xisco Faulí 2019-09-04 11:23:17 UTC
(In reply to Andrés Maldonado from comment #2)
> Created attachment 151910 [details]
> fix_125577.patch
> 
> I managed to fix this bug in branch libreoffice-6-2-4 by "porting" 78ec0b2b,
> but I'm not sure if it is the best solution...
> 
> However, as far as I tested, the fix doesn't cause regressions (the bugs
> described in https://bugs.documentfoundation.org/show_bug.cgi?id=125577 and
> https://bugzilla.redhat.com/show_bug.cgi?id=1353069 are gone)
> 
> Should I submit this to Gerrit ?

Absolutely, other can check whether it's correct or not
Comment 4 Xisco Faulí 2020-02-17 10:56:01 UTC
Dear Andrés Maldonado,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assign it back to yourself if you're still working on this.
Comment 5 QA Administrators 2022-02-17 03:39:52 UTC Comment hidden (obsolete)
Comment 6 Roman Kuznetsov 2022-02-22 20:26:23 UTC
Still rerpo in

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: b438854a0b5148880e455cbeeff14d4e3d825711
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL Jumbo
Comment 7 Aron Budea 2022-09-13 05:13:05 UTC
(In reply to Andrés Maldonado from comment #0)
> Actual Results:
> The new Master has a solid blue background
> 
> Expected Results:
> The new Master should have the image as background
I wonder why the expectation is to show the background of the deleted master slide again, I'd expect it to have the default white background, no?

I haven't checked which commit introduced this, but can confirm that in libreoffice-5-2 the reverts brought back the previous behavior.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=0402ba63551b614c9742b198e48232ac87a2b32b
author		Caolán McNamara <caolanm@redhat.com>	2016-09-30 12:45:03 +0100
committer	David Tardon <dtardon@redhat.com>	2016-10-05 06:47:34 +0000

Resolves: tdf#101711 revert attempt to drop unused bg images
Comment 8 Heiko Tietze 2022-09-13 06:39:01 UTC
(In reply to Aron Budea from comment #7)
> I wonder why the expectation is to show the background of the deleted master
> slide again, I'd expect it to have the default white background, no?

Exactly. In other words, creating a master slide should always default to color = None.