Bug 126014 - Crash on & opening recovered file after removing title from long(?) Table Of Contents [EDITING] [FILEOPEN]
Summary: Crash on & opening recovered file after removing title from long(?) Table Of ...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.0.7.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: tdf#114306-regressions
  Show dependency treegraph
 
Reported: 2019-06-19 20:02 UTC by gamemanj
Modified: 2019-06-25 15:24 UTC (History)
2 users (show)

See Also:
Crash report or crash signature: ["SwTextFrame::AdjustFrame(long,bool)"]


Attachments
sample file (27.49 KB, application/vnd.oasis.opendocument.text)
2019-06-20 09:25 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description gamemanj 2019-06-19 20:02:54 UTC
Description:
LibreOffice crashes after removing title from a long Table Of Contents in the file referenced in the reproduction steps.
The resulting file on recovery also crashes.
I'm not sure of the details.

Steps to Reproduce:
1. Open https://20kdc.duckdns.org/Crasher.odt
2. Edit the Table Of Contents index
3. Remove the text from the index's title
4. Confirm - Program will crash.

Actual Results:
Program will crash.
Recovered file should be similar to https://20kdc.duckdns.org/Crasher.odt_0.odt and this will crash the program too.


Expected Results:
Removal of title from Table Of Contents.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Text contents of file were changed before reporting, but I confirmed the new file does still have the same effect.
It seems reduction of the size *too much* causes the crash not to happen - if it doesn't happen, maybe copy/paste some chapters, IDK?

UserProfile reset was performed as going into safe mode, rather than a true reset - this should be sufficient?

I am assuming that "Use hardware acceleration" means OpenGL is on because the option you specify on the "checking" page doesn't exist.

Version: 6.2.4.2.0+
Build ID: 6.2.4-1
CPU threads: 8; OS: Linux 5.1; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

Arch Linux package in use:
extra/libreoffice-fresh 6.2.4-1 [installed]
    LibreOffice branch which contains new features and program enhancements

Backtrace (for a 'opened corrupted file' run): https://20kdc.duckdns.org/crasher-gdbtrace.log

Valgrind seems to slow things down a *lot* - ask if you can't recreate it
Comment 1 Oliver Brinzing 2019-06-20 08:12:59 UTC
steps to reproduce:

- Open document: https://20kdc.duckdns.org/Crasher.odt
- Context Menu: Edit index
- change Title: Hello[OK]
- Context Menu: Edit index
- delete Title text [OK]
- crash / Table of content dialog freezes

confirming with:

Version: 6.2.4.2 (x64)
Build-ID: 2412653d852ce75f65fbfa83fb7e7b669a126d64
CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: 

Version: 6.1.6.3 (x64)
Build ID: 5896ab1714085361c45cf540f76f60673dd96a72
CPU threads: 4; OS: Windows 10.0; UI render: default; 
Locale: de-DE (de_DE); Calc: 

Version: 6.0.7.3 (x64)
Build-ID: dc89aa7a9eabfd848af146d5086077aeed2ae4a5
CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; 
Gebietsschema: de-DE (de_DE); Calc: 

*not* reproducible with:
Version: 5.4.7.2 (x64)
Build-ID: c838ef25c16710f8838b1faec480ebba495259d0
CPU-Threads: 4; BS: Windows 6.19; UI-Render: Standard; 
Gebietsschema: de-DE (de_DE); Calc: single
Comment 2 Xisco Faulí 2019-06-20 09:20:16 UTC
On linux it hangs instead of crashing. The hang got fixed by https://cgit.freedesktop.org/libreoffice/core/commit/?id=b7d4418c309c8bc4fd25485dd3a0ea6ad9edf34e

Could you please try to reproduce it with a master build from http://dev-builds.libreoffice.org/daily/master/ ?
You can install it alongside the standard version.
Comment 3 Xisco Faulí 2019-06-20 09:25:17 UTC
Not crashing in

Version: 6.4.0.0.alpha0+ (x64)
Build ID: e6adec29beadb83ebd3941275b99e2dd1be02f61
CPU threads: 16; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: en-GB (en_GB); UI-Language: en-US
Calc: threaded

Closing as RESOLVED FIXED
Comment 4 Xisco Faulí 2019-06-20 09:25:48 UTC
Created attachment 152306 [details]
sample file
Comment 5 Xisco Faulí 2019-06-20 09:32:42 UTC
(In reply to Xisco Faulí from comment #2)
> On linux it hangs instead of crashing. The hang got fixed by
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=b7d4418c309c8bc4fd25485dd3a0ea6ad9edf34e

Same result on windows...
Comment 6 Xisco Faulí 2019-06-20 10:00:18 UTC
This is also fixed in

Version: 6.2.6.0.0+ (x86)
Build ID: 0d4d982b9cde760f558d5ad51b238951c1753577
CPU threads: 16; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: en-GB (en_GB); UI-Language: en-US
Calc: threaded

so, it will be fine in LibreOffice 6.2.5.
Comment 7 gamemanj 2019-06-20 15:23:50 UTC
Can confirm that:

Version: 6.4.0.0.alpha0+
Build ID: b674d3c12a5819fbcb551e83bf6862afc85ef7f3
CPU threads: 8; OS: Linux 5.1; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF-dbg, Branch:master, Time: 2019-06-15_21:06:59
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

doesn't hang or crash here.
Comment 8 Xisco Faulí 2019-06-25 15:24:28 UTC
(In reply to gamemanj from comment #7)
> Can confirm that:
> 
> Version: 6.4.0.0.alpha0+
> Build ID: b674d3c12a5819fbcb551e83bf6862afc85ef7f3
> CPU threads: 8; OS: Linux 5.1; UI render: default; VCL: gtk3; 
> TinderBox: Linux-rpm_deb-x86_64@86-TDF-dbg, Branch:master, Time:
> 2019-06-15_21:06:59
> Locale: en-US (en_US.UTF-8); UI-Language: en-US
> Calc: threaded
> 
> doesn't hang or crash here.

Setting to VERIFIED. thanks for checking