Created attachment 152944 [details]
WinDbg32 stack trace of TB39 build with symbols

Created attachment 152945 [details]
windbg32 ST for non-OpenGL

Just to be sure, checked and also crash/recover mergedlo!vcl::Window::RemoveEventListener with Default rendering. 

ST attached.

@Ashod, this may be your recent work on the Sidebar...

None of Ashod's stuff has posted yet.

@Samuel? Assume change to selected icon theme would be tracked in Sidebar state

https://gerrit.libreoffice.org/#/c/75719/ looks suspect...

Adjusting importance per QA guide, still needs a bibisect...

Created attachment 153012 [details]
bt with debug symbols

On pc Debian x86-64 with master sources updated yesterday, I could reproduce this.

By reverting partially the quote commit, so with this patch:
diff --git a/sfx2/source/sidebar/SidebarController.cxx b/sfx2/source/sidebar/SidebarController.cxx
index 22b022bf09ee..5af03faa08ea 100644
--- a/sfx2/source/sidebar/SidebarController.cxx
+++ b/sfx2/source/sidebar/SidebarController.cxx
@@ -733,6 +733,7 @@ void SidebarController::SwitchToDeck (
     const DeckDescriptor& rDeckDescriptor,
     const Context& rContext)
 {
+    maFocusManager.Clear();
     const bool bForceNewDeck ((mnRequestedForceFlags&SwitchFlag_ForceNewDeck)!=0);
     const bool bForceNewPanels ((mnRequestedForceFlags&SwitchFlag_ForceNewPanels)!=0);
     mnRequestedForceFlags = SwitchFlag_NoForce;

I don't reproduce the crash.

The backtrace doesn't hint at a change I had done, though valgrind might show something not visible in the bt.

If the partial revert to Samuel's commit resolves it, then great.

Let me know if need anything from me please.

Regression introduced by:

author	Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>	2019-07-16 17:41:48 +0200
committer	Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>	2019-07-18 10:27:25 +0200
commit b58aa94f1f365c746135470bceb97cc182c289bc (patch)
tree 2f4b915889695ac214988d66312498864ead62ed
parent 2b4efc32e822bf41c4b729137718f3c70f692a89 (diff)
tdf#126424 Don't dispose decks before saving their state

Bisected with: bibisect-linux64-6.4

Adding Cc: to Samuel Mehrbrodt

The patch is present in 6.3.0.2. IMHO, this should block the 6.3 until it's fixed

There is already a patch from Julien in comment 7.
@Julien: Would you please push that patch to gerrit for review? Or should I do that?

(In reply to Samuel Mehrbrodt (CIB) from comment #10)
> There is already a patch from Julien in comment 7.
> @Julien: Would you please push that patch to gerrit for review? Or should I
> do that?

Hi Samuel,
Considering LibreOffice 6.3 RC3 is going to be tagged this week, I was wondering if you could submit the patch yourself ( I could do it as well if needed ), I'd rather not to wait for someone else ( just in case he's on vacation / absent ) otherwise we wouldn't make it in time

(In reply to Xisco Faulí from comment #11)
> (In reply to Samuel Mehrbrodt (CIB) from comment #10)
> > There is already a patch from Julien in comment 7.
> > @Julien: Would you please push that patch to gerrit for review? Or should I
> > do that?
> 
> Hi Samuel,
> Considering LibreOffice 6.3 RC3 is going to be tagged this week, I was
> wondering if you could submit the patch yourself ( I could do it as well if
> needed ), I'd rather not to wait for someone else ( just in case he's on
> vacation / absent ) otherwise we wouldn't make it in time

Done: https://gerrit.libreoffice.org/#/c/76589/ and https://gerrit.libreoffice.org/#/c/76590/

Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/+/857f68d68b3d0092f109845cfd93482871a0793d%5E%21

tdf#126508 Fix crash when changing icon style

It will be available in 6.3.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "libreoffice-6-3-0":

https://git.libreoffice.org/core/+/63ccc97e1699d90da2532e4294cdaff670ad1a3f%5E%21

tdf#126508 Fix crash when changing icon style

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/b25284244a4a0e5ff480538133ee18f471a4bfc8%5E%21

tdf#126508 Fix crash when changing icon style

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Verified in

Version: 6.4.0.0.alpha0+
Build ID: 7680623292f272cf1a8cceb4abb5a67bb5469918
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@Samuel, @Julien, thanks for fixing this issue!

Also verified fixed on Windows builds
Version: 6.4.0.0.alpha0+ (x86)
Build ID: 5c30c20101f72d973ff28c228f755e635cad14d5
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

(In reply to Xisco Faulí from comment #16)
> ...
> @Samuel, @Julien, thanks for fixing this issue!

+1

*** Bug 126816 has been marked as a duplicate of this bug. ***