Download it now!
Bug 126904 - In LO Calc: Right arrow causes a large unexpected column jump in protected sheet.
Summary: In LO Calc: Right arrow causes a large unexpected column jump in protected sh...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.3.0.4 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.0.0 target:6.4.3 target:6.3....
Keywords: bibisected, bisected, needUITest, regression
: 127246 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-08-14 01:30 UTC by Daniel Baran
Modified: 2020-03-25 11:54 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Partially protected spreadsheet file with macros. (60.89 KB, application/vnd.oasis.opendocument.spreadsheet)
2019-08-14 01:42 UTC, Daniel Baran
Details
This file is an updated version of the original test case. (63.33 KB, application/vnd.oasis.opendocument.spreadsheet)
2020-03-03 05:56 UTC, Daniel Baran
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Baran 2019-08-14 01:30:25 UTC
Description:
In Calc 6.3.0.4: Issuing a right arrow either manually or via macro code causes a large
column jump on a mostly protected sheet. Right arrow navigation should halt at the last
unprotected column ("N" in this case) as it does in version 6.2.5. Instead, a further right
arrow causes a jump to column "BM". Further right arrows allow column jumps to the right
even though all those cells are all protected.

Steps to Reproduce:
1.Open the file and press right arrow to column "N" (7 times)
2.Pressing once more (8th time) will cause an unexpected cursor jump to column "BM".
3.In this partially protected sheet, columns beyond "N" should not be selectable.


Actual Results:
Same as Above!

Expected Results:
In previous LO Calc version (6.2.5), the cursor would not move further after pressing the
right arrow key once the last unprotected column was reached (expected behavior).



Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Comment 1 Daniel Baran 2019-08-14 01:42:43 UTC
Created attachment 153367 [details]
Partially protected spreadsheet file with macros.

This file can be used to demonstrate the issue described in the bug report.
This file is publicly available on my website and therefore has no associated privacy concerns.
Comment 2 Oliver Brinzing 2019-08-14 13:07:40 UTC
reproducible with:

Version: 6.3.0.4 (x64)
Build ID: 057fc023c990d676a43019934386b85b21a9ee99
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-US
Calc: 

but *not* reproducible with:

Version: 6.2.6.2 (x64)
Build ID: 684e730861356e74889dfe6dbddd3562aae2e6ad
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-US
Calc:
Comment 3 Oliver Brinzing 2019-08-14 13:25:19 UTC
seems to have started with:

https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=7282014e362a1529a36c88eb308df8ed359c2cfa

commit	7282014e362a1529a36c88eb308df8ed359c2cfa	[log]
author	 Noel Grandin <noel.grandin@collabora.co.uk>	
Fri Feb 01 15:15:16 2019 +0100
committer Mike Kaganski <mike.kaganski@collabora.com>	
Fri Apr 05 13:43:52 2019 +0200
tree	2776ad9601f494330076ac58c08554e719c6ab3a
parent	df30a4515b1303b0891baa53754fa9b3e47e0c02 [diff]

tdf#50916 Makes numbers of columns dynamic.

/cygdrive/d/sources/bibisect/bibisect-win32-6.3
$ git bisect bad
d53ef167063b0e2c18e7e703af4407b40c664fb2 is the first bad commit
commit d53ef167063b0e2c18e7e703af4407b40c664fb2
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Fri Apr 5 04:58:29 2019 -0700

    source sha:7282014e362a1529a36c88eb308df8ed359c2cfa

    source sha:7282014e362a1529a36c88eb308df8ed359c2cfa

:040000 040000 c4c16af7ac031bce3a437b19126c311eb2be7761 a8f451eec155bd2b6c5aa3762b50b0dcb346fdf6 M      instdir

/cygdrive/d/sources/bibisect/bibisect-win32-6.3
$ git bisect log
# bad: [18f926e8e18b3d855c2f79ef279febbeb846b8cd] source sha:13152ad88b24cadc836a829b4424a72a152ca9b1
# good: [ea94942caaf195b8d8b2d5c2abb523359ab390e7] source sha:a20a2d7e0d28658f2d9089da076961a599833a28
git bisect start 'master' 'oldest'
# good: [3aea60569b9190400409ebb93f0a5d323b6fc5d4] source sha:47ce4b87d8a13fc340794ffd9a10d5bd6a15e644
git bisect good 3aea60569b9190400409ebb93f0a5d323b6fc5d4
# bad: [3b794d71dd796e467baef082c140bdc77c69c979] source sha:47d25dc5abe000ce751cb1e4dbd1f85f7198ca05
git bisect bad 3b794d71dd796e467baef082c140bdc77c69c979
# good: [8adbffa485cdd6d5e13106e5f55e70249f46a4f6] source sha:15e9e6d12aa2d49e114ec0cf8326f2264ccf2640
git bisect good 8adbffa485cdd6d5e13106e5f55e70249f46a4f6
# bad: [446d84046fe885e09f7cb71061f6c80ff83137e3] source sha:5bd1caf14c8e297db229e9060a584386247e62b1
git bisect bad 446d84046fe885e09f7cb71061f6c80ff83137e3
# good: [290c14249daec35d65309db03bbb2d8dd9577869] source sha:a67125aa5c5ef8f2a19dcbcad778cd66a304761b
git bisect good 290c14249daec35d65309db03bbb2d8dd9577869
# bad: [f6df399b757e904217e23ef90ec5c2959a06120b] source sha:bdc5cfab8106d73af3452155cedf732972bd3a91
git bisect bad f6df399b757e904217e23ef90ec5c2959a06120b
# good: [1810944f7cb6564d91faa6a0382f93c2e568cbed] source sha:ec2222e54dd6a496fd7931a966eee272172025d2
git bisect good 1810944f7cb6564d91faa6a0382f93c2e568cbed
# good: [a75e186c5c38e92920febd251b46c62d5d97123c] source sha:ae1e23651a6d2e97d39bbe46bab83b7982d19611
git bisect good a75e186c5c38e92920febd251b46c62d5d97123c
# good: [d9241b2e69509012daad3a175057b92f19b4dc68] source sha:5d0700bd3afef6d39b63fe813aaa0ac856ff5785
git bisect good d9241b2e69509012daad3a175057b92f19b4dc68
# good: [60ea1bb50f32aaf457e89c283df73e940f768fea] source sha:3e0092031b73bad107e3122d5d4be2f5bd487744
git bisect good 60ea1bb50f32aaf457e89c283df73e940f768fea
# good: [8ad9247fb583df581282a091ee744bd1b247b89f] source sha:6aff7fe6d5a02f44ec43e63672ae56166f9b9cb6
git bisect good 8ad9247fb583df581282a091ee744bd1b247b89f
# good: [ab220a076cad3a184f2f357192861dabc1f96e3c] source sha:df30a4515b1303b0891baa53754fa9b3e47e0c02
git bisect good ab220a076cad3a184f2f357192861dabc1f96e3c
# bad: [d53ef167063b0e2c18e7e703af4407b40c664fb2] source sha:7282014e362a1529a36c88eb308df8ed359c2cfa
git bisect bad d53ef167063b0e2c18e7e703af4407b40c664fb2
# first bad commit: [d53ef167063b0e2c18e7e703af4407b40c664fb2] source sha:7282014e362a1529a36c88eb308df8ed359c2cfa
Comment 4 Oliver Brinzing 2019-08-31 08:54:14 UTC
*** Bug 127246 has been marked as a duplicate of this bug. ***
Comment 5 Daniel Baran 2020-02-01 23:39:30 UTC
Feb 1, 2020:
Testing on 6.3.4 and 6.4.0 shows the problem persists.
Thanks to any and all who are working on a fix.
Daniel Baran
(timespreader.com)
Comment 6 Daniel Baran 2020-02-28 22:58:18 UTC
Can anyone address the likelihood of this one being fixed?
There does not seem to be any indication of activity.
If anyone has ideas for mitigating it from my end (i.e. a work-around), I would be grateful for that also.
Thanks,
DB
Comment 7 Commit Notification 2020-03-02 09:57:41 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7ae33e175007d04021f5e911e3f7f6cbd0966804

tdf#126904 calc right arrow large unexpected column jump in protected sheet

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Daniel Baran 2020-03-03 05:56:55 UTC
Created attachment 158322 [details]
This file is an updated version of the original test case.

This file is an updated version of the original ODS workbook that revealed the bug.
The bug is evident when using this file in LO 6.3.5.2 (and seemingly anything after 6.2.8).
It can be used for testing of patched, or other future releases if desired.
Comment 9 Xisco Faulí 2020-03-04 11:49:38 UTC
Verified in

Version: 7.0.0.0.alpha0+
Build ID: c57d6d39c80844c9d4c6bfed85cc151e52a67b34
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

@Noel, thanks for fixing this issue!!
Comment 10 Commit Notification 2020-03-04 14:22:24 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/c3a1880bd26f80272829205b221ebd2b8d1cfafe

tdf#126904 calc right arrow large unexpected column jump in protected sheet

It will be available in 6.4.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2020-03-04 19:35:01 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/commit/c91d0dd01d884916c699bb70219c792aba704846

tdf#126904 calc right arrow large unexpected column jump in protected sheet

It will be available in 6.3.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2020-03-10 10:51:43 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/976cabe84f3b6e5591ccf2b043d72cbca3e31ba0

tdf#126904: Add unittest

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2020-03-11 12:56:52 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-6-4-2":

https://git.libreoffice.org/core/commit/a9f33ad967aeb7582e6522b81beebc8c15cc5016

tdf#126904 calc right arrow large unexpected column jump in protected sheet

It will be available in 6.4.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 14 Daniel Baran 2020-03-11 21:17:23 UTC
I have verified in:

Version: 7.0.0.0.alpha0+ (x64)
Build ID: c63148ba139bd6b9ae7a0f9e24e51f29e5370963
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

Much appreciation for this fix!

PS:
Unfortunately, while doing the test I may have discovered a new / different bug.
I have filed a separate report on that - Bug 131296.
Comment 15 Daniel Baran 2020-03-13 21:12:53 UTC
Verified in:

Version: 6.4.2.2 (x64)
Build ID: 4e471d8c02c9c90f512f7f9ead8875b57fcb1ec3
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

All macros and other features working as expected!
Comment 16 Daniel Baran 2020-03-16 00:19:18 UTC
The following updated test result applies to both of the following versions:

Version: 6.4.2.2
Build ID: 4e471d8c02c9c90f512f7f9ead8875b57fcb1ec3
CPU threads: 4; OS: Linux 5.3; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

Version: 6.4.2.2 (x64)
Build ID: 4e471d8c02c9c90f512f7f9ead8875b57fcb1ec3
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

The original (column jump) problem seems to be resolved when the file is first opened.
However, after executing the "End of Day" macro, the column jump problem returns.

This does not happen in:

Version: 6.2.8.2 (x64)
Build ID: f82ddfca21ebc1e222a662a32b25c0c9d20169ee
CPU threads: 8; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

Steps to reproduce:
1. Open the workbook.
2. Press -  Right Arrow to column "N". Further Right Arrows do nothing (expected).
3. Execute "End of Day" macro, then return to Sheet1.
4. Right Arrows beyond column "N" cause a large jump to column "BM" (unexpected)
Comment 17 Daniel Baran 2020-03-19 16:23:02 UTC
Please see Comment 16

Also getting the same result in:

Version: 7.0.0.0.alpha0+ (x64)
Build ID: c63148ba139bd6b9ae7a0f9e24e51f29e5370963
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded
Comment 18 Xisco Faulí 2020-03-19 16:24:42 UTC
Please, create a follow-up report
Comment 19 Daniel Baran 2020-03-19 23:13:35 UTC
Just to be clear;
Are you asking me to create a "new" bug report on this, or something else?
If something else, please describe what exactly a "follow-up report" is.
Comment 20 Xisco Faulí 2020-03-20 09:48:52 UTC
(In reply to Daniel Baran from comment #19)
> Just to be clear;
> Are you asking me to create a "new" bug report on this, or something else?
> If something else, please describe what exactly a "follow-up report" is.

Yes, please, create a new report
Comment 21 Daniel Baran 2020-03-21 04:47:29 UTC
The follow-up report describing similar behavior to this bug is:   Bug 131455.