Bug 126915 - REDACTION TOOLBAR: Redaction button 'Export Directly as PDF' is confusing (solution see comment 14)
Summary: REDACTION TOOLBAR: Redaction button 'Export Directly as PDF' is confusing (so...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.3.0.4 release
Hardware: All All
: medium normal
Assignee: Muhammet Kara
URL:
Whiteboard: target:7.3.0
Keywords:
: 127126 (view as bug list)
Depends on:
Blocks: Toolbars-Tooltips Redaction 145672
  Show dependency treegraph
 
Reported: 2019-08-14 10:09 UTC by Thomas Lendo
Modified: 2021-11-14 10:17 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments
Zip archive with test files (odt, odg, pdf) (67.24 KB, application/x-zip-compressed)
2019-08-21 09:44 UTC, Thomas Lendo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Lendo 2019-08-14 10:09:57 UTC
The opacity of objects to redact something is not 100%. It looks grey-transparent which is not the expected result when a user wants to hide something.
Comment 1 Xisco Faulí 2019-08-14 10:14:46 UTC
Could you please attach a screenshot ?
Comment 2 Jean-Baptiste Faure 2019-08-17 21:01:07 UTC
(In reply to Thomas Lendo from comment #0)
> The opacity of objects to redact something is not 100%. It looks
> grey-transparent which is not the expected result when a user wants to hide
> something.

Do you mean on the exported PDF or on the screen ?

Set status to NEEDINFO. Please set it back to UNCONFIRMED once you have provided the requested information (comments #1 and #2).

Best regards. JBF
Comment 3 Thomas Lendo 2019-08-21 09:44:50 UTC
Created attachment 153549 [details]
Zip archive with test files (odt, odg, pdf)

The attached zip archive contains the source odt file with text, the redaction odg file with some marks and the exported pdf file.

In both the Draw file as well as in the exported pdf file, the default setting for opacity is 50%. If I change that to 0% and close the Draw file and create a new redaction from the odt file, the opacity is back to 50%.

Expected result:
Opacity should be 0% per default for all redaction tools.
Comment 4 Aron Budea 2019-08-23 16:51:43 UTC
*** Bug 127126 has been marked as a duplicate of this bug. ***
Comment 5 Dieter 2019-08-29 20:21:44 UTC
Thomas, I had a look at area properties in your document:
Color is dark grey 1
Transparency is 50%

So I agree, that default settings should be changed.

cc: Design Team for further input
Comment 6 Aron Budea 2019-08-29 20:50:15 UTC
Thomas, Dieter, have you tried Redacted Export? I get nice black/white rectangles in the PDFs. The 50% opacity during the redaction makes sense, because it's easier to adjust the coverage if you can see what's behind them. Perhaps making Export Directly to PDF, which doesn't perform redaction less prominent would be reasonable.
Comment 7 Thomas Lendo 2019-08-29 21:06:23 UTC
Aron, sounds reasonable. But then I don't get the idea behind the button 'Export Directly as PDF'?! This command is confusing in multiple ways. In other bug report about Redaction it was already mentioned that the naming of this button is misleading. But as said there, the name couldn't or shouldn't be changed.

Now I get it: Remove this button completely. What is this button good for? Either I want to see the result of my redaction action (then I can click 'Redacted Export (White)' or '... (Black)') or I want to see what I redacted (then I can see this already in the Draw view).

So, if I'm not completely wrong, the summary of this bug report should be changed from 'Redaction object opacity is not 100%' to 'Remove the Export Directly as PDF command from the Redaction toolbar'.
Comment 8 Heiko Tietze 2019-08-30 07:03:46 UTC
This topic is being discussed on the Telegram channel. Pedro suggested: "I think just renaming Export Directly as PDF, to Export Preview PDF would be enough".
Comment 9 Dieter 2019-08-30 07:25:06 UTC
I agree to remove "Export Directly to PDF", because this is option is also accessible in File menu. If you rename it you have two different names for the same command, and of course there will be bug reports about "unconsistent" naming.
Comment 10 Muhammet Kara 2019-08-30 07:47:44 UTC
(In reply to Thomas Lendo from comment #7)
> Aron, sounds reasonable. But then I don't get the idea behind the button
> 'Export Directly as PDF'?! This command is confusing in multiple ways. In
> other bug report about Redaction it was already mentioned that the naming of
> this button is misleading. But as said there, the name couldn't or shouldn't
> be changed.

It is the opposite actually. It was discussed that the button cannot be removed because it is a requirement of the project (it has a use case), but we can rename it to make its purpose clear.

> 
> Now I get it: Remove this button completely. What is this button good for?
> Either I want to see the result of my redaction action (then I can click
> 'Redacted Export (White)' or '... (Black)') or I want to see what I redacted
> (then I can see this already in the Draw view).
> 
> So, if I'm not completely wrong, the summary of this bug report should be
> changed from 'Redaction object opacity is not 100%' to 'Remove the Export
> Directly as PDF command from the Redaction toolbar'.
Comment 11 Thomas Lendo 2019-08-30 10:26:40 UTC
Thanks for the info, Muhammet. From point of UX view, the best user experience is when something is self-explanatory.

What's the use case of the button and which name should be given to make it's purpose clear?

Changing summary as opacity isn't the question of the issue anymore.
Comment 12 Dieter 2019-09-01 06:14:11 UTC
After reading bug 127173 I recommend to also rename "Redacted Export" to "Redacted PDF Export" or something like that, so we have

Redacted PDF Export
Preview PDF Export

or

Export Redacted PDF
Export Preview PDF

I think this clarifiation is needed. Only a few users wil write a bug report. Most users, who misunderstand PDF export will just give up using Redaction tool.
Comment 13 Pedro 2019-09-02 10:42:07 UTC
I agree with Dieter.
Just changing the tooltips with the names is enough.
The functionality itself is stellar.
Comment 14 Heiko Tietze 2019-09-05 12:38:44 UTC
Let's go with Dieter's proposal and label it "Export Redacted PDF / Export Preview PDF".
Comment 15 Dieter 2021-08-10 07:01:11 UTC
Still valid in

Version: 7.2.0.1 (x64) / LibreOffice Community
Build ID: 32efc3b7f3a71cfa6a7fa3f6c208333df48656cc
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

Tooltips of buttons in toolbar
Redacted Export (White) => Export Redacted PDF (White)
Redacted Export (Black) => Export Redacted PDF (Black)
Export Directly as PDF => Export Directly as Preview PDF 

We also have the menu entries in the file menu, but I don't know if it is possible to change something here, too.
Comment 16 Commit Notification 2021-08-22 01:46:36 UTC
Muhammet Kara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3748535a5739f3cb1471516b2e7ae2601575b639

tdf#126915: Redaction: Clarify 'Export Directly as PDF'

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 17 BogdanB 2021-08-24 05:19:40 UTC
It's clear now.
It's just a preview.

Verified in
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: fbe183bbb05220a4ccc51952445b1797bb498403
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 18 BogdanB 2021-08-24 05:19:49 UTC Comment hidden (obsolete)