Bug 127726 - Default shortcut keys Ctrl+; and Ctrl+Shift+; (to insert current date/time) clash on Estonian keyboard layout
Summary: Default shortcut keys Ctrl+; and Ctrl+Shift+; (to insert current date/time) c...
Status: RESOLVED DUPLICATE of bug 126085
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Shortcuts-Locale
  Show dependency treegraph
 
Reported: 2019-09-23 21:06 UTC by Mihkel Tõnnov
Modified: 2020-07-03 09:01 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Define Ctrl+Comma and Ctrl+Shift+Comma with Estonian layout (1.05 KB, patch)
2020-05-11 13:28 UTC, Mihkel Tõnnov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mihkel Tõnnov 2019-09-23 21:06:55 UTC
Issue is similar to bug 88027, bug 126085 & bug 126888, but for Estonian locale/layout.

Like German, Finnish and many other layouts, Estonian keyboards don't have a ";" key - that physical key is instead allocated for the letter "ö" and the semicolon character is being produced by Shift+comma instead, and colon by Shift+period instead.

Thus, in Calc, there is clash between default shortcuts Ctrl+; for inserting current date and Ctrl+Shift+; for current time: only current time can be inserted by keyboard shortcut, as Shift has to be pressed anyway to get ";".

Tested with LibO 6.3.1:
- in Linux (Arch/KDE5) pressing Ctrl+Shift+, (== Ctrl+;) inserts current time,
- in Windows (10) the same shortcut does nothing.
(Should it then be two separate bug reports?)

For comparison, in Excel (2010) with Estonian locale:
Ctrl+Shift+, (== Ctrl+;) inserts current date
Ctrl+Shift+. (== Ctrl+:) inserts current time
Comment 1 Buovjaga 2020-04-27 18:08:07 UTC
Did you try with Estonian UI? It works for me with Finnish UI, Ctrl+, is date, Ctrl+; is time. Mentioned in bug 88027 comment 29
Comment 2 Mihkel Tõnnov 2020-04-27 20:20:43 UTC
On my system (up-to-date Arch Linux with KDE5, and LibO 7.0 daily), the UI language makes no difference - the keyboard layout does. Is it working for you with a Finnish layout?

An interesting thing to note is that when I choose Tools - Customize - Keyboard, and press Ctrl+, in the list, then it actually highlights the row with "Ctrl+," (which has no action assigned by default - but it can be done manually now, so that's an improvement). When I press Ctrl+Shift+, then it highlights the row with "Ctrl+;" (which has "Insert Current Time" assigned). This happens with all the VCL plugins I tested with (kf5, gtk3, gen), so shouldn't be KDE-specific either.
Comment 3 Mihkel Tõnnov 2020-04-27 20:34:18 UTC
Ah, I see now that Finnish has a special case added to the code, and I guess it works for you because your OS language is also Finnish (right?): https://cgit.freedesktop.org/libreoffice/core/commit/?id=61a91be4aaf6bdb40d6d1bde33b44eaf14014525

So basically the same thing should be done for Estonian - and presumably for a bunch of other (European?) languages, too. I'll prepare a patch (at least for Estonian) soonish.
Comment 4 Buovjaga 2020-04-28 06:23:07 UTC
Ah, indeed -> NEW
Comment 5 Mihkel Tõnnov 2020-05-11 13:28:06 UTC
Created attachment 160665 [details]
Define Ctrl+Comma and Ctrl+Shift+Comma with Estonian layout
Comment 6 Mihkel Tõnnov 2020-05-11 13:29:36 UTC
Could someone commit the patch?
Comment 7 Buovjaga 2020-05-11 14:11:19 UTC
(In reply to Mihkel Tõnnov from comment #6)
> Could someone commit the patch?

I guess so, but as I see you already sent a license statement, you could also create a patch directly inside gerrit as the change is so simple:
https://wiki.documentfoundation.org/Development/gerrit
https://wiki.documentfoundation.org/Documentation/GerritEditing
Comment 8 Mihkel Tõnnov 2020-05-11 14:20:05 UTC
With the proposed patch:
Insert current date: Ctrl+Comma ( = Ctrl+, in the Customize - Keyboard dialog)
Insert current time: Ctrl+Shift+Comma ( = Ctrl+Shift+; in the Customize - Keyboard dialog)

Can't use the same shortcuts as in Excel (Ctrl+Shift+Comma & Ctrl+Shift+Point), because neither Ctrl+: nor Ctrl+Shift+. can currently be assigned as shortcuts in the Customize - Keyboard dialog. To enable that, colon key (= Shift+Point on Estonian layout, as on many others) should be defined in cui/source/customize/acccfg.cxx.
Comment 9 Mihkel Tõnnov 2020-05-11 14:20:48 UTC
(In reply to Buovjaga from comment #7)
> (In reply to Mihkel Tõnnov from comment #6)
> > Could someone commit the patch?
> 
> I guess so, but as I see you already sent a license statement, you could
> also create a patch directly inside gerrit as the change is so simple:
> https://wiki.documentfoundation.org/Development/gerrit
> https://wiki.documentfoundation.org/Documentation/GerritEditing

Oh, cool, I wasn't aware that I can do that :) Thanks!
Comment 10 Mihkel Tõnnov 2020-05-11 16:13:30 UTC
(In reply to Mihkel Tõnnov from comment #8)
> Can't use the same shortcuts as in Excel (Ctrl+Shift+Comma &
> Ctrl+Shift+Point), because neither Ctrl+: nor Ctrl+Shift+. can currently be
> assigned as shortcuts in the Customize - Keyboard dialog. To enable that,
> colon key (= Shift+Point on Estonian layout, as on many others) should be
> defined in cui/source/customize/acccfg.cxx.
Found that this is true only with the KF5 VCL-plugin:
VCL   Tools - Customize - Keyboard detects keypress as...
kf5   Ctrl+.   Ctrl+,             Ctrl+Shift+;    (nothing)
gtk3  Ctrl+.   Ctrl+,             Ctrl+Shift+;   Ctrl+Shift+.
gen   Ctrl+.   Ctrl+comma [sic!]  Ctrl+Shift+;   Ctrl+Shift+.
win   Ctrl+.   Ctrl+,             Ctrl+Shift+,   Ctrl+Shift+.

Note how Windows detects Ctrl+Shift+Comma while others detect Ctrl+Shift+Semicolon - yet all except KF5 detect Ctrl+Shift+Point. I assume this is caused by colon not being defined as a key in acccfg.cxx.

In any case, seems I managed to submit the patch for review: https://gerrit.libreoffice.org/c/core/+/93983
Comment 11 Heiko Tietze 2020-07-03 09:01:49 UTC

*** This bug has been marked as a duplicate of bug 126085 ***