Bug 127977 - [Sifr theme] Create good icons for Set reminder, Header, Footer and Headings level show icons in Navigator
Summary: [Sifr theme] Create good icons for Set reminder, Header, Footer and Headings ...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.4.0
Keywords:
Depends on:
Blocks: Icon-Theme-Sifr
  Show dependency tree / graph
 
Reported: 2019-10-05 16:22 UTC by Roman Kuznetsov
Modified: 2023-02-21 12:34 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:

Attachments
Screenshot with Sifr icons problem in Navigator (16.82 KB, image/png)
2019-10-05 16:23 UTC, Roman Kuznetsov 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2019-10-05 16:22:34 UTC 
Description:
[Sifr theme] Create good icons for Set reminder, Header, Footer and Headings level show icons in Navigator

Steps to Reproduce:
1. Open Writer
2. Press F5 -> Opens Navigator
3. Look at Set reminder, Header, Footer and Headings level show icons in Navigator. It looks like Breeze theme icons

Actual Results:
We have not good icons for Set reminder, Header, Footer and Headings level show functions in Navigator 

Expected Results:
We have native Sifr theme's icons for Set reminder, Header, Footer and Headings level show functions in Navigator 


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.4.0.0.alpha0+
Build ID: 8387a6db641b29e6ff3c2f4cdc4688f538cbe35f
CPU threads: 4; OS: Linux 5.2; UI render: default; VCL: kf5; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-08-09_06:28:42
Locale: ru-RU (ru_RU.UTF-8); UI-Language: en-US
Calc: threaded
Comment 1 Roman Kuznetsov 2019-10-05 16:23:12 UTC 
Created attachment 154770 [details]
Screenshot with Sifr icons problem in Navigator
Comment 2 Heiko Tietze 2019-10-16 10:19:03 UTC 
Andreas, Rizal: What do you think?
Comment 3 Rizal Muttaqin 2019-10-20 06:16:09 UTC 
(In reply to Heiko Tietze from comment #2)
> Andreas, Rizal: What do you think?

Just draw it

https://gerrit.libreoffice.org/#/c/81149/
Comment 4 Heiko Tietze 2019-10-20 06:37:53 UTC 
(In reply to Rizal Muttaqin from comment #3)
> Just draw it

Too many to check ;-). Feel free to submit.
Comment 5 Commit Notification 2019-10-20 13:48:43 UTC 
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3ca1f32df446f2d1989f95cbb43163d961b29a1e

 tdf#127976, tdf#127977: Fix for navigator icons

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Roman Kuznetsov 2019-10-23 21:21:59 UTC 
verified in

Версия: 6.4.0.0.alpha1+
ID сборки: 475165e431b5392e426db0de4cea50efc2513875
Потоков ЦП: 4; ОС:Linux 5.2; Отрисовка ИП: по умолчанию; VCL: kf5; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-10-22_04:14:35
Локаль: ru-RU (ru_RU.UTF-8); UI-Language: ru-RU
Calc: threaded

Rizal, thanks for fixing
Comment 7 Rizal Muttaqin 2019-10-24 00:01:36 UTC 
I reopen this bug since this affects many icon themes. Now Breeze and Colibre are two theme which have not been fixed yet.
Comment 8 Rizal Muttaqin 2019-10-24 00:05:24 UTC 
Sorry wrong bug ID(In reply to Rizal Muttaqin from comment #7)
> I reopen this bug since this affects many icon themes. Now Breeze and
> Colibre are two theme which have not been fixed yet.

Sorry wrong bug ID, revert this to Resolved Fixed and change blocks field
Comment 9 BogdanB 2019-11-19 05:56:34 UTC 
Verified in
Version: 6.4.0.0.beta1
Build ID: 4d7e5b0c40ed843384704eca3ce21981d4e98920
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ro-RO (ro_RO.UTF-8); UI-Language: en-US
Calc: threaded