Bug 128084 - Master background color reset after adding new slide on iOS
Summary: Master background color reset after adding new slide on iOS
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: iOS Editor (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other iOS
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-11 08:19 UTC by Nicolas Christener
Modified: 2019-10-30 09:56 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Video showing the issue (10.56 MB, video/mp4)
2019-10-11 08:31 UTC, Nicolas Christener
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Christener 2019-10-11 08:19:51 UTC
Description:
The background color which was set through the master slide will be reset when adding a new slide.

Steps to Reproduce:
1. Create a slide deck using the iOS app
2. Add at least a second slide 
3. Open the sidebar and click "Master View"
4. Tap on "Background" and chose "Color"
5. Tap on "Close Master View"
   -> all slides will now have the same background color
6. Add a new slide

Actual Results:
All slides will loose the background color after the new slide was added.

Expected Results:
The background color should not change.


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Nicolas Christener 2019-10-11 08:31:09 UTC
Created attachment 154925 [details]
Video showing the issue
Comment 2 Xisco Faulí 2019-10-14 15:46:31 UTC
Moving to NEW as agreed in the ESC meeting
Comment 3 How can I remove my account? 2019-10-24 08:53:21 UTC
Looking at this now. This can be reproduced in web-based Collabora Online, too.
Comment 4 How can I remove my account? 2019-10-24 08:53:52 UTC
(At least when built from the same branches, core:cp-6.0 + online:collabora-online-4.)
Comment 5 How can I remove my account? 2019-10-24 09:01:22 UTC
In later versions of core the sidebar doesn't even have a field for master slide background, if I see correctly. Maybe that is because it was not a good idea because there is some reason why it can't work as expected, as shown by this bug? Just wildly guessing here.
Comment 6 How can I remove my account? 2019-10-24 09:08:32 UTC
Can be reproduced in a 'make run' of online:collabora-online-4 + core:cp-6.0 by opening the "hello-world.odp", changing the background colour of the master slide for its only slide, and adding a new slide. The background colour disappears even for the initial slide.
Comment 7 How can I remove my account? 2019-10-24 09:18:35 UTC
Can also be reproduced in desktop LO built from the cp-6.0 branch: Start instdir/program/soffice --impress, cancel the master slide selector (just use the trivial default one), open master view in sidebar, change master slide background colour, close master view, add new slide).
Comment 8 How can I remove my account? 2019-10-24 09:29:47 UTC
Checking if it exists in upstream 6.0
Comment 9 How can I remove my account? 2019-10-24 10:10:42 UTC
Yes, seems reproducible in upstream 6.0, too.
Comment 10 How can I remove my account? 2019-10-24 10:12:27 UTC
(This is likely a duplicate of bug #127290, but let's keep this open separately for iOS.)
Comment 11 How can I remove my account? 2019-10-24 10:54:49 UTC
(A workaround is to use Slide>Duplicate Slide instead of Slide>New Slide. But I guess you knew that.)
Comment 12 How can I remove my account? 2019-10-25 08:39:19 UTC
More bugs about the same root issue; bug #111306, bug#119691.

In later versions the setting of the background of master slides was intentionally removed from the sidebar, as it didn't work properly and nobody was able/available to fix that, see https://cgit.freedesktop.org/libreoffice/core/commit/?id=955eb9d196bdb626f876f02b3961aac79cce3849&h=libreoffice-6-1 . Maybe we should do the same in cp-6.0?
Comment 13 How can I remove my account? 2019-10-25 08:44:32 UTC
But as there is no way to edit the master slide from the View menu in Online or the iOS app, doing that would remove the functionality to edit a master slide background completely.
Comment 14 How can I remove my account? 2019-10-30 09:26:13 UTC
Nicolas, as this is a cross-platform bug in LibreOffice core that is quite hard to solve, and as that functionality has been removed from the sidebar in LibreOffice 6.2 (and later), on which the iOS app will be based soonish, would it be OK to resolve this as WONTFIX? (And instead then strive to get another way to edit a master slide into the Online and iOS app UI.)
Comment 15 Nicolas Christener 2019-10-30 09:30:36 UTC
Yes, I'm happy with your proposal, thanks Tor for looking into this!