Description: The master slide loses the background when changing page format of orientation Steps to Reproduce: 1. Open Impress 2. View -> Slide Master 3. Select a background in the sidebar 4. Change the orientation to Portrait Actual Results: The background setting will be undone Expected Results: Shouldn't happen Reproducible: Always User Profile Reset: No Additional Info: Version: 6.0.0.0.alpha0+ Build ID: 18f80da7a689ab962735c0f657497b8f1ed4d606 CPU threads: 4; OS: Windows 6.19; UI render: default; TinderBox: Win-x86@42, Branch:master, Time: 2017-07-28_05:15:48 Locale: nl-NL (nl_NL); Calc: CL User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Repro. Note: only through sidebar. Right-click, slide properties, step by step works fine. Arch Linux 64-bit, KDE Plasma 5 Version: 6.0.0.0.alpha0+ Build ID: 668ab2e739397e6b095372a1a468bd4f515927b6 CPU threads: 8; OS: Linux 4.12; UI render: default; VCL: kde4; Locale: fi-FI (fi_FI.UTF-8); Calc: group Built on August 20th 2017
Also reproduced in Version: 5.3.0.0.alpha1+ Build ID: 4136757b4e51c4e6f7cb4132c95538a7f831ef2c CPU Threads: 4; OS Version: Linux 4.13; UI Render: default; VCL: gtk3; Layout Engine: new; Locale: ca-ES (ca_ES.UTF-8); Calc: group
*** Bug 111701 has been marked as a duplicate of this bug. ***
*** Bug 117357 has been marked as a duplicate of this bug. ***
The bug is still in LO 6.0.4RC1
*** Bug 118595 has been marked as a duplicate of this bug. ***
*** Bug 118071 has been marked as a duplicate of this bug. ***
The feature was implemented in https://cgit.freedesktop.org/libreoffice/core/commit/?id=64ff7453408e578b95073db1740bfef4f500a2e4
The part "Slide" of the properties panel of the sidebar was disabled for Master pages in LO 5.2.6. I see it enabled in version 5.3.7.2. And in that version I see the problem, that the setting of the background is not stored. You need not save and reload. You see the loss already, if you have closed Master view and then add a new slide. So it is likely not connected to changing the slide size or orientation. I see the problem not only with bitmap, but with all kind of background fillings.
The code related to the slide properties dialog is in https://opengrok.libreoffice.org/xref/core/sd/source/ui/func/fupage.cxx#389. As observed, it uses mbMasterPage to differentiate between masterpages and not masterpages... we should do the same in https://opengrok.libreoffice.org/xref/core/sd/source/ui/sidebar/SlideBackground.cxx
Works well when inserting an image...
I've tried to fix this issue but my knowledge is really limited here. For the time being, let hide the background widget: https://gerrit.libreoffice.org/#/c/57440/
Xisco Fauli committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c57f10b67fceef47d304d74dce93be7389a7720c tdf#111306: Hide background widget in sidebar in master and notes view It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Commit Notification from comment #13) > Xisco Fauli committed a patch related to this issue. > It has been pushed to "master": > > http://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=c57f10b67fceef47d304d74dce93be7389a7720c > > tdf#111306: Hide background widget in sidebar in master and notes view > > It will be available in 6.2.0. > > The patch should be included in the daily builds available at > http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More > information about daily builds can be found at: > http://wiki.documentfoundation.org/Testing_Daily_Builds > > Affected users are encouraged to test the fix and report feedback. Removing the background option actually seems to be a regression rather than fix. The background option in sidebar was to improve ease of use. If removing it can be justified by existence of a duplicate option in a menu, it can be further extended to say that the entire sidebar be removed as most options there can be accessed by alternate methods. If this option is once removed, i dont think anyone will actually implement a working background widget in the sidebar in the near future
> Removing the background option actually seems to be a regression rather than > fix. The background option in sidebar was to improve ease of use. If > removing it can be justified by existence of a duplicate option in a menu, > it can be further extended to say that the entire sidebar be removed as most > options there can be accessed by alternate methods. If this option is once > removed, i dont think anyone will actually implement a working background > widget in the sidebar in the near future What the point of showing it in the sidebar if it doesnt work? The issues has been there for three majors releases and no one has fixed it yet... besides, there are already 4 duplicates... thus, IMHO, it's better to hide it for now than showing it while it doesn't work... it might create confusion among users when they save their documents as the background will get lost... Please note this fix should be temporal, and the root cause should be fixed at some point, then we can show the option in the sidebar again...
(In reply to Xisco Faulí from comment #1) > What the point of showing it in the sidebar if it doesnt work? > The issues has been there for three majors releases and no one has fixed it > yet... > besides, there are already 4 duplicates... thus, IMHO, it's better to hide > it for now than showing it while it doesn't work... it might create > confusion among users when they save their documents as the background will > get lost... > Please note this fix should be temporal, and the root cause should be fixed > at some point, then we can show the option in the sidebar again... will it be marked resolved after this temporary fix?
> will it be marked resolved after this temporary fix? We can do two things here: 1. we close this one and we create a follow-up bug describing the root bug... 2. We don't close this one and we change the description accordingly. Personally, I prefer the first option and it's clearer...
(In reply to Xisco Faulí from comment #17) > > will it be marked resolved after this temporary fix? > > We can do two things here: > 1. we close this one and we create a follow-up bug describing the root bug... > 2. We don't close this one and we change the description accordingly. > > Personally, I prefer the first option and it's clearer... Option 1 appears better
Xisco Fauli committed a patch related to this issue. It has been pushed to "libreoffice-6-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=955eb9d196bdb626f876f02b3961aac79cce3849&h=libreoffice-6-1 tdf#111306: Hide background widget in sidebar in master and notes view It will be available in 6.1.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
It works. Tested with Version: 6.1.1.0.0+ Build ID: 5a56b72413d5f555c854e36d3bd2fd50ec21644c CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:libreoffice-6-1, Time: 2018-08-15_02:45:13 Locale: ro-RO (ro_RO.UTF-8); Calc: group threaded
Follow-up bug created: bug 119691