Cannot open 819-pages ODT attachment 121138 [details] from bug 96337 in LO master 6.5+. Note: additional perf issue because OO 3.3 took much less to open compared to LO 6.1 where worked (0:28 to 0:58 on my slow system).
Confirmed on mint 19.3 x64 with Version: 6.5.0.0.alpha0+ Build ID: 9e63d328691014bc97f6b66b708ed9dec53618e6 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-12-18_00:38:35 Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded
seems to have started with: https://gerrit.libreoffice.org/plugins/gitiles/core/+/94c1af65367dcbc7272455cf6d4940252a289b62 commit 94c1af65367dcbc7272455cf6d4940252a289b62 [log] author Michael Stahl <Michael.Stahl@cib.de> Fri Nov 30 17:54:41 2018 +0100 committer Thorsten Behrens <Thorsten.Behrens@CIB.de> Tue Dec 18 22:30:17 2018 +0100 tree 98cced77a32f996d345ff3ead5ca6e300b05ffca parent a44be0f4d6ee7321f0cdf441b054a10ad6285440 [diff] sw_redlinehide: make layout based Show/Hide mode the default remove ExperimentalMode checks /cygdrive/d/sources/bibisect/bibisect-win32-6.2 $ git bisect good 97f5af359c25a7210e0b9ecbf7963933adf098df is the first bad commit commit 97f5af359c25a7210e0b9ecbf7963933adf098df Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Wed Dec 19 02:00:00 2018 -0800 source 94c1af65367dcbc7272455cf6d4940252a289b62 source 94c1af65367dcbc7272455cf6d4940252a289b62 :040000 040000 1b9c5e2d768a70892c56272d17468beb17421a70 372cd4f0b24d398a96cf835ab677a7d2b9831d0f M instdir /cygdrive/d/sources/bibisect/bibisect-win32-6.2 $ git bisect log # bad: [32300ab0da959bbff1f09736ff655937319e7e3e] source 5f01fe15eb2661f1f9ce12d1d99dc2a705b462ee # good: [b0a56ec98b1368cb5e3e531e0b3f69565af91609] source 3a801799536e6870f2fb111b1cc00b9575a35a39 git bisect start 'master' 'oldest' # good: [696d8ce3656c1a7018e3647f381d01de8432cb19] source 43125f3b0b18b8d9bac9bd459fa234cb5ff9ddb4 git bisect good 696d8ce3656c1a7018e3647f381d01de8432cb19 # good: [313291982701f81331b6569203682bbb5da03ad9] source 922f935f9ddefcfc50d0bbf805c97ea3f9d5c5e6 git bisect good 313291982701f81331b6569203682bbb5da03ad9 # good: [fa54824924d41aef8e5032a08cefde0a4c1d478b] source d3e4c06ccb3aa4bb9078077a49dc2b2795835a5c git bisect good fa54824924d41aef8e5032a08cefde0a4c1d478b # bad: [44048d34ce2f1f0d44aa4fae4d3a443e79cb4dfd] source b2bb05fc4fddbdcb191f993ba58adab08adbc99b git bisect bad 44048d34ce2f1f0d44aa4fae4d3a443e79cb4dfd # bad: [9d28c901479c528e6d642cae1c19b18d324981e4] source 39d6804454f60fb9ba442f85a0487898dfe68e69 git bisect bad 9d28c901479c528e6d642cae1c19b18d324981e4 # bad: [915d86864181e51a446a5673b623cbe5a24a601e] source 2d2da8862e5169ef28a3dde1758e344f9e6cf742 git bisect bad 915d86864181e51a446a5673b623cbe5a24a601e # bad: [d827b8be25d94de9b75466a1d78d0fdf480734df] source 15328224ffabeb12a5c7741fe904a97e12787070 git bisect bad d827b8be25d94de9b75466a1d78d0fdf480734df # good: [b8417032e8cbd2e22edbe125c067c5b8175a7106] source 80cd503d4a24e7e5407181b57c3968a679ae9bab git bisect good b8417032e8cbd2e22edbe125c067c5b8175a7106 # good: [1d0849f070a4f6dda4d5ebfb4fb0012866cbc359] source 4eca10d8d6d663cce8f978b6cfd66d94dd2a4a60 git bisect good 1d0849f070a4f6dda4d5ebfb4fb0012866cbc359 # good: [58d42dc49de6c1b77ad2c502662257dccae988dd] source 0aa544b5054e76f49eb105d0c4dc3f6ec0edf8ef git bisect good 58d42dc49de6c1b77ad2c502662257dccae988dd # good: [f685826e57a0a226459f6ba92f6e5a9b529b7ad4] source d28d85c1d21ad466ead022daf41b910181affe98 git bisect good f685826e57a0a226459f6ba92f6e5a9b529b7ad4 # good: [9679c923bc259b9b79310ae06815800acf0e06d4] source 082e977297f1c1eaf078a9dfde3efd6d32c1963a git bisect good 9679c923bc259b9b79310ae06815800acf0e06d4 # bad: [97f5af359c25a7210e0b9ecbf7963933adf098df] source 94c1af65367dcbc7272455cf6d4940252a289b62 git bisect bad 97f5af359c25a7210e0b9ecbf7963933adf098df # good: [6c9cac774c249926444c00e26b8e49892a64e145] source a44be0f4d6ee7321f0cdf441b054a10ad6285440 git bisect good 6c9cac774c249926444c00e26b8e49892a64e145 # first bad commit: [97f5af359c25a7210e0b9ecbf7963933adf098df] source 94c1af65367dcbc7272455cf6d4940252a289b62
Created attachment 156719 [details] perf flamegraph On pc Debian x86-64 with master sources updated today + enable-symbols, it doesn't open after 20 secs (I didn't wait more). Thought a Flamegraph may help to pinpoint the pb.
Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=7e8b4756d95057f069467b34e7849f9354856578 author Michael Stahl <Michael.Stahl@cib.de> 2018-09-17 11:26:01 +0200 committer Michael Stahl <Michael.Stahl@cib.de> 2018-09-19 10:18:33 +0200 commit 7e8b4756d95057f069467b34e7849f9354856578 (patch) tree 65e3065a6c5ff6e63dfc4e689b5e43a4ca04d41b parent ede29e57cd14946c8668ca7d2b84dbc3afa90fd5 (diff) sw_redlinehide_2: disable layout-cache for now Both reading & writing. Bisected with: bibisect-linux64-6.2 Adding Cc: to Michael Stahl
the funny document has this in meta.xml meta:page-count="819" meta:paragraph-count="302" for which laycache.cxx:604 mnMaxParaPerPage = nNdCount / nPgCount; cunningly estimates a maximum of 0 paragraphs per page, and at that rate an infinite number of pages are required...
Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a9f2f4b4c9e1fa4e4c4a69517c31d0b8e2063f01 tdf#129529 sw_redlinehide: infinite loop in SwLayHelper::CheckInsert() It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
i hope its fixed but its hard to tell with a debug build because it takes forever to open the document in any case
(In reply to Michael Stahl (CIB) from comment #7) > i hope its fixed but its hard to tell with a debug build because it takes > forever to open the document in any case Yes, it's fixed in Version: 7.0.0.0.alpha0+ Build ID: d7cab304e7dd22fd12443a1ee3b6a9c463bf9a3d CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded @Michael, thanks for fixing this issue!
(In reply to Timur from comment #0) additional perf issue because OO 3.3 took much less to open compared > to LO 6.1 where worked (0:28 to 0:58 on my slow system). @Timur, could you please report the performance issue in a follow-up report ?
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/fef72fe382d04068cc5480f682125411c54d5dc2 tdf#129529 sw_redlinehide: infinite loop in SwLayHelper::CheckInsert() It will be available in 6.4.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/commit/6ecad243cc17a6857a177b659c539f3be45a6ed1 tdf#129529 sw_redlinehide: infinite loop in SwLayHelper::CheckInsert() It will be available in 6.3.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.