Description: LO crashes when using the tabbed notebookbaar as ui and when i am trying to close the print preview window. I opened the option using the icon in the tabbed notebookbar (CYTL + shift + O). Summary: openig print preview in tavved notebookbar works; closing down: crash! Steps to Reproduce: 1. open print preview window in tabbed notebookbar (CTRL + Shift + O) 2. close print preview window 3. crash Actual Results: see above Expected Results: crash Reproducible: Always User Profile Reset: No Additional Info:
reproducible with: Version: 6.4.0.3 (x64) Build-ID: b0a288ab3d2d4774cb44b62f04d5d28733ac6df8 CPU-Threads: 4; BS: Windows 10.0 Build 18363; UI-Render: Standard; VCL: win; Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE Calc: but *not* reproducible with: Version: 6.3.4.2 (x64) Build-ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE Calc:
*** Bug 130171 has been marked as a duplicate of this bug. ***
seems to have started with: https://gerrit.libreoffice.org/plugins/gitiles/core/+/4ae5fe896e96d082e21788ae6d42a67133567ba7 tdf#118526 Reload Notebookbar if read mode has switched Change-Id: I8d6edd57566c66165690808e853a74777bc8e14a Reviewed-on: https://gerrit.libreoffice.org/82371 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> sfx2/source/notebookbar/SfxNotebookBar.cxx[diff] /cygdrive/d/sources/bibisect/bibisect-win64-6.4 $ git bisect good 3e38e303b76c89aec18cb0b2cf2a0652acc12715 is the first bad commit commit 3e38e303b76c89aec18cb0b2cf2a0652acc12715 Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Thu Nov 14 04:22:31 2019 -0800 source 4ae5fe896e96d082e21788ae6d42a67133567ba7 source 4ae5fe896e96d082e21788ae6d42a67133567ba7 :040000 040000 26fd065b5c56b82ff276807c6c0dcb051b38cb88 e617f58474662b64506078d685c0e4360e86fdb6 M instdir /cygdrive/d/sources/bibisect/bibisect-win64-6.4 $ git bisect log # bad: [75af2782b7f006d1c31ad11e84d5ab6bd7f74ed0] source 20be5cd0bdc57d812bf34a2debfe48caa51de881 # good: [8d1eaf05d47fd1c56ddecbe57a9a7c8289ede7f4] source c98b1f1cd43b3e109bcaf6324ef2d1f449b34099 git bisect start 'master' 'oldest' # good: [e13037966b62b9d258d5cf6d96586de5e2bafea8] source 4a0b2b8024fa6fb8a0ab3e474b7d64fc455028b5 git bisect good e13037966b62b9d258d5cf6d96586de5e2bafea8 # good: [7cba838374e1acd7b8a6e114d7b12bf6370cd7ab] source d6ea967e040d01ec69649ac689472018e477db34 git bisect good 7cba838374e1acd7b8a6e114d7b12bf6370cd7ab # good: [39293e77bf2d89be2f2f7afeb4c0c65f7231ff3a] source 9b400e84b1689997378f6738b97b71b09cdb7be6 git bisect good 39293e77bf2d89be2f2f7afeb4c0c65f7231ff3a # bad: [e312d3a1be007a0fc008d7d39270cec23d31859c] source 8bd15459527b527454900dd781f1226dade5b118 git bisect bad e312d3a1be007a0fc008d7d39270cec23d31859c # good: [5822e1851375a2d842cbb44d9a9cebdf92366e82] source 83579e8018bf998552394cfe1e4d57f023e07382 git bisect good 5822e1851375a2d842cbb44d9a9cebdf92366e82 # bad: [d1e3aade7da8ae223a0eb6b2adcbe82348b40344] source aadc7ee973c1f28a0e17d551fef6b76e015a28ef git bisect bad d1e3aade7da8ae223a0eb6b2adcbe82348b40344 # good: [0c6625073be9b6242be1194ef725d6693e5af152] source ebccc375248faebdfbca273b149483593c753387 git bisect good 0c6625073be9b6242be1194ef725d6693e5af152 # good: [62fce0718b438dbb75db6ff237cd12e8cc153334] source b1f5acf5d740cfc686159b94eb333586e8ffe67d git bisect good 62fce0718b438dbb75db6ff237cd12e8cc153334 # good: [030e90c205d1175a87f31e7bb6f5f7bfcac57f3b] source e4bf92ae344e0db16177de7fc9eed432339d8705 git bisect good 030e90c205d1175a87f31e7bb6f5f7bfcac57f3b # good: [be55e8209642d80e696af909a35a133f631c41f4] source 1a7ba39e13d0a8e0ace2475bc50e1497c2928b78 git bisect good be55e8209642d80e696af909a35a133f631c41f4 # bad: [8a60b781274c8801411be651d97cfd789c716920] source 1d81d52b5da45f26e9d3adeb3b279eb9a488b94f git bisect bad 8a60b781274c8801411be651d97cfd789c716920 # bad: [3e38e303b76c89aec18cb0b2cf2a0652acc12715] source 4ae5fe896e96d082e21788ae6d42a67133567ba7 git bisect bad 3e38e303b76c89aec18cb0b2cf2a0652acc12715 # good: [d63ef2042c69a74425bfc5c7c0ab337ad281b711] source 938a4d6624a78f3e272b3c4c07f314cb0c6db723 git bisect good d63ef2042c69a74425bfc5c7c0ab337ad281b711 # first bad commit: [3e38e303b76c89aec18cb0b2cf2a0652acc12715] source 4ae5fe896e96d082e21788ae6d42a67133567ba7
Not reproducible in Version: 7.0.0.0.alpha0+ Build ID: 6b4fe3e44b4daa89fef6a3385919b00472eaed60 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: x11; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded
i do confirm on Win that the issue was introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=4ae5fe896e96d082e21788ae6d42a67133567ba7 author Jim Raykowski <raykowj@gmail..com> 2019-11-09 16:07:09 -0900 committer Xisco Faulí <xiscofauli@libreoffice.org> 2019-11-11 11:04:56 +0100 commit 4ae5fe896e96d082e21788ae6d42a67133567ba7 (patch) tree 1d1c0f02b5fc51a684402c5ae92c3cf039452ebe parent 938a4d6624a78f3e272b3c4c07f314cb0c6db723 (diff) tdf#118526 Reload Notebookbar if read mode has switched Adding Cc: to Jim Raykowski
(In reply to Xisco Faulí from comment #5) > i do confirm on Win that the issue was introduced by: > > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=4ae5fe896e96d082e21788ae6d42a67133567ba7 > > author Jim Raykowski <raykowj@gmail..com> 2019-11-09 16:07:09 -0900 > committer Xisco Faulí <xiscofauli@libreoffice.org> 2019-11-11 11:04:56 +0100 > commit 4ae5fe896e96d082e21788ae6d42a67133567ba7 (patch) > tree 1d1c0f02b5fc51a684402c5ae92c3cf039452ebe > parent 938a4d6624a78f3e272b3c4c07f314cb0c6db723 (diff) > tdf#118526 Reload Notebookbar if read mode has switched > > Adding Cc: to Jim Raykowski I don't think this is the cause. Took me a while but I found where I had mentioned this crash. See concern 5 here: https://bugs.documentfoundation.org/show_bug.cgi?id=109425#c21 Looks like Mike has fixed this with: commit afa6a774936c34b09b37ab8539193ac529681798 Author: Mike Kaganski <mike.kaganski@collabora.com> Date: Mon Jan 6 10:49:31 2020 +0300 Don't crash on exiting print preview with Notebookbar Regression after commit d05b7b32d9ecb6fcb4a268eb68cdcee09bafa6dd.
Hi Jim, Thanks for the analysis. I do confirm afa6a774936c34b09b37ab8539193ac529681798 fixes this issue. However, the crash is no reproducible in Versión: 6.3.4.2 (x86) Id. de compilación: 60da17e045e08f1793c57c00ba83cdfce946d0aa Subprocs. CPU: 2; SO: Windows 6.1; Repres. IU: predet.; VCL: win; Configuración regional: es-ES (es_ES); Idioma de IU: es-ES Calc: threaded even though the commit is in libreoffice-6-3 branch < https://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-6-3&id=d05b7b32d9ecb6fcb4a268eb68cdcee09bafa6dd > so I believe 4ae5fe896e96d082e21788ae6d42a67133567ba7 made it easier to be reproducible. Anyway, let's backport afa6a774936c34b09b37ab8539193ac529681798 to libreoffice-6-4 to fix it there too. Meanwhile, 4ae5fe896e96d082e21788ae6d42a67133567ba7 was reverted in libreoffice-6-3 < https://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-6-3&id=2b73347194dde360d9e4be4526657efb511e72ef > so we are safer there. Later on, we can backport afa6a774936c34b09b37ab8539193ac529681798 to libreoffice-6-3 if needed Closing as RESOLVED FIXED
(In reply to Xisco Faulí from comment #7) > so I believe > 4ae5fe896e96d082e21788ae6d42a67133567ba7 made it easier to be reproducible. > I was also thinking that. Glad I was able to help.
*** Bug 130305 has been marked as a duplicate of this bug. ***
*** Bug 130438 has been marked as a duplicate of this bug. ***
Mike Kaganski committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/fb2382ad4f33b885650ad5156ccaec4e90661806 tdf#130187: Don't crash on exiting print preview with Notebookbar It will be available in 6.4.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
*** Bug 130544 has been marked as a duplicate of this bug. ***
*** Bug 130585 has been marked as a duplicate of this bug. ***
*** Bug 130634 has been marked as a duplicate of this bug. ***
Mike Kaganski committed a patch related to this issue. It has been pushed to "libreoffice-6-4-1": https://git.libreoffice.org/core/commit/1d51690ffd51cff963a3b083abb288f505f5cc64 tdf#130187: Don't crash on exiting print preview with Notebookbar It will be available in 6.4.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
*** Bug 130963 has been marked as a duplicate of this bug. ***
Created attachment 158264 [details] Print preview notebookbar not opened.. crash is solved Hi all, Thanks for the great work (as always). So, I saw that the bug of LO crashing when hitting the priint preview button in the tabbed notebookbar, is solved. That is great news! However, it seems that the problem is not solved completely. LO does not crash anymore, but the tabbed notebook bar does not dynamically change anymore to the print preview bar. So, it remains in the status of the “Start” tab. This means is can not choose any options from the print preview, which is a bit inconvenient for me. Maybe you are able to solve this problem too? I am using LO on several windows 10 1909 machines. Thanks in advance! Ciao, Maarten
*** Bug 132166 has been marked as a duplicate of this bug. ***
*** Bug 131256 has been marked as a duplicate of this bug. ***