Bug 131699 - add support for paragraph mark formatting for RTF
Summary: add support for paragraph mark formatting for RTF
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: filter:rtf
Depends on:
Blocks: RTF-Bullet-Number-Lists RTF-Paragraph
  Show dependency treegraph
 
Reported: 2020-03-30 09:49 UTC by Michael Stahl (allotropia)
Modified: 2023-11-07 14:59 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Stahl (allotropia) 2020-03-30 09:49:47 UTC
in commit 5ba30f588d6e41a13d68b1461345fca7a7ca61ac "tdf#64222 sw: better DOCX import/export of paragraph marker formatting" a new way to represent paragraph marker formatting was added in Writer, but it's only used by DOCX filters currently.

the import code is disabled for RTF import due to unit test failures, and doesn't exist yet for WW8 import.

for RTF see also 6ed12ab2d0742f86ce25defec3c776562dbfad9a "tdf#120546 fix DOCX overriding numrule format" with another check explicitly for DOCX, not RTF.

there are more follow-up tasks:
* font size on paragraph-mark must affect the line height
* paragraph mark formatting isn't actually displayed on the pilcrow yet, only on the list label
* currently only hard formatting is supported; allow setting character-style as well
* adapt WW8 import to create the paragraph item

see also https://bugs.documentfoundation.org/show_bug.cgi?id=120546#c9
Comment 1 Michael Stahl (allotropia) 2023-10-17 17:46:22 UTC
for the main problem: was already done by:

commit a25eda715591cfa96136bcfd95360156516239d1
Author:     Michael Stahl <michael.stahl@allotropia.de>
AuthorDate: Fri Jan 13 17:49:58 2023 +0100
Commit:     Michael Stahl <michael.stahl@allotropia.de>
CommitDate: Fri Jan 13 19:31:53 2023 +0000

    tdf#131386 writerfilter: RTF import paragraph mark formatting
 

follow-up tasks:
> * font size on paragraph-mark must affect the line height

it looks like this is actually wrong; in Word 2013 the paragraph marker does not grow the line height

> * paragraph mark formatting isn't actually displayed on the pilcrow yet, only on the list label

still to do

> * currently only hard formatting is supported; allow setting character-style as well

this was also implemented, this commit appears to work for RTF as well;
there is some problem with the color being overridden where the style
is applied but it happens in paragraph text too so not specific to this feature.

commit c77b9c349f0a48392d8cb7a49532844b2cafb5ba
Author:     Vasily Melenchuk <vasily.melenchuk@cib.de>
AuthorDate: Tue Aug 18 17:59:26 2020 +0200
Commit:     Michael Stahl <michael.stahl@cib.de>
CommitDate: Fri Aug 28 17:30:57 2020 +0200

    tdf#131801: sw: support of style references in ListAutoFormat

> * adapt WW8 import to create the paragraph item

still to do
Comment 2 Gabor Kelemen (allotropia) 2023-11-07 14:58:29 UTC
The attachment 184628 [details] from bug 152866 still demonstrates some more TODO.
There a style sets TNR 36pt bold italic underline settings, but this style is not applied to the single pilcrow. The style is correctly imported otherwise.