Bug 131764 - UI: Insert textbox button marked active while cursor inside textbox
Summary: UI: Insert textbox button marked active while cursor inside textbox
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
5.2 all versions
Hardware: All All
: lowest trivial
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 134590 (view as bug list)
Depends on:
Blocks: Textbox Button-Controls
  Show dependency treegraph
 
Reported: 2020-04-01 08:41 UTC by Telesto
Modified: 2020-08-03 19:10 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-04-01 08:41:15 UTC
Description:
UI: Insert textbox button marked active while cursor inside textbox

Steps to Reproduce:
1. Open Draw
2. Press F2 to insert a textbox & look at the textbox button in the toolbar

Actual Results:
The Insert textbox button is active. It seems that you are inserting a new one

Expected Results:
The Insert Textbox show only glow when it's clicked to INSERT a textbox. Not when entering an existing textbox


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.0.0.0.alpha0+ (x64)
Build ID: 4501a0ba623ad61c5a4e0b807da2e96f0e4ce82c
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL
Comment 1 Xisco Faulí 2020-04-01 09:21:41 UTC
Reproduced in

Version: 7.0.0.0.alpha0+
Build ID: 169a10f0e4680814145b668c6320be04038d7a89
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

and

Version: 5.2.0.0.alpha0+
Build ID: 3ca42d8d51174010d5e8a32b96e9b4c0b3730a53
Threads 4; Ver: 4.19; Render: default; 

don't know if it's the expected behaviour though.
Adding the UX team
Comment 2 Heiko Tietze 2020-04-01 09:35:18 UTC
The button/command also enters the edit mode (click on the frame and press button or F2). Not really needed but consistent with the enabled state. WFM, Telesto?
Comment 3 Telesto 2020-04-01 09:55:30 UTC
(In reply to Heiko Tietze from comment #2)
> The button/command also enters the edit mode (click on the frame and press
> button or F2). Not really needed but consistent with the enabled state. WFM,
> Telesto?

That's 'part' of my problem. The button shouldn't have multiple functions. It's confusing.
- As in instrument to insert a textbox (the square) (text draw mode on/off)
- Indicator for being inside a textbox (textbox or shape text)
- As a button to access the shape textbox

The shape textbox 'exists' anyhow. It isn't inserted/ added. It's only 'activated'.

I know 'toying' around isn't representative for a workflow, but I have 'pressed' insert textbox multiple times while having a shape selected. Intending to insert a new textbox. Not activating the shape textbox (which I tend to access with double click). Similar the deselection happening when pressing insert shape, while a shape is active.

In my world, I click Inserting a textbox button to insert a textbox (exclusively the blue square). It's active until a textbox is draw. 

Accessing a textbox (shape/or square) should be done by double click/F2 (without further indicator).

Enabling 'Insert textbox' pressing F2 with nothing selected is also fine with me. The 'draw textbox' button is marked active until the textbox is drawn.

This issue didn't exist (by default) in 4.4.7.2. The toolbar didn't have a 'insert textbox button at all'
Comment 4 Heiko Tietze 2020-04-01 10:44:02 UTC
Maxim, what's your opinion?
Comment 5 Maxim Monastirsky 2020-04-04 22:47:25 UTC
Discussed in the past in Bug 113171.

(In reply to Telesto from comment #3)
> but I have
> 'pressed' insert textbox multiple times while having a shape selected.
> Intending to insert a new textbox.
I believe this is the biggest problem here: Users aren't able to insert a textbox while a shape is selected. For comparison, Inkscape also has similar "Text mode" button, but unlike LO you can draw new textboxes while in edit mode of another textbox. Might be a good idea to have similar behavior in LO.

Otherwise, we can introduce a dedicated "Insert textbox" command that will do only that, and use it in the toolbar/menu instead of the current command. The current command that in use in Draw is .uno:Text, but in Writer it is .uno:DrawText, so we can implement .uno:DrawText for Draw too, for a Writer-like behavior. The downside from this is that the menu/toolbar tooltip will no longer show the keyboard shortcut (F2), as it will be a different command.

Finally, if we think that indicating the edit mode isn't useful, we might just change the existing command to not toggle in this case (but only when drawing a new text box). But this alone won't solve the problem of not being able to draw text boxes when another shape is selected.
Comment 6 Heiko Tietze 2020-04-06 09:27:34 UTC
Simply disable the command while in edit mode, my take.
Comment 7 Heiko Tietze 2020-04-09 12:36:35 UTC
So let's do it and disable the _insert_ text box command while in edit mode.
Comment 8 Maxim Monastirsky 2020-07-08 09:39:45 UTC
*** Bug 134590 has been marked as a duplicate of this bug. ***
Comment 9 Maxim Monastirsky 2020-07-08 09:41:23 UTC
(In reply to Heiko Tietze from comment #6)
> Simply disable the command while in edit mode, my take.

This will make it even more confusing. Imagine a user who want to insert a text box, but it happens that he has a shape or another text box selected. He is clicking on the insert text box button, but then suddenly that button becomes disabled. He then might try to draw the text box anyway, with no success. The benefit of keeping the button enabled, is that the user can at least click on the button again, which will allow him finally to draw the text box. And as said in comment 5, there's no reason why we can't make it possible to draw text boxes while another shape or text box is in edit mode. So the first click on the button should be actually enough to also enable the insertion mode.

In addition, I believe the confusion discussed here was mostly caused by the fact the button has a tooltip "Insert Text Box", which is incorrect, as the button is actually a "text tool" button. In the distant past this command used to be called just "Text", and was only present in the toolbar, and not in the Insert menu, so there was no confusion back then. But at some point in time someone decided to add it to the Insert menu, and to rename it to "Insert Text Box". So I think that at least the toolbar button should be renamed back to "Text".
Comment 10 Heiko Tietze 2020-07-10 12:49:11 UTC
(In reply to Maxim Monastirsky from comment #9)
> button is actually a "text tool" button. ...
> So I think that at least the toolbar button should be renamed back to "Text".

With just noun like "Text" it is totally unclear what it does. Edit, delete, add... many different actions are used on the commands. That's why I always vote for <Verb> <Noun> combinations. "Insert Text Box" sounds good to me and we could make it "Insert/Edit Text Box". But way too much fuss about terminology and preferably the actual issue, to insert a text box while in edit mode, should be solved. Three options: a) rename carefully, b) resolve as WF, c1) resolve and create another ticket for the edit/add thing or c2) hi-jack this request. My take after all the discussion is b) (or c1).
Comment 11 Maxim Monastirsky 2020-07-12 00:06:04 UTC
(In reply to Heiko Tietze from comment #10)
> a) rename carefully,
Unfortunately I can't see how it can be renamed then. Using 2 verbs is bad, and also won't work for the Insert > Text Box menu item.

> b) resolve as WF
Possible, but I'm not sure given that there appear to be real reasons for confusion here.

How about this:

1) We keep the current naming as-is.

2) Clicking the button/menu item (or pressing F2) while a shape is selected continues to enter its text edit mode, but _in addition_ allows to draw another text box. The button/menu item is toggled until the text edit mode is cancelled or a text box is drawn.

3) Double clicking on a shape to enter its edit mode, will not toggle the button.
Comment 12 Heiko Tietze 2020-07-13 12:52:22 UTC
(In reply to Maxim Monastirsky from comment #11)
> How about this:...

Seems to be a good solution.