Bug 132343 - PPTX import: Scaled shadow distance is not equal between LO and MSO
Summary: PPTX import: Scaled shadow distance is not equal between LO and MSO
Status: RESOLVED DUPLICATE of bug 150020
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: PPTX-3D
  Show dependency treegraph
 
Reported: 2020-04-23 08:14 UTC by Gülşah Köse
Modified: 2023-11-02 18:50 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample file (67.75 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2020-04-23 08:19 UTC, Gülşah Köse
Details
Comparision MSO and LO (94.13 KB, application/pdf)
2020-04-23 08:19 UTC, Gülşah Köse
Details
how it looks in previous versions (33.48 KB, image/png)
2020-05-11 07:52 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gülşah Köse 2020-04-23 08:14:05 UTC
Description:
Scaled shadow distance is not equal between LO and MSO

Steps to Reproduce:
1.Open sample.pptx with MSO
2.Open sample.pptx with LibreOffice


Actual Results:
Shadow distances are not equal.

Expected Results:
Shadow distance should be equal.


Reproducible: Always


User Profile Reset: No



Additional Info:
It happens after 6454b6336b8de9a4c5899adeab552af6f794cdc4 . Not a regression. Before that commit LibreOffice already can't import scaled shadows.
Comment 1 Gülşah Köse 2020-04-23 08:19:15 UTC
Created attachment 159835 [details]
Sample file
Comment 2 Gülşah Köse 2020-04-23 08:19:55 UTC
Created attachment 159836 [details]
Comparision MSO and LO
Comment 3 Xisco Faulí 2020-05-11 07:47:42 UTC
Reproduced in

Version: 7.0.0.0.alpha1+
Build ID: 86bc13248c1d9f63b10aac304bdf0361d1dcc47f
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 4 Xisco Faulí 2020-05-11 07:50:45 UTC
In previous versions the shadow has wrong size
Comment 5 Xisco Faulí 2020-05-11 07:52:09 UTC
Created attachment 160641 [details]
how it looks in previous versions
Comment 6 Xisco Faulí 2021-03-09 20:40:23 UTC
Still reproducible in

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 351b2382465087d18a3ad44509c2a3a66ca08aa6
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc:
Comment 7 Regina Henschel 2021-03-09 21:45:32 UTC
The origin of the distance is given in attribute algn="tr", which means, that the distance between object and shadow is measured using the top-right corner of object and shadow. The position of the shadow is then determined by attribute dist(UI Distance) and dir (UI Angle). That means pptx used polar coordinates.

LibreOffice does not evaluate attribute "algn" and only preserves it for roundtrip, at least that is my conclusion of EffectPropertiesContext::saveUnsupportedAttribs()
LibreOffice uses instead top-left corner of the image as origin.

LibreOffice evaluates the size, but that is only in special pptx-mode. Other shadow sizes than 100% cannot be expressed in ODF file format. Previous versions could not interpret the size, which results in the large shadow in "how it looks in previous versions".

If you set the image transparency to 90%, you can see the shadow behind the image. Tested in Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 8e49505fa7352023c252bf794ae84c9082d7264e
CPU threads: 8; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: CL
Comment 8 QA Administrators 2023-03-10 03:26:46 UTC Comment hidden (obsolete)
Comment 9 Regina Henschel 2023-06-05 17:38:31 UTC
The shadow is rendered correctly in Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 70fd835b4cf75e386ee115c705241a4059fb68a8
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

But still there is no UI to set the properties. The properties in question are ShadowAlignment, ShadowSizeX and ShadowSizeY. These properties can be seen in the Development Tools, but not in the API Reference. They are not part of com::sun::star::drawing::ShadowProperties Service.
Comment 10 Xisco Faulí 2023-11-02 18:50:15 UTC
This issue got fixed by https://cgit.freedesktop.org/libreoffice/core/commit/?id=c27946fb157fe46fbfaefbe93f2c6794b1af4411
Closing as DUPLICATED of bug 150020

*** This bug has been marked as a duplicate of bug 150020 ***