Bug 150020 - FILEOPEN PPTX: shadow effect for table offset too far to the right
Summary: FILEOPEN PPTX: shadow effect for table offset too far to the right
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Sarper Akdemir (allotropia)
URL:
Whiteboard: target:7.6.0
Keywords: filter:pptx
: 132343 (view as bug list)
Depends on:
Blocks: PPTX-3D PPTX-Tables
  Show dependency treegraph
 
Reported: 2022-07-17 07:11 UTC by Gerald Pfeifer
Modified: 2023-11-02 18:50 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Visual comparison Office 365 (left) vs LibreOffice (right) (206.62 KB, image/png)
2022-07-17 21:27 UTC, Gerald Pfeifer
Details
Additional sample document (45.31 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2022-08-03 21:34 UTC, Gerald Pfeifer
Details
Additional sample document, visual comparision: Impress (left) vs Powerpoint (right) (29.25 KB, image/png)
2022-08-03 21:34 UTC, Gerald Pfeifer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Pfeifer 2022-07-17 07:11:45 UTC
Looking at attachment #167346 [details] from bug #129961 after Miklos' patches
shadows are present, alas offset too far to the right (and maybe bottom).

If I had to guess, there is an
  anchor.X + cx
in the code that should read
  anchor.X + cx/2

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: ce29e6299932fc079b05b60662ba95c8342990bc
CPU threads: 8; OS: Linux 5.18; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Comment 1 Gerald Pfeifer 2022-07-17 21:27:16 UTC
Created attachment 181294 [details]
Visual comparison Office 365 (left) vs LibreOffice (right)
Comment 2 Timur 2022-07-19 12:55:19 UTC
New. It's worse for larger values, as seen in slide 1 of attachment 181329 [details].
Comment 3 Gerald Pfeifer 2022-08-03 21:34:01 UTC
Created attachment 181574 [details]
Additional sample document
Comment 4 Gerald Pfeifer 2022-08-03 21:34:32 UTC
Created attachment 181575 [details]
Additional sample document, visual comparision: Impress (left) vs Powerpoint (right)
Comment 5 Commit Notification 2023-04-18 15:44:07 UTC
Sarper Akdemir committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c27946fb157fe46fbfaefbe93f2c6794b1af4411

tdf#150020 pptx import: handle algn for outerShdw

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Sarper Akdemir (allotropia) 2023-04-18 15:58:43 UTC
After this patch, the problem demonstrated with attachment #181574 [details], is fixed.
Also the problem demonstrated at attachment #181294 [details] the non-table shape (top right), is fixed too.

But it appears the case specific to table shadows aren't fixed (also demonstrated at attachment #181294 [details]), I'll check the situation there too.
Comment 7 Commit Notification 2023-04-19 17:07:38 UTC
Sarper Akdemir committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fcf776a09a2c5cd692480c8ec4a678e3d04739c9

tdf#150020: pass transform and scale matrix for the table shadow primitive

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Sarper Akdemir (allotropia) 2023-04-19 17:08:17 UTC
Hopefully this is fixed now with fcf776a09a2c5cd692480c8ec4a678e3d04739c9
Comment 9 Gerald Pfeifer 2023-04-20 17:51:44 UTC
Indeed, happy to confirm that the sample documents listed in this 
report plus some I had locally all appear fine now with

  Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
  Build ID: 3ec73488e447a693a14a773a7fb96938036c0324
  CPU threads: 8; OS: Linux 6.2; UI render: default; VCL: gtk3
  Locale: en-US (en_US.UTF-8); UI: en-US

Nice work, Sarper. Thank you!
Comment 10 Xisco Faulí 2023-11-02 18:50:15 UTC
*** Bug 132343 has been marked as a duplicate of this bug. ***