Bug 133489 - swlo.dll crashes when manipulating a table in bad state reached with Alt+Enter & Ctrl+Enter
Summary: swlo.dll crashes when manipulating a table in bad state reached with Alt+Ente...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.2.0.4 release
Hardware: All All
: medium major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, haveBacktrace, regression
Depends on:
Blocks: Writer-Tables Crash
  Show dependency treegraph
 
Reported: 2020-05-29 07:08 UTC by Octavian Vladut
Modified: 2024-02-26 06:42 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments
first cell not clickable or selectable (38.93 KB, image/png)
2020-05-29 09:02 UTC, Octavian Vladut
Details
video with the crash in safe mode (661.87 KB, video/mp4)
2020-05-29 09:02 UTC, Octavian Vladut
Details
Backtrace (31.93 KB, text/plain)
2020-06-14 02:09 UTC, Aron Budea
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Octavian Vladut 2020-05-29 07:08:02 UTC
Description:
Writer crashes when manipulating a table which entered in a bad state with a cell not selectable when performing Alt+Enter & Ctrl+Enter combinations as described before.

Steps to Reproduce:
1. Open a new document using LO Writer
2. Insert a table (2x2 is enough)
3. Select the first cell
4. Press Ctrl+Enter
5. Press Alt+Enter
6. Press Ctrl+Enter
	At this point, as a user I cannot click inside or select the first cell of the table anymore.
7. Add a table row above the first one


Actual Results:
The application crashes. Such a crash report can be seen here: crashreport.libreoffice.org/stats/crash_details/8ef1b8a2-d70f-4c6d-8745-6d88d9382692

Expected Results:
The first cell is selectable after step 6 and therefore the crash after step 7 does not occur.


Reproducible: Always


User Profile Reset: No



Additional Info:
Note: 
- The application crashes when you’re altering the table since it’s in a bad state after step 6. For ex, writer also crashes when accessing table properties and clicking reset. I also encountered times when the writer was directly crashing after I performed step 6.
- This is the outcome of the symptom described in another bug Bug 132762
Comment 1 Octavian Vladut 2020-05-29 07:26:09 UTC
Said that it occurs both on the Alpha version and the Live one. My full specs are here:
Version: 6.4.3.2 (x64)
Build ID: 747b5d0ebf89f41c860ec2a39efd7cb15b54f2d8
CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded
Comment 2 Xisco Faulí 2020-05-29 08:48:32 UTC
At step 6, I can click inside the first cell

Version: 7.0.0.0.alpha1+
Build ID: 82894d85147840f1f587e9530b12f0058f2ef2c3
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: x11
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

To be certain the reported issue is not related to corruption in the user profile, could you please reset your Libreoffice profile ( https://wiki.documentfoundation.org/UserProfile ) and re-test?

OTOH, would it be possible to attach a screencast ?

I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the issue is still present
Comment 3 Octavian Vladut 2020-05-29 09:01:12 UTC
Just reset LO Profile and restarted LO writer in safe mode. Retested the issue as described and the writer crashed again.
Attaching a screenshot and a video.
Comment 4 Octavian Vladut 2020-05-29 09:02:14 UTC
Created attachment 161387 [details]
first cell not clickable or selectable
Comment 5 Octavian Vladut 2020-05-29 09:02:50 UTC
Created attachment 161388 [details]
video with the crash in safe mode
Comment 6 Telesto 2020-05-29 15:02:44 UTC
STR not quite right.. I changed to order of 4 and 5

1. Open a new document using LO Writer
2. Insert a table (2x2 is enough)
3. Select the first cell or the first table row
4. Press Alt+Enter
5. Press Ctrl+Enter -> Table size expands (odd) cell not clickable -or starts crashing

6. If not working (does happen) CTRL+Z CTRL Z CTRL+Z
7. CTRL Y CTRL Y CTRL Y 


Version: 7.1.0.0.alpha0+ (x64)
Build ID: 41d8b41767032681a9897b7551f011d450e3725e
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (nl_NL); UI: en-US
Calc: CL
Comment 7 Telesto 2020-05-29 15:10:44 UTC Comment hidden (obsolete)
Comment 8 Xisco Faulí 2020-06-01 11:38:27 UTC
Also reproduced on linux. Reproduced back to

Version: 4.3.0.0.alpha1+
Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e

but not in

Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)
Comment 9 Aron Budea 2020-06-14 02:09:19 UTC
Created attachment 161970 [details]
Backtrace
Comment 10 Aron Budea 2020-06-14 02:12:36 UTC Comment hidden (obsolete)
Comment 11 Aron Budea 2020-06-14 02:18:07 UTC
Btw, with gtk3 VCL plugin the crash occurs right when pressing Ctrl+Enter, with gen VCL plugin it happens when hovering over the buggy cell afterwards.
Comment 12 Buovjaga 2020-06-14 16:53:55 UTC
(In reply to Aron Budea from comment #10)
> Bibisecting the crash using repo bibisect-42max yielded the following
> commit, which I don't think is the correct one. Nevertheless, the culprit
> might be close.
> The cell being unselectable is already in 3.3.0.
> 
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=b8002169336b6b7597d32755e41fa3dc2688539e
> author		Michael Stahl <mstahl@redhat.com>	2013-11-06 16:36:04 +0100
> committer	Michael Stahl <mstahl@redhat.com>	2013-11-07 14:27:50 -0600
> 
> remove INPATH and PROEXT

Got the same result with bibisect-42max
Comment 13 BogdanB 2022-01-27 21:20:01 UTC
Crash in
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 2f4f4cbeb8e50081d607b86b0475b93971c40ab8
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 14 Telesto 2022-01-27 22:19:41 UTC
Adding Michael Stahl to the loop.. An expert on the topic.. even if the bibisect being bogus..

(In reply to Aron Budea from comment #10)
> Bibisecting the crash using repo bibisect-42max yielded the following
> commit, which I don't think is the correct one. Nevertheless, the culprit
> might be close.
> The cell being unselectable is already in 3.3.0.
> 
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=b8002169336b6b7597d32755e41fa3dc2688539e
> author		Michael Stahl <mstahl@redhat.com>	2013-11-06 16:36:04 +0100
> committer	Michael Stahl <mstahl@redhat.com>	2013-11-07 14:27:50 -0600
> 
> remove INPATH and PROEXT
Comment 15 Timur 2022-03-14 15:06:40 UTC
My steps with GEN 4.2 and 7.4+:
1. Open a new document using LO Writer
2. Insert a table (2x2 is enough)
3. Select the first cell or the first table row
4. Press Alt+Enter  -> New row before table
5. Press Ctrl+Enter -> Table goes to page 2
6. Mouse hover above table -> Crash

Bibisected commit is a single source, so I tried with the previous commit. 
No crash, but I cannot click inside or select the first cell of the table.
Comment 16 Tex2002ans 2024-02-09 22:33:15 UTC
I can't reproduce this in:

Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

- - -

I followed comment 15 + comment 6 + comment 0. I even tried to select cells/rows or add a row above (using Right-Click / buttons too).

Still able to:

- Click around, select, or type in cells fine.

No crash or weird anything.

- - -

Maybe someone can retest on Linux (gtk3?) and see if they get the same results.
Comment 17 Telesto 2024-02-11 18:37:00 UTC
(In reply to Tex2002ans from comment #16)
> I can't reproduce this in:

Same here, unable to reproduce 
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 4d381b54d1c598c181b4a21a8bf0db86eb4668d1
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded
Comment 18 Kevin Suo 2024-02-26 06:42:15 UTC
I do not reproduce this on

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 61f34fde10e6f5cad7d23826b4dad716fef43e6c
CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: zh-CN (zh_CN.UTF-8); UI: zh-CN
Calc: threaded

May worth a reverst-bibisect to see where this get fixed.

Set STATUS to RESOLVED WORKSFORME as both Tex2002ans and Telesto also do not reproduce anymore.